Skip to content

[quant] follow up fixes for prepare_fx/prepare_qat_fx calls in classyvision (#105) #78660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jerryzh168 wants to merge 1 commit into from
Closed

[quant] follow up fixes for prepare_fx/prepare_qat_fx calls in classyvision (#105) #78660

jerryzh168 wants to merge 1 commit into from

Conversation

@jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Jun 1, 2022

Summary:
X-link: https://github.com/fairinternal/ClassyVision/pull/105

As follow up for #76496, we fixes the TODOs in quantization tests
by providing correct example_inputs in the tests

Test Plan:
classyvision sandcastle and ossci

Static Docs Preview: classyvision
|Full Site|

|Modified Pages|

Differential Revision: D36818665

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 1, 2022 •
edited
Loading

🔗 Helpful links

❌ 1 New Failures

As of commit 5aef5d1 (more details on the Dr. CI page):

Expand to see more
  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-xenial-cuda11.3-py3.7-gcc7 / test (default, 1, 4, linux.4xlarge.nvidia.gpu) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-06-02T22:47:50.5068610Z RuntimeError: test_ops failed! Received signal: SIGIOT 
2022-06-02T22:47:48.3610947Z   test_backward_trunc_cuda_float32 (__main__.TestCompositeComplianceCUDA) ... ok (0.003s)
2022-06-02T22:47:48.4089652Z   test_backward_unfold_cuda_float32 (__main__.TestCompositeComplianceCUDA) ... ok (0.048s)
2022-06-02T22:47:48.4252700Z   test_backward_unsqueeze_cuda_float32 (__main__.TestCompositeComplianceCUDA) ... ok (0.016s)
2022-06-02T22:47:48.4521355Z   test_backward_var_cuda_float32 (__main__.TestCompositeComplianceCUDA) ... ok (0.027s)
2022-06-02T22:47:48.4529929Z   test_backward_var_mean_cuda_float32 (__main__.TestCompositeComplianceCUDA) ... skip: Fails on ASAN! (0.001s)
2022-06-02T22:47:50.5058961Z   test_backward_vdot_cuda_float32 (__main__.TestCompositeComplianceCUDA) ... Traceback (most recent call last):
2022-06-02T22:47:50.5059829Z   File "test/run_test.py", line 1077, in <module>
2022-06-02T22:47:50.5062834Z     main()
2022-06-02T22:47:50.5063384Z   File "test/run_test.py", line 1055, in main
2022-06-02T22:47:50.5067939Z     raise RuntimeError(err_message)
2022-06-02T22:47:50.5068610Z RuntimeError: test_ops failed! Received signal: SIGIOT
2022-06-02T22:47:51.6406076Z + cleanup
2022-06-02T22:47:51.6406372Z + retcode=1
2022-06-02T22:47:51.6406589Z + set +x
2022-06-02T22:47:51.6451754Z ##[error]Process completed with exit code 1.
2022-06-02T22:47:51.6500428Z ##[group]Run pytorch/pytorch/.github/actions/get-workflow-job-id@master
2022-06-02T22:47:51.6500812Z with:
2022-06-02T22:47:51.6501350Z   github-token: ***
2022-06-02T22:47:51.6501607Z env:
2022-06-02T22:47:51.6501810Z   IN_CI: 1
2022-06-02T22:47:51.6502040Z   IS_GHA: 1
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 1, 2022

This pull request was exported from Phabricator. Differential Revision: D36818665

jerryzh168 added a commit to jerryzh168/ClassyVision-1 that referenced this pull request Jun 1, 2022
@jerryzh168 @facebook-github-bot
follow up fixes for prepare_fx/prepare_qat_fx calls in classyvision (…
64f8820 
…#78660)

Summary:
X-link: pytorch/pytorch#78660

X-link: fairinternal/ClassyVision#105

As follow up for pytorch/pytorch#76496, we fixes the TODOs in quantization tests
by providing correct example_inputs in the tests

Differential Revision: D36818665

fbshipit-source-id: 192cef688dc52a1ecf6b757a7758c9867a5b1814
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 1, 2022

This pull request was exported from Phabricator. Differential Revision: D36818665

@jerryzh168 jerryzh168 requested review from andrewor14 and vkuzo June 1, 2022 22:17
vkuzo
vkuzo reviewed Jun 1, 2022
View reviewed changes
jerryzh168 added a commit to jerryzh168/ClassyVision-1 that referenced this pull request Jun 2, 2022
@jerryzh168 @facebook-github-bot
follow up fixes for prepare_fx/prepare_qat_fx calls in classyvision (f…
4b719f3 
…acebookresearch#793)

Summary:
Pull Request resolved: facebookresearch#793

X-link: pytorch/pytorch#78660

X-link: fairinternal/ClassyVision#105

As follow up for pytorch/pytorch#76496, we fixes the TODOs in quantization tests
by providing correct example_inputs in the tests

Differential Revision: D36818665

fbshipit-source-id: 5d637488e3778949bcbb5ce24cdd19cafe12aeb6
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 2, 2022

This pull request was exported from Phabricator. Differential Revision: D36818665

jerryzh168 added a commit to jerryzh168/ClassyVision-1 that referenced this pull request Jun 2, 2022
@jerryzh168 @facebook-github-bot
follow up fixes for prepare_fx/prepare_qat_fx calls in classyvision (f…
c83240a 
…acebookresearch#793)

Summary:
Pull Request resolved: facebookresearch#793

X-link: pytorch/pytorch#78660

X-link: fairinternal/ClassyVision#105

As follow up for pytorch/pytorch#76496, we fixes the TODOs in quantization tests
by providing correct example_inputs in the tests

Reviewed By: dzdang

Differential Revision: D36818665

fbshipit-source-id: 2a8fc015c1ba29df02ddbaed447327553a928813
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 2, 2022

This pull request was exported from Phabricator. Differential Revision: D36818665

@jerryzh168 @facebook-github-bot
[quant] follow up fixes for prepare_fx/prepare_qat_fx calls in classy…
5aef5d1 
…vision (pytorch#793)

Summary:
X-link: facebookresearch/ClassyVision#793

Pull Request resolved: pytorch#78660

X-link: fairinternal/ClassyVision#105

As follow up for pytorch#76496, we fixes the TODOs in quantization tests
by providing correct example_inputs in the tests

Test Plan:
classyvision sandcastle and ossci

**Static Docs Preview: classyvision**
|[Full Site](https://our.intern.facebook.com/intern/staticdocs/eph/D36818665/V8/classyvision/)|

|**Modified Pages**|

Reviewed By: dzdang

Differential Revision: D36818665

fbshipit-source-id: ad090e4bf8820777b32540e4decfe741aeac26a7
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 2, 2022

This pull request was exported from Phabricator. Differential Revision: D36818665

facebook-github-bot pushed a commit to facebookresearch/ClassyVision that referenced this pull request Jun 3, 2022
@jerryzh168 @facebook-github-bot
follow up fixes for prepare_fx/prepare_qat_fx calls in classyvision (#…
5b0edda 
…793)

Summary:
Pull Request resolved: #793

X-link: pytorch/pytorch#78660

X-link: fairinternal/ClassyVision#105

As follow up for pytorch/pytorch#76496, we fixes the TODOs in quantization tests
by providing correct example_inputs in the tests

Reviewed By: dzdang

Differential Revision: D36818665

fbshipit-source-id: 07bef205c352910642983a786b4346aa7165c14a
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 3, 2022

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2022

Hey @jerryzh168.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jun 3, 2022
@jerryzh168 @facebook-github-bot
[quant] follow up fixes for prepare_fx/prepare_qat_fx calls in classy…
10140cd 
…vision (#793)

Summary:
X-link: facebookresearch/ClassyVision#793

Pull Request resolved: #78660

X-link: fairinternal/ClassyVision#105

As follow up for #76496, we fixes the TODOs in quantization tests
by providing correct example_inputs in the tests

Test Plan:
classyvision sandcastle and ossci

**Static Docs Preview: classyvision**
|[Full Site](https://our.intern.facebook.com/intern/staticdocs/eph/D36818665/V8/classyvision/)|

|**Modified Pages**|

Reviewed By: dzdang

Differential Revision: D36818665

fbshipit-source-id: 07bef205c352910642983a786b4346aa7165c14a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkuzo vkuzo vkuzo approved these changes

@andrewor14 andrewor14 Awaiting requested review from andrewor14

Assignees

No one assigned

Labels

cla signed fb-exported Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jerryzh168 @facebook-github-bot @vkuzo @pytorchmergebot