-
Notifications
You must be signed in to change notification settings - Fork 26.3k
extract aten_core_srcs function into shared build structure #78535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This captures some overlap between Bazel and fbcode. Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)! [ghstack-poisoned]
🔗 Helpful links
❌ 2 New FailuresAs of commit 1e19fbc (more details on the Dr. CI page): Expand to see more
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
This captures some overlap between Bazel and fbcode. Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)! ghstack-source-id: 157660578 Pull Request resolved: #78535
This captures some overlap between Bazel and fbcode. Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)! [ghstack-poisoned]
This captures some overlap between Bazel and fbcode. Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)! [ghstack-poisoned]
Pull Request resolved: #78535 This captures some overlap between Bazel and fbcode. ghstack-source-id: 157660578 Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)!
This captures some overlap between Bazel and fbcode. Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)! [ghstack-poisoned]
Pull Request resolved: #78535 This captures some overlap between Bazel and fbcode. ghstack-source-id: 157660578 Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)!
This captures some overlap between Bazel and fbcode. Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)! [ghstack-poisoned]
This captures some overlap between Bazel and fbcode. Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)! [ghstack-poisoned]
Pull Request resolved: #78535 This captures some overlap between Bazel and fbcode. ghstack-source-id: 157660578 Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)!
This captures some overlap between Bazel and fbcode. Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)! [ghstack-poisoned]
Pull Request resolved: #78535 This captures some overlap between Bazel and fbcode. ghstack-source-id: 157660578 Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)!
This captures some overlap between Bazel and fbcode. Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)! [ghstack-poisoned]
This captures some overlap between Bazel and fbcode. Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)! [ghstack-poisoned]
Pull Request resolved: #78535 This captures some overlap between Bazel and fbcode. ghstack-source-id: 157660578 Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)!
This captures some overlap between Bazel and fbcode. Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)! [ghstack-poisoned]
This captures some overlap between Bazel and fbcode. Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)! [ghstack-poisoned]
This captures some overlap between Bazel and fbcode. Differential Revision: [D36780883](https://our.internmc.facebook.com/intern/diff/D36780883/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36780883/)! [ghstack-poisoned]
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
/easycla As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details. This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign. |
Stack from ghstack (oldest at bottom):
This captures some overlap between Bazel and fbcode.
Differential Revision: D36780883
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!