Skip to content

remove Bazel globs that don't match any files #78007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dagitses wants to merge 25 commits into from
Closed

remove Bazel globs that don't match any files #78007

dagitses wants to merge 25 commits into from

Conversation

@dagitses
Copy link
Collaborator

@dagitses dagitses commented May 20, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

These are vestigial.

Differential Revision: D36558465

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 20, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 36a81a0 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced May 20, 2022
Closed
Closed
Closed
Closed
Closed
Closed
dagitses pushed a commit that referenced this pull request May 20, 2022
remove Bazel globs that don't match any files
4a83097 
These are vestigial.

Differential Revision: [D36558465](https://our.internmc.facebook.com/intern/diff/D36558465/)

ghstack-source-id: 156951398
Pull Request resolved: #78007
dagitses pushed a commit that referenced this pull request May 20, 2022
remove Bazel globs that don't match any files
69b8bba 
Pull Request resolved: #78007

These are vestigial.
ghstack-source-id: 156951398

Differential Revision: [D36558465](https://our.internmc.facebook.com/intern/diff/D36558465/)
@dagitses dagitses mentioned this pull request May 21, 2022
Closed
Michael Andreas Dagitses added 5 commits May 20, 2022 19:33
Update on "remove Bazel globs that don't match any files"
7ebb0e6 
These are vestigial.

Differential Revision: [D36558465](https://our.internmc.facebook.com/intern/diff/D36558465/)

[ghstack-poisoned]
Update on "remove Bazel globs that don't match any files"
d8ce8ce 
These are vestigial.

Differential Revision: [D36558465](https://our.internmc.facebook.com/intern/diff/D36558465/)

[ghstack-poisoned]
Update on "remove Bazel globs that don't match any files"
045e5b1 
These are vestigial.

Differential Revision: [D36558465](https://our.internmc.facebook.com/intern/diff/D36558465/)

[ghstack-poisoned]
Update on "remove Bazel globs that don't match any files"
f490f70 
These are vestigial.

Differential Revision: [D36558465](https://our.internmc.facebook.com/intern/diff/D36558465/)

[ghstack-poisoned]
Update on "remove Bazel globs that don't match any files"
051a0b8 
These are vestigial.

Differential Revision: [D36558465](https://our.internmc.facebook.com/intern/diff/D36558465/)

[ghstack-poisoned]
This was referenced May 23, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Michael Andreas Dagitses added 4 commits May 23, 2022 07:12
Update on "remove Bazel globs that don't match any files"
34f5085 
These are vestigial.

Differential Revision: [D36558465](https://our.internmc.facebook.com/intern/diff/D36558465/)

[ghstack-poisoned]
Update on "remove Bazel globs that don't match any files"
c15cb19 
These are vestigial.

Differential Revision: [D36558465](https://our.internmc.facebook.com/intern/diff/D36558465/)

[ghstack-poisoned]
Update on "remove Bazel globs that don't match any files"
dea032e 
These are vestigial.

Differential Revision: [D36558465](https://our.internmc.facebook.com/intern/diff/D36558465/)

[ghstack-poisoned]
Update on "remove Bazel globs that don't match any files"
d21b7d8 
These are vestigial.

Differential Revision: [D36558465](https://our.internmc.facebook.com/intern/diff/D36558465/)

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request May 23, 2022
Closed
@dagitses dagitses mentioned this pull request May 23, 2022
Closed
@dagitses dagitses mentioned this pull request May 23, 2022
Closed
Michael Andreas Dagitses added 6 commits May 23, 2022 10:36
Update on "remove Bazel globs that don't match any files"
058d195 
These are vestigial.

Differential Revision: [D36558465](https://our.internmc.facebook.com/intern/diff/D36558465/)

[ghstack-poisoned]
Update on "remove Bazel globs that don't match any files"
b5cd765 
These are vestigial.

Differential Revision: [D36558465](https://our.internmc.facebook.com/intern/diff/D36558465/)

[ghstack-poisoned]
Update on "remove Bazel globs that don't match any files"
058a67f 
These are vestigial.

Differential Revision: [D36558465](https://our.internmc.facebook.com/intern/diff/D36558465/)

[ghstack-poisoned]
Update on "remove Bazel globs that don't match any files"
0583596 
These are vestigial.

Differential Revision: [D36558465](https://our.internmc.facebook.com/intern/diff/D36558465/)

[ghstack-poisoned]
Update on "remove Bazel globs that don't match any files"
87c8aa7 
These are vestigial.

Differential Revision: [D36558465](https://our.internmc.facebook.com/intern/diff/D36558465/)

[ghstack-poisoned]
Update on "remove Bazel globs that don't match any files"
2d0cc59 
These are vestigial.

Differential Revision: [D36558465](https://our.internmc.facebook.com/intern/diff/D36558465/)

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request May 31, 2022
Closed
@dagitses dagitses mentioned this pull request May 31, 2022
Closed
dagitses pushed a commit that referenced this pull request Jun 2, 2022
remove Bazel globs that don't match any files
401d651 
Pull Request resolved: #78007

These are vestigial.
ghstack-source-id: 157902576

Differential Revision: [D36558465](https://our.internmc.facebook.com/intern/diff/D36558465/)
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 2, 2022

@pytorchbot merge

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

Hey @dagitses.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

bigfootjon pushed a commit that referenced this pull request Jun 2, 2022
@facebook-github-bot
remove Bazel globs that don't match any files (#78007)
f8ef5c8 
Summary:
Pull Request resolved: #78007

These are vestigial.
ghstack-source-id: 157902576

Test Plan: Rely on CI.

Reviewed By: kit1980

Differential Revision: D36558465

fbshipit-source-id: d1f4572c73486f2b765c85f48c9a84571ee1b433
@facebook-github-bot facebook-github-bot deleted the gh/dagitses/348/head branch June 6, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kit1980 kit1980 kit1980 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dagitses @facebook-github-bot @kit1980 @pytorchmergebot