move gen_aten and gen_aten_hip into shared build structure #77751

dagitses · 2022-05-18T16:12:13Z

Stack from ghstack (oldest at bottom):

This requires two changes to rule generation:

pulling the cpu static dispatch prediction into the rules
disabling the Bazel-style generated file aliases

Differential Revision: D36481918

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! [ghstack-poisoned]

facebook-github-bot · 2022-05-18T16:12:19Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/77751
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours

✅ No Failures (0 Pending)

As of commit f74a8f6 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! [ghstack-poisoned]

Pull Request resolved: #77751 This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! ghstack-source-id: 158938991

This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! [ghstack-poisoned]

Pull Request resolved: #77751 This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases ghstack-source-id: 158938991 Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)!

This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! [ghstack-poisoned]

Pull Request resolved: #77751 This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases ghstack-source-id: 158938991 Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)!

Summary: Pull Request resolved: #77751 This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases ghstack-source-id: 158938991 Test Plan: Rely on CI. Reviewed By: kit1980 Differential Revision: D36481918 fbshipit-source-id: c6d53a9acad3a94290313db2b9db9fe5ab4dbf7a

bigfootjon · 2022-06-15T17:14:07Z

@pytorchbot merge

pytorchmergebot · 2022-06-15T17:16:20Z

@pytorchbot successfully started a merge job. Check the current status here

pytorchmergebot · 2022-06-15T17:16:23Z

Merge failed due to This PR has internal changes and must be landed via Phabricator
Raised by https://github.com/pytorch/pytorch/actions/runs/2503948302

This requires two changes to rule generation: * pulling the cpu static dispatch prediction into the rules * disabling the Bazel-style generated file aliases Differential Revision: [D36481918](https://our.internmc.facebook.com/intern/diff/D36481918/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36481918/)! [ghstack-poisoned]

facebook-github-bot · 2022-06-15T18:14:58Z

@pytorchbot merge

pytorchmergebot · 2022-06-15T18:16:09Z

@pytorchbot successfully started a merge job. Check the current status here

pytorchmergebot · 2022-06-15T18:16:13Z

Merge failed due to Refusing to merge as mandatory check(s) linux-docs / build-docs (cpp), linux-docs / build-docs (python), win-vs2019-cpu-py3 / build, win-vs2019-cuda11.3-py3 / build, linux-bionic-py3.7-clang9 / build, linux-xenial-py3.7-clang7-onnx / build, linux-vulkan-bionic-py3.7-clang9 / build, linux-xenial-cuda11.3-py3.7-gcc7 / build, linux-bionic-cuda11.3-py3.7-clang9 / build, linux-xenial-py3-clang5-mobile-custom-build-static / build, pytorch-xla-linux-bionic-py3.7-clang8 / build, deploy-linux-xenial-cuda11.3-py3.7-gcc7 / build, linux-focal-py3.7-gcc7 / build are pending/not yet run for rule superuser
Raised by https://github.com/pytorch/pytorch/actions/runs/2504265382

facebook-github-bot · 2022-06-15T18:21:38Z

@pytorchbot merge -f

pytorchmergebot · 2022-06-15T18:22:48Z

@pytorchbot successfully started a merge job. Check the current status here

github-actions · 2022-06-15T18:23:32Z

Hey @dagitses.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot added the cla signed label May 18, 2022

dagitses mentioned this pull request May 18, 2022

gen_aten output into aten/src/ATen/ #77773

Closed

Michael Andreas Dagitses added 2 commits May 18, 2022 12:02

dagitses mentioned this pull request May 18, 2022

switch Bazel to common aten codegen #77778

Closed

dagitses mentioned this pull request May 18, 2022

gen_aten uses full paths to aten files #77788

Closed

dagitses mentioned this pull request May 18, 2022

eliminate generated_cpu_cpp and generated_cuda_cpp from Bazel #77790

Closed

Michael Andreas Dagitses added 2 commits May 18, 2022 14:11

dagitses mentioned this pull request May 31, 2022

extract aten_core_srcs function into shared build structure #78535

Closed

dagitses mentioned this pull request May 31, 2022

move pytorch-root/tools/build_variables.bzl to the pytorch-root #78542

Closed

kit1980 approved these changes Jun 2, 2022

View reviewed changes

seemethere approved these changes Jun 15, 2022

View reviewed changes

pytorchmergebot added the Merged label Jun 15, 2022

pytorchmergebot closed this in eb5751d Jun 15, 2022

facebook-github-bot deleted the gh/dagitses/340/head branch June 19, 2022 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

move gen_aten and gen_aten_hip into shared build structure #77751

move gen_aten and gen_aten_hip into shared build structure #77751

Uh oh!

dagitses commented May 18, 2022 •

edited

Loading

Uh oh!

facebook-github-bot commented May 18, 2022 •

edited

Loading

Uh oh!

bigfootjon commented Jun 15, 2022

Uh oh!

pytorchmergebot commented Jun 15, 2022

Uh oh!

pytorchmergebot commented Jun 15, 2022

Uh oh!

facebook-github-bot commented Jun 15, 2022

Uh oh!

pytorchmergebot commented Jun 15, 2022

Uh oh!

pytorchmergebot commented Jun 15, 2022

Uh oh!

facebook-github-bot commented Jun 15, 2022

Uh oh!

pytorchmergebot commented Jun 15, 2022

Uh oh!

github-actions bot commented Jun 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

move gen_aten and gen_aten_hip into shared build structure #77751

move gen_aten and gen_aten_hip into shared build structure #77751

Uh oh!

Conversation

dagitses commented May 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented May 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

✅ No Failures (0 Pending)

Uh oh!

bigfootjon commented Jun 15, 2022

Uh oh!

pytorchmergebot commented Jun 15, 2022

Uh oh!

pytorchmergebot commented Jun 15, 2022

Uh oh!

facebook-github-bot commented Jun 15, 2022

Uh oh!

pytorchmergebot commented Jun 15, 2022

Uh oh!

pytorchmergebot commented Jun 15, 2022

Uh oh!

facebook-github-bot commented Jun 15, 2022

Uh oh!

pytorchmergebot commented Jun 15, 2022

Uh oh!

github-actions bot commented Jun 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dagitses commented May 18, 2022 •

edited

Loading

facebook-github-bot commented May 18, 2022 •

edited

Loading