move GENERATED_CPP_CUDA to caffe2/build.bzl #77744

dagitses · 2022-05-18T15:25:25Z

Stack from ghstack (oldest at bottom):

-> move GENERATED_CPP_CUDA to caffe2/build.bzl #77744

This is needed by gen_aten and it's immediate downstream libraries. As
such, it can live solely in the shared build structure.

Differential Revision: D36480812

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]

facebook-github-bot · 2022-05-18T15:25:30Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/77744
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours

✅ No Failures (0 Pending)

As of commit 1e8b550 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]

Pull Request resolved: #77744 This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. ghstack-source-id: 157009736 Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)!

This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]

Pull Request resolved: #77744 This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. ghstack-source-id: 157768285 Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)!

This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)! [ghstack-poisoned]

Pull Request resolved: #77744 This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. ghstack-source-id: 157879134 Differential Revision: [D36480812](https://our.internmc.facebook.com/intern/diff/D36480812/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36480812/)!

facebook-github-bot · 2022-06-02T18:36:52Z

@pytorchbot merge

github-actions · 2022-06-02T18:38:42Z

Hey @dagitses.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Summary: Pull Request resolved: #77744 This is needed by gen_aten and it's immediate downstream libraries. As such, it can live solely in the shared build structure. ghstack-source-id: 157879134 Test Plan: Rely on CI. Reviewed By: kit1980 Differential Revision: D36480812 fbshipit-source-id: 05c3327c3b01f30205af9879a4db51bf387dcb6a

facebook-github-bot added the cla signed label May 18, 2022

This was referenced May 18, 2022

move generated-autograd-headers to the shared build structure #76183

Closed

remove unnecessary ATen/core/Macros.h #76376

Closed

move generated_srcs_list.bzl into caffe2/build.bzl #77680

Closed

move aten_ufunc_headers to ufunc_defs.bzl #77745

Closed

dagitses mentioned this pull request May 18, 2022

use ufunc_defs.bzl in BUILD.bazel #77747

Closed

Michael Andreas Dagitses added 2 commits May 18, 2022 08:38

dagitses mentioned this pull request May 18, 2022

move ufunc_defs.bzl to the top-level #77749

Closed

Michael Andreas Dagitses added 2 commits May 18, 2022 08:57

dagitses mentioned this pull request May 18, 2022

move gen_aten and gen_aten_hip into shared build structure #77751

Closed

Michael Andreas Dagitses added 5 commits May 18, 2022 09:17

dagitses mentioned this pull request May 18, 2022

gen_aten output into aten/src/ATen/ #77773

Closed

Michael Andreas Dagitses added 2 commits May 18, 2022 12:02

dagitses mentioned this pull request May 18, 2022

switch Bazel to common aten codegen #77778

Closed

dagitses mentioned this pull request May 18, 2022

gen_aten uses full paths to aten files #77788

Closed

dagitses mentioned this pull request May 18, 2022

eliminate generated_cpu_cpp and generated_cuda_cpp from Bazel #77790

Closed

Michael Andreas Dagitses added 2 commits May 18, 2022 14:11

dagitses mentioned this pull request May 23, 2022

move aten_core_headers to common build structure #78093

Closed

dagitses mentioned this pull request May 23, 2022

move the GENERATED_CORE_H headers into aten_core_headers #78097

Closed

Michael Andreas Dagitses added 2 commits May 23, 2022 09:58

dagitses mentioned this pull request May 23, 2022

use full paths to files to generate-code genrule #78104

Closed

Michael Andreas Dagitses added 6 commits May 23, 2022 10:35

dagitses mentioned this pull request May 31, 2022

extract aten_core_srcs function into shared build structure #78535

Closed

dagitses mentioned this pull request May 31, 2022

move pytorch-root/tools/build_variables.bzl to the pytorch-root #78542

Closed

kit1980 approved these changes Jun 1, 2022

View reviewed changes

pytorchmergebot added the Merged label Jun 2, 2022

pytorchmergebot closed this in 7d12eec Jun 2, 2022

facebook-github-bot deleted the gh/dagitses/336/head branch June 6, 2022 14:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

move GENERATED_CPP_CUDA to caffe2/build.bzl #77744

move GENERATED_CPP_CUDA to caffe2/build.bzl #77744

Uh oh!

dagitses commented May 18, 2022 •

edited

Loading

Uh oh!

facebook-github-bot commented May 18, 2022 •

edited

Loading

Uh oh!

facebook-github-bot commented Jun 2, 2022

Uh oh!

github-actions bot commented Jun 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

move GENERATED_CPP_CUDA to caffe2/build.bzl #77744

move GENERATED_CPP_CUDA to caffe2/build.bzl #77744

Uh oh!

Conversation

dagitses commented May 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented May 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

✅ No Failures (0 Pending)

Uh oh!

facebook-github-bot commented Jun 2, 2022

Uh oh!

github-actions bot commented Jun 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dagitses commented May 18, 2022 •

edited

Loading

facebook-github-bot commented May 18, 2022 •

edited

Loading