[mergebot] Add all-green option #77660
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🔗 Helpful links
❌ 4 New FailuresAs of commit f04e6a9 (more details on the Dr. CI page): Expand to see more
🕵️ 4 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
seemethere
reviewed
May 17, 2022
janeyx99
requested changes
May 18, 2022
Contributor
janeyx99
left a comment
janeyx99
left a comment
There was a problem hiding this comment.
I think the best way to do this while abiding by other checks is to pass all_green to find_matching_merge_rules still and then changing the code near
if rule.mandatory_checks_name is not None:
to check all checks instead of just the mandatory ones if allgreen is true
janeyx99
reviewed
May 20, 2022
| if len(pending_checks) > 0: | ||
| reject_reason = f"Refusing to merge as mandatory check(s) {','.join(pending_checks)} are missing" | ||
| raise MandatoryChecksMissingError(reject_reason) | ||
| pr.merge_into(repo, dry_run=dry_run) |
Contributor
There was a problem hiding this comment.
Oh I see, this calls the code that makes the find_matching_merge_rule. In that case go for it lol, but Eli's comment about the API limit is important since we did have SEVs about our GITHUB_TOKEN getting overused.
janeyx99
approved these changes
May 20, 2022
Contributor
Author
|
@pytorchbot merge -g |
Contributor
|
Hey @zengk95. |
Contributor
pytorchmergebot
added a commit
that referenced
this pull request
May 20, 2022
This reverts commit 340c412. Reverted #77660 on behalf of https://github.com/malfet due to as it broke lint, see https://github.com/pytorch/pytorch/runs/6532480582?check_suite_focus=true
Member
|
Looks like a land race |
Contributor
|
@pytorchbot rebase |
Collaborator
|
Rebase failed due to Command |
swang392
pushed a commit
that referenced
this pull request
May 25, 2022
Since we released on-green, some people have requested an all green option to include everything. I was thinking of how to best add this into find_matching_merge_rule but I couldn't think of a good a great way since the option isn't really a merge_rule, rather overriding it so I just put it outside the method. Pull Request resolved: #77660 Approved by: https://github.com/janeyx99
swang392
pushed a commit
that referenced
this pull request
May 25, 2022
This reverts commit 340c412. Reverted #77660 on behalf of https://github.com/malfet due to as it broke lint, see https://github.com/pytorch/pytorch/runs/6532480582?check_suite_focus=true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we released on-green, some people have requested an all green option to include everything.
I was thinking of how to best add this into find_matching_merge_rule but I couldn't think of a good a great way since the option isn't really a merge_rule, rather overriding it so I just put it outside the method.