Skip to content

fix anon-struct usage that's a warning/error -Wnon-c-typedef-for-linkage (#137) #76610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
luciang wants to merge 1 commit into from
Closed

fix anon-struct usage that's a warning/error -Wnon-c-typedef-for-linkage (#137) #76610

luciang wants to merge 1 commit into from

Conversation

@luciang
Copy link
Contributor

@luciang luciang commented Apr 30, 2022

Summary:
X-link: facebook/CacheLib#137

Fix
error: anonymous non-C-compatible type given name for linkage purposes by alias declaration; add a tag name here [-Werror,-Wnon-c-typedef-for-linkage]

Test Plan:

buck-out/v2/gen/fbcode/d839c731f5505c62/datasec/messaging/auth/utils/__MessagingAuthUtils__/headers/datasec/messaging/auth/utils/MessagingAuthLogger.h:83:25: error: anonymous non-C-compatible type given name for linkage purposes by alias declaration; add a tag name here [-Werror,-Wnon-c-typedef-for-linkage]
  using LogInfo = struct {

CI

Reviewed By: philippv

Differential Revision: D36043476

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 30, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 112512c (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 30, 2022

This pull request was exported from Phabricator. Differential Revision: D36043476

luciang added a commit to luciang/CacheLib that referenced this pull request Apr 30, 2022
@luciang @facebook-github-bot
fix anon-struct usage that's a warning/error -Wnon-c-typedef-for-link…
4cd5f1f 
…age (#76610)

Summary:
X-link: pytorch/pytorch#76610

X-link: pytorch/gloo#328

X-link: facebookarchive/fbzmq#38

Pull Request resolved: facebook#137

Fix
  error: anonymous non-C-compatible type given name for linkage purposes by alias declaration; add a tag name here [-Werror,-Wnon-c-typedef-for-linkage]

Reviewed By: philippv

Differential Revision: D36043476

fbshipit-source-id: d26f1bf9952b4371d3d4901ae15a68af8fd4c2a1
luciang added a commit to luciang/gloo that referenced this pull request Apr 30, 2022
@luciang @facebook-github-bot
fix anon-struct usage that's a warning/error -Wnon-c-typedef-for-link…
7519f32 
…age (#76610)

Summary:
X-link: pytorch/pytorch#76610

Pull Request resolved: pytorch#328

X-link: facebookarchive/fbzmq#38

X-link: facebook/CacheLib#137

Fix
  error: anonymous non-C-compatible type given name for linkage purposes by alias declaration; add a tag name here [-Werror,-Wnon-c-typedef-for-linkage]

Reviewed By: philippv

Differential Revision: D36043476

fbshipit-source-id: 6e1dc16bf1d205bfcf1a359f0e812a9bfdb0d039
luciang added a commit to luciang/fbzmq that referenced this pull request Apr 30, 2022
@luciang @facebook-github-bot
fix anon-struct usage that's a warning/error -Wnon-c-typedef-for-link…
3d259d7 
…age (#76610)

Summary:
X-link: pytorch/pytorch#76610

X-link: pytorch/gloo#328

Pull Request resolved: facebookarchive#38

X-link: facebook/CacheLib#137

Fix
  error: anonymous non-C-compatible type given name for linkage purposes by alias declaration; add a tag name here [-Werror,-Wnon-c-typedef-for-linkage]

Reviewed By: philippv

Differential Revision: D36043476

fbshipit-source-id: 953e43613479fb142ea2ccf29f3d0a39402e4122
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 30, 2022

This pull request was exported from Phabricator. Differential Revision: D36043476

@luciang @facebook-github-bot
fix anon-struct usage that's a warning/error -Wnon-c-typedef-for-link…
112512c 
…age (pytorch#76610)

Summary:
Pull Request resolved: pytorch#76610

X-link: pytorch/gloo#328

X-link: facebookarchive/fbzmq#38

X-link: facebook/CacheLib#137

Fix
  error: anonymous non-C-compatible type given name for linkage purposes by alias declaration; add a tag name here [-Werror,-Wnon-c-typedef-for-linkage]

Test Plan:
```name=before
buck-out/v2/gen/fbcode/d839c731f5505c62/datasec/messaging/auth/utils/__MessagingAuthUtils__/headers/datasec/messaging/auth/utils/MessagingAuthLogger.h:83:25: error: anonymous non-C-compatible type given name for linkage purposes by alias declaration; add a tag name here [-Werror,-Wnon-c-typedef-for-linkage]
  using LogInfo = struct {
```

CI

Reviewed By: philippv

Differential Revision: D36043476

fbshipit-source-id: 679f3b5efd0d233f6cb472e9cba54747ffd49c4e
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 30, 2022

This pull request was exported from Phabricator. Differential Revision: D36043476

@osalpekar
Copy link
Member

osalpekar commented May 2, 2022

@pytorchbot merge this please

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented May 2, 2022

Merge failed due to Matched rule superuser, but it was not reviewed yet by any of:vivekmig,houseroad,shoumikhin,kiukchung,davides, ...
Raised by https://github.com/pytorch/pytorch/actions/runs/2259586421

@osalpekar
Copy link
Member

osalpekar commented May 2, 2022

@pytorchbot merge this please

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2022

Hey @luciang.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@osalpekar osalpekar osalpekar approved these changes

+1 more reviewer

@philippv philippv philippv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@luciang @facebook-github-bot @osalpekar @pytorchmergebot @philippv