eliminate Bazel's libtorch_cpp_generated_sources #76179
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
Contributor
🔗 Helpful links
❌ 1 New FailuresAs of commit 6ce2dbb (more details on the Dr. CI page): Expand to see more
🕵️♀️ 1 failure not recognized by patterns:The following CI failures may be due to changes from the PR
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Apr 21, 2022
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
added 6 commits
April 22, 2022 10:01
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
added 11 commits
May 2, 2022 03:03
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
dreiss
approved these changes
May 5, 2022
added 12 commits
May 6, 2022 05:18
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
This list is redundant with the shared build structure. Differential Revision: [D35818500](https://our.internmc.facebook.com/intern/diff/D35818500/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35818500/)! [ghstack-poisoned]
Contributor
|
@pytorchbot merge this (Initiating merge automatically since Phabricator Diff has merged) |
Contributor
|
Hey @dagitses. |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 17, 2022
Summary: Pull Request resolved: #76179 This list is redundant with the shared build structure. ghstack-source-id: 155300057 Test Plan: Rely on CI. Reviewed By: dreiss Differential Revision: D35818500 fbshipit-source-id: 7c244fe71d6e742af98d8964a6cb901bc29afbaf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This list is redundant with the shared build structure.
Differential Revision: D35818500
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!