move version_h to shared build structure in Buck #75964
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D35443900](https://our.internmc.facebook.com/intern/diff/D35443900/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35443900/)! [ghstack-poisoned]
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 8b90c47 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Apr 18, 2022
added 4 commits
April 18, 2022 06:52
Differential Revision: [D35443900](https://our.internmc.facebook.com/intern/diff/D35443900/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35443900/)! [ghstack-poisoned]
Differential Revision: [D35443900](https://our.internmc.facebook.com/intern/diff/D35443900/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35443900/)! [ghstack-poisoned]
Differential Revision: [D35443900](https://our.internmc.facebook.com/intern/diff/D35443900/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35443900/)! [ghstack-poisoned]
Differential Revision: [D35443900](https://our.internmc.facebook.com/intern/diff/D35443900/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35443900/)! [ghstack-poisoned]
This was referenced Apr 21, 2022
added 6 commits
April 21, 2022 07:22
Differential Revision: [D35443900](https://our.internmc.facebook.com/intern/diff/D35443900/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35443900/)! [ghstack-poisoned]
Differential Revision: [D35443900](https://our.internmc.facebook.com/intern/diff/D35443900/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35443900/)! [ghstack-poisoned]
Differential Revision: [D35443900](https://our.internmc.facebook.com/intern/diff/D35443900/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35443900/)! [ghstack-poisoned]
Differential Revision: [D35443900](https://our.internmc.facebook.com/intern/diff/D35443900/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35443900/)! [ghstack-poisoned]
Differential Revision: [D35443900](https://our.internmc.facebook.com/intern/diff/D35443900/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35443900/)! [ghstack-poisoned]
Differential Revision: [D35443900](https://our.internmc.facebook.com/intern/diff/D35443900/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35443900/)! [ghstack-poisoned]
added 2 commits
April 21, 2022 09:11
Differential Revision: [D35443900](https://our.internmc.facebook.com/intern/diff/D35443900/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35443900/)! [ghstack-poisoned]
Differential Revision: [D35443900](https://our.internmc.facebook.com/intern/diff/D35443900/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35443900/)! [ghstack-poisoned]
added 2 commits
April 21, 2022 09:37
Differential Revision: [D35443900](https://our.internmc.facebook.com/intern/diff/D35443900/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35443900/)! [ghstack-poisoned]
Differential Revision: [D35443900](https://our.internmc.facebook.com/intern/diff/D35443900/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35443900/)! [ghstack-poisoned]
Differential Revision: [D35443900](https://our.internmc.facebook.com/intern/diff/D35443900/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35443900/)! [ghstack-poisoned]
malfet
approved these changes
Apr 21, 2022
added 5 commits
April 22, 2022 10:00
Differential Revision: [D35443900](https://our.internmc.facebook.com/intern/diff/D35443900/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35443900/)! [ghstack-poisoned]
Differential Revision: [D35443900](https://our.internmc.facebook.com/intern/diff/D35443900/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35443900/)! [ghstack-poisoned]
Differential Revision: [D35443900](https://our.internmc.facebook.com/intern/diff/D35443900/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35443900/)! [ghstack-poisoned]
Differential Revision: [D35443900](https://our.internmc.facebook.com/intern/diff/D35443900/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35443900/)! [ghstack-poisoned]
Differential Revision: [D35443900](https://our.internmc.facebook.com/intern/diff/D35443900/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35443900/)! [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 26, 2022
Summary: Pull Request resolved: #75964 This is already in the shared build structure for Bazel, but we need to implement genrule for fbcode. There's an xplat target that can't build in fbcode yet because the dependencies don't line up, so we have to add a tag to exclude it. ghstack-source-id: 154696020 Test Plan: Rely on CI Reviewed By: malfet Differential Revision: D35443900 fbshipit-source-id: 0768b29906c8218d7aebfdc7c18d69f59a0c9384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D35443900
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!