define and disable the caffe2_serialize target in Bazel #75942
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit bf5ad78 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Apr 16, 2022
added 8 commits
April 16, 2022 14:04
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
added 4 commits
April 18, 2022 06:52
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
This was referenced Apr 21, 2022
added 2 commits
April 21, 2022 07:22
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
added 4 commits
April 21, 2022 08:08
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
added 2 commits
April 21, 2022 09:11
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
added 3 commits
April 21, 2022 09:37
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
malfet
approved these changes
Apr 21, 2022
added 4 commits
April 22, 2022 10:00
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
This has not yet been made compatible with Bazel. Disable it for now. Differential Revision: [D35704597](https://our.internmc.facebook.com/intern/diff/D35704597/) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 25, 2022
Summary: Pull Request resolved: #75942 This also requires changes to the target definition and the xplat translator to get it working. ghstack-source-id: 154678046 Test Plan: Verify locally and rely on CI. Reviewed By: malfet Differential Revision: D35704597 fbshipit-source-id: 6b0d9f5a044609b24dda656f80233ba6186c097f
Contributor
|
Hey @dagitses. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This has not yet been made compatible with Bazel. Disable it for now.
Differential Revision: D35704597