Skip to content

remove unused --ninja-global from codegen #75869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dagitses wants to merge 37 commits into from
Closed

remove unused --ninja-global from codegen #75869

dagitses wants to merge 37 commits into from

Conversation

@dagitses
Copy link
Collaborator

@dagitses dagitses commented Apr 15, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

Differential Revision: D35674694

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 15, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit e4d4146 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced Apr 15, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Michael Andreas Dagitses added 8 commits April 15, 2022 06:26
Update on "remove unused --ninja-global from codegen"
f673236 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
Update on "remove unused --ninja-global from codegen"
a13c681 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
Update on "remove unused --ninja-global from codegen"
2be48a1 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
Update on "remove unused --ninja-global from codegen"
2ca3d72 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
Update on "remove unused --ninja-global from codegen"
e2e1a7c 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
Update on "remove unused --ninja-global from codegen"
f6ce453 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
Update on "remove unused --ninja-global from codegen"
b7259ac 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
Update on "remove unused --ninja-global from codegen"
85088b1 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request Apr 16, 2022
Closed
Michael Andreas Dagitses added 8 commits April 16, 2022 14:04
Update on "remove unused --ninja-global from codegen"
7ba1320 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
Update on "remove unused --ninja-global from codegen"
7fb3bbd 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
Update on "remove unused --ninja-global from codegen"
eabd702 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
Update on "remove unused --ninja-global from codegen"
f3b710f 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
Update on "remove unused --ninja-global from codegen"
bab65a3 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
Update on "remove unused --ninja-global from codegen"
0a2cafd 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
Update on "remove unused --ninja-global from codegen"
36010a5 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
Update on "remove unused --ninja-global from codegen"
b6f8907 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
This was referenced Apr 21, 2022
Closed
Closed
Michael Andreas Dagitses added 6 commits April 21, 2022 07:22
Update on "remove unused --ninja-global from codegen"
a9f3f72 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
Update on "remove unused --ninja-global from codegen"
39ff36f 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
Update on "remove unused --ninja-global from codegen"
37de83c 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
Update on "remove unused --ninja-global from codegen"
a3d3061 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
Update on "remove unused --ninja-global from codegen"
59acd5c 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
Update on "remove unused --ninja-global from codegen"
62439cc 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request Apr 21, 2022
Closed
@dagitses dagitses mentioned this pull request Apr 21, 2022
Closed
@dagitses dagitses mentioned this pull request Apr 21, 2022
Closed
Michael Andreas Dagitses added 5 commits April 22, 2022 10:00
Update on "remove unused --ninja-global from codegen"
7b10777 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
Update on "remove unused --ninja-global from codegen"
9301dcb 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
Update on "remove unused --ninja-global from codegen"
dbb3ed9 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
Update on "remove unused --ninja-global from codegen"
65a85fd 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
Update on "remove unused --ninja-global from codegen"
e4d4146 
Differential Revision: [D35674694](https://our.internmc.facebook.com/intern/diff/D35674694/)

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Apr 26, 2022
@facebook-github-bot
remove unused --ninja-global from codegen (#75869)
cac15ca 
Summary:
Pull Request resolved: #75869

ghstack-source-id: 154696012

Test Plan: Verified nothing uses this and relying on CI for confirmation.

Reviewed By: dreiss

Differential Revision: D35674694

fbshipit-source-id: c1d602aa4d85642594160a33606093c33817988f
@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2022

Hey @dagitses.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@facebook-github-bot facebook-github-bot deleted the gh/dagitses/323/head branch April 29, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dreiss dreiss dreiss approved these changes

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dagitses @facebook-github-bot @dreiss