Skip to content

introduce new --gen-dir flag to generate_code and use it in fbcode #75800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dagitses wants to merge 51 commits into from
Closed

introduce new --gen-dir flag to generate_code and use it in fbcode #75800

dagitses wants to merge 51 commits into from

Conversation

@dagitses
Copy link
Collaborator

@dagitses dagitses commented Apr 14, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: D35648586

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

stop using --install_dir in fbcode build codegen
8f67c1f 
This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 14, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit c85bbfa (more details on the Dr. CI page):

Expand to see more
  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-bionic-rocm5.1-py3.7 / test (default, 1, 2, linux.rocm.gpu) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-05-04T02:27:14.4469248Z RuntimeError: test_decomp failed! 
2022-05-04T02:27:10.1531160Z 
2022-05-04T02:27:10.1531429Z FAILED (errors=2, skipped=87, expected failures=6)
2022-05-04T02:27:10.1531745Z 
2022-05-04T02:27:10.1531925Z Generating XML reports...
2022-05-04T02:27:10.8171221Z Generated XML report: test-reports/python-unittest/test_decomp/TEST-TestDecompCUDA-20220504022319.xml
2022-05-04T02:27:14.4455754Z Traceback (most recent call last):
2022-05-04T02:27:14.4457221Z   File "test/run_test.py", line 1067, in <module>
2022-05-04T02:27:14.4462224Z     main()
2022-05-04T02:27:14.4463577Z   File "test/run_test.py", line 1045, in main
2022-05-04T02:27:14.4468153Z     raise RuntimeError(err_message)
2022-05-04T02:27:14.4469248Z RuntimeError: test_decomp failed!
2022-05-04T02:27:16.4222072Z 
2022-05-04T02:27:16.4222873Z real	7m53.467s
2022-05-04T02:27:16.4224441Z user	18m47.512s
2022-05-04T02:27:16.4225871Z sys	2m14.535s
2022-05-04T02:27:16.4226595Z + cleanup
2022-05-04T02:27:16.4227426Z + retcode=1
2022-05-04T02:27:16.4228285Z + set +x
2022-05-04T02:27:16.4355385Z ##[error]Process completed with exit code 1.
2022-05-04T02:27:16.4446593Z ##[group]Run # copy test results back to the mounted workspace, needed sudo, resulting permissions were correct
2022-05-04T02:27:16.4447261Z �[36;1m# copy test results back to the mounted workspace, needed sudo, resulting permissions were correct�[0m
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced Apr 14, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Update on "stop using --install_dir in fbcode build codegen"
d3477d0 
This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request Apr 15, 2022
Closed
Update on "stop using --install_dir in fbcode build codegen"
9ddfad9 
This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
This was referenced Apr 15, 2022
Closed
Closed
Michael Andreas Dagitses added 8 commits April 15, 2022 06:26
Update on "stop using --install_dir in fbcode build codegen"
962610e 
This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Update on "stop using --install_dir in fbcode build codegen"
54b0cf4 
This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Update on "stop using --install_dir in fbcode build codegen"
3fcdc12 
This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Update on "stop using --install_dir in fbcode build codegen"
238e54f 
This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Update on "stop using --install_dir in fbcode build codegen"
61b5407 
This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Update on "stop using --install_dir in fbcode build codegen"
1e893e1 
This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Update on "stop using --install_dir in fbcode build codegen"
0e7499b 
This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Update on "stop using --install_dir in fbcode build codegen"
b1609b3 
This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request Apr 16, 2022
Closed
Michael Andreas Dagitses added 5 commits April 16, 2022 14:04
Update on "stop using --install_dir in fbcode build codegen"
9d3f92e 
This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Update on "stop using --install_dir in fbcode build codegen"
c14b37c 
This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Update on "stop using --install_dir in fbcode build codegen"
ff0ad14 
This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Update on "stop using --install_dir in fbcode build codegen"
237e8c1 
This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Update on "stop using --install_dir in fbcode build codegen"
2735772 
This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Michael Andreas Dagitses added 3 commits April 21, 2022 09:37
Update on "introduce new --gen-dir flag to generate_code and use it i…
bcb1e56 
…n fbcode"

This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Update on "introduce new --gen-dir flag to generate_code and use it i…
643fec7 
…n fbcode"

This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Update on "introduce new --gen-dir flag to generate_code and use it i…
978ae04 
…n fbcode"

This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request Apr 21, 2022
Closed
Michael Andreas Dagitses added 2 commits April 22, 2022 10:00
Update on "introduce new --gen-dir flag to generate_code and use it i…
870181f 
…n fbcode"

This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Update on "introduce new --gen-dir flag to generate_code and use it i…
febc15a 
…n fbcode"

This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Michael Andreas Dagitses added 4 commits April 24, 2022 19:25
Update on "introduce new --gen-dir flag to generate_code and use it i…
b5a9203 
…n fbcode"

This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Update on "introduce new --gen-dir flag to generate_code and use it i…
fe1a735 
…n fbcode"

This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Update on "introduce new --gen-dir flag to generate_code and use it i…
75ed4f1 
…n fbcode"

This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Update on "introduce new --gen-dir flag to generate_code and use it i…
7380bef 
…n fbcode"

This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request Apr 26, 2022
Closed
Update on "introduce new --gen-dir flag to generate_code and use it i…
2c22646 
…n fbcode"

This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
This was referenced Apr 27, 2022
Closed
Closed
Michael Andreas Dagitses added 10 commits April 30, 2022 03:04
Update on "introduce new --gen-dir flag to generate_code and use it i…
541e8a0 
…n fbcode"

This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Update on "introduce new --gen-dir flag to generate_code and use it i…
a011a38 
…n fbcode"

This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Update on "introduce new --gen-dir flag to generate_code and use it i…
e38d584 
…n fbcode"

This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Update on "introduce new --gen-dir flag to generate_code and use it i…
75d7296 
…n fbcode"

This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Update on "introduce new --gen-dir flag to generate_code and use it i…
1fa1b45 
…n fbcode"

This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Update on "introduce new --gen-dir flag to generate_code and use it i…
bfb1119 
…n fbcode"

This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Update on "introduce new --gen-dir flag to generate_code and use it i…
fb825d9 
…n fbcode"

This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Update on "introduce new --gen-dir flag to generate_code and use it i…
98169e4 
…n fbcode"

This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Update on "introduce new --gen-dir flag to generate_code and use it i…
838191d 
…n fbcode"

This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
Update on "introduce new --gen-dir flag to generate_code and use it i…
c85bbfa 
…n fbcode"

This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.

Differential Revision: [D35648586](https://our.internmc.facebook.com/intern/diff/D35648586/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35648586/)!

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request May 4, 2022
@facebook-github-bot
introduce new --gen-dir flag to generate_code and use it in fbcode (#…
7f2acff 
…75800)

Summary:
Pull Request resolved: #75800

This leads to more similarities between OSS CMake and eventually OSS
Bazel. We will be able to generate files with the same names and not
have different file lists between the builds.
ghstack-source-id: 155300043

Test Plan: Verified locally and in CI.

Reviewed By: dreiss

Differential Revision: D35648586

fbshipit-source-id: 9f1638b5665ebcc64466883f65ef24a2bfd05228
@facebook-github-bot facebook-github-bot deleted the gh/dagitses/320/head branch May 8, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dreiss dreiss dreiss approved these changes

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dagitses @facebook-github-bot @dreiss