Skip to content

switch Bazel to the shared generate-code genrule #75790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dagitses wants to merge 52 commits into from
Closed

switch Bazel to the shared generate-code genrule #75790

dagitses wants to merge 52 commits into from

Conversation

@dagitses
Copy link
Collaborator

@dagitses dagitses commented Apr 14, 2022 •
edited
Loading

switch Bazel to the shared generate-code genrule
1f2b63c 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 14, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 08b98ca (more details on the Dr. CI page):

Expand to see more
  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-bionic-rocm5.1-py3.7 / test (default, 1, 2, linux.rocm.gpu) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-05-04T02:27:24.0863552Z RuntimeError: test_decomp failed! 
2022-05-04T02:27:19.7115762Z 
2022-05-04T02:27:19.7116322Z FAILED (errors=2, skipped=87, expected failures=6)
2022-05-04T02:27:19.7117006Z 
2022-05-04T02:27:19.7117458Z Generating XML reports...
2022-05-04T02:27:20.3804071Z Generated XML report: test-reports/python-unittest/test_decomp/TEST-TestDecompCUDA-20220504022325.xml
2022-05-04T02:27:24.0850859Z Traceback (most recent call last):
2022-05-04T02:27:24.0852114Z   File "test/run_test.py", line 1067, in <module>
2022-05-04T02:27:24.0855464Z     main()
2022-05-04T02:27:24.0856643Z   File "test/run_test.py", line 1045, in main
2022-05-04T02:27:24.0862225Z     raise RuntimeError(err_message)
2022-05-04T02:27:24.0863552Z RuntimeError: test_decomp failed!
2022-05-04T02:27:26.1383379Z 
2022-05-04T02:27:26.1384234Z real	7m59.720s
2022-05-04T02:27:26.1386628Z user	18m56.052s
2022-05-04T02:27:26.1387651Z sys	2m17.968s
2022-05-04T02:27:26.1388524Z + cleanup
2022-05-04T02:27:26.1389187Z + retcode=1
2022-05-04T02:27:26.1390258Z + set +x
2022-05-04T02:27:26.1490010Z ##[error]Process completed with exit code 1.
2022-05-04T02:27:26.1580212Z ##[group]Run # copy test results back to the mounted workspace, needed sudo, resulting permissions were correct
2022-05-04T02:27:26.1581431Z �[36;1m# copy test results back to the mounted workspace, needed sudo, resulting permissions were correct�[0m
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced Apr 14, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
dagitses pushed a commit that referenced this pull request Apr 14, 2022
switch Bazel to the shared generate-code genrule
73446a8 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

ghstack-source-id: 153891038
Pull Request resolved: #75790
Update on "switch Bazel to the shared generate-code genrule"
d0077cc 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request Apr 14, 2022
Closed
dagitses pushed a commit that referenced this pull request Apr 14, 2022
switch Bazel to the shared generate-code genrule
4b21268 
Pull Request resolved: #75790

We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.
ghstack-source-id: 153891038

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)
Update on "switch Bazel to the shared generate-code genrule"
21a9671 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request Apr 15, 2022
Closed
Update on "switch Bazel to the shared generate-code genrule"
bfa8049 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
This was referenced Apr 15, 2022
Closed
Closed
Update on "switch Bazel to the shared generate-code genrule"
ad6ee25 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
Update on "switch Bazel to the shared generate-code genrule"
d0a4831 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
dagitses pushed a commit that referenced this pull request Apr 15, 2022
switch Bazel to the shared generate-code genrule
1a80e27 
Pull Request resolved: #75790

We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.
ghstack-source-id: 153891038

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35645390/)!
Update on "switch Bazel to the shared generate-code genrule"
c24117f 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
Update on "switch Bazel to the shared generate-code genrule"
96d6eef 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
dagitses pushed a commit that referenced this pull request Apr 15, 2022
switch Bazel to the shared generate-code genrule
ffd7134 
Pull Request resolved: #75790

We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.
ghstack-source-id: 153993516

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35645390/)!
Update on "switch Bazel to the shared generate-code genrule"
226e2e1 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
Michael Andreas Dagitses added 2 commits April 21, 2022 09:48
Update on "switch Bazel to the shared generate-code genrule"
ef548e5 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
Update on "switch Bazel to the shared generate-code genrule"
07af0e6 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request Apr 21, 2022
Closed
Michael Andreas Dagitses added 6 commits April 22, 2022 10:00
Update on "switch Bazel to the shared generate-code genrule"
da0d6f8 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
Update on "switch Bazel to the shared generate-code genrule"
802867f 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
Update on "switch Bazel to the shared generate-code genrule"
f27db80 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
Update on "switch Bazel to the shared generate-code genrule"
78f073f 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
Update on "switch Bazel to the shared generate-code genrule"
827f11f 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
Update on "switch Bazel to the shared generate-code genrule"
4d641cd 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request Apr 26, 2022
Closed
Update on "switch Bazel to the shared generate-code genrule"
6f12ba1 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
This was referenced Apr 27, 2022
Closed
Closed
Michael Andreas Dagitses added 10 commits April 30, 2022 03:04
Update on "switch Bazel to the shared generate-code genrule"
b5e1c4b 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
Update on "switch Bazel to the shared generate-code genrule"
618a706 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
Update on "switch Bazel to the shared generate-code genrule"
9018df9 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
Update on "switch Bazel to the shared generate-code genrule"
ebd5e31 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
Update on "switch Bazel to the shared generate-code genrule"
6e24065 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
Update on "switch Bazel to the shared generate-code genrule"
80d64b4 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
Update on "switch Bazel to the shared generate-code genrule"
dbec737 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
Update on "switch Bazel to the shared generate-code genrule"
b05d129 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
Update on "switch Bazel to the shared generate-code genrule"
ae27cd6 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
Update on "switch Bazel to the shared generate-code genrule"
08b98ca 
We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.

Differential Revision: [D35645390](https://our.internmc.facebook.com/intern/diff/D35645390/)

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request May 4, 2022
@facebook-github-bot
switch Bazel to the shared generate-code genrule (#75790)
2822d4c 
Summary:
Pull Request resolved: #75790

We were building it before, but now we use it in downstream
rules. This enables us to eliminate the handwritten genrule.
ghstack-source-id: 155300051

Test Plan: Verified locally and in CI.

Reviewed By: dreiss

Differential Revision: D35645390

fbshipit-source-id: 478bb37a6ec295c232f66383babf46606e83ed5e
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022

Hey @dagitses.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@facebook-github-bot facebook-github-bot deleted the gh/dagitses/319/head branch May 8, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dreiss dreiss dreiss approved these changes

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dagitses @facebook-github-bot @dreiss