Skip to content

move generate-code into shared build structure #75699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dagitses wants to merge 62 commits into from
Closed

move generate-code into shared build structure #75699

dagitses wants to merge 62 commits into from

Conversation

@dagitses
Copy link
Collaborator

@dagitses dagitses commented Apr 12, 2022 •
edited
Loading

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 12, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 3a4fe57 (more details on the Dr. CI page):

Expand to see more
  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-bionic-rocm5.1-py3.7 / test (default, 2, 2, linux.rocm.gpu) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-05-03T08:31:22.7089094Z FAIL [0.012s]: test_caching_pinned_memory (__main__.TestCuda) 
2022-05-03T08:31:22.7022087Z   test_scatter_cpu_dim (__main__.TestCudaComm) ... skip: only one GPU detected (0.000s)
2022-05-03T08:31:22.7026921Z   test_scatter_cpu_neg_dim (__main__.TestCudaComm) ... skip: only one GPU detected (0.000s)
2022-05-03T08:31:22.7032020Z   test_scatter_cpu_sizes (__main__.TestCudaComm) ... skip: only one GPU detected (0.000s)
2022-05-03T08:31:22.7038290Z   test_scatter_gpu (__main__.TestCudaComm) ... skip: only one GPU detected (0.001s)
2022-05-03T08:31:22.7043957Z   test_scatter_gpu_dim (__main__.TestCudaComm) ... skip: only one GPU detected (0.000s)
2022-05-03T08:31:22.7049599Z   test_scatter_gpu_neg_dim (__main__.TestCudaComm) ... skip: only one GPU detected (0.000s)
2022-05-03T08:31:22.7055467Z   test_scatter_gpu_sizes (__main__.TestCudaComm) ... skip: only one GPU detected (0.001s)
2022-05-03T08:31:22.7087506Z   test_scatter_namedtuple (__main__.TestCudaComm) ... skip: Test needs multiple GPUs (0.003s)
2022-05-03T08:31:22.7088061Z 
2022-05-03T08:31:22.7088317Z ======================================================================
2022-05-03T08:31:22.7089094Z FAIL [0.012s]: test_caching_pinned_memory (__main__.TestCuda)
2022-05-03T08:31:22.7090375Z ----------------------------------------------------------------------
2022-05-03T08:31:22.7091339Z Traceback (most recent call last):
2022-05-03T08:31:22.7092897Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 1800, in wrapper
2022-05-03T08:31:22.7093685Z     method(*args, **kwargs)
2022-05-03T08:31:22.7094367Z   File "test_cuda.py", line 1370, in test_caching_pinned_memory
2022-05-03T08:31:22.7095404Z     self.assertNotEqual(t.data_ptr(), ptr, msg='allocation re-used too soon')
2022-05-03T08:31:22.7096681Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 2223, in assertNotEqual
2022-05-03T08:31:22.7097736Z     self.assertEqual(x, y, msg, atol=atol, rtol=rtol, **kwargs)
2022-05-03T08:31:22.7098796Z AssertionError: AssertionError not raised : allocation re-used too soon
2022-05-03T08:31:22.7099308Z
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced Apr 12, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
dagitses pushed a commit that referenced this pull request Apr 12, 2022
move generate-code into shared build structure
4f6e179 
Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)!

ghstack-source-id: 153688970
Pull Request resolved: #75699
dagitses pushed a commit that referenced this pull request Apr 13, 2022
move generate-code into shared build structure
29ea94c 
Pull Request resolved: #75699


ghstack-source-id: 153688970

Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)!
dagitses pushed a commit that referenced this pull request Apr 13, 2022
move generate-code into shared build structure
68aef62 
Pull Request resolved: #75699


ghstack-source-id: 153688970

Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)!
dagitses pushed a commit that referenced this pull request Apr 13, 2022
move generate-code into shared build structure
8384716 
Pull Request resolved: #75699


ghstack-source-id: 153688970

Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)!
@dagitses dagitses mentioned this pull request Apr 21, 2022
Closed
Michael Andreas Dagitses added 3 commits April 21, 2022 09:37
Update on "move generate-code into shared build structure"
c6d3418 
Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)!

[ghstack-poisoned]
Update on "move generate-code into shared build structure"
8e457d6 
Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)!

[ghstack-poisoned]
Update on "move generate-code into shared build structure"
009a655 
Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)!

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request Apr 21, 2022
Closed
Michael Andreas Dagitses added 6 commits April 22, 2022 10:00
Update on "move generate-code into shared build structure"
c1f547e 
Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)!

[ghstack-poisoned]
Update on "move generate-code into shared build structure"
a8e11f2 
Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)!

[ghstack-poisoned]
Update on "move generate-code into shared build structure"
ba3b216 
Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)!

[ghstack-poisoned]
Update on "move generate-code into shared build structure"
5f4f2dd 
Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)!

[ghstack-poisoned]
Update on "move generate-code into shared build structure"
c52b580 
Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)!

[ghstack-poisoned]
Update on "move generate-code into shared build structure"
b584b28 
Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)!

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request Apr 26, 2022
Closed
This was referenced Apr 27, 2022
Closed
Closed
Michael Andreas Dagitses added 8 commits April 29, 2022 04:15
Update on "move generate-code into shared build structure"
c3c91ff 
Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)!

[ghstack-poisoned]
Update on "move generate-code into shared build structure"
4b8c92f 
Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)!

[ghstack-poisoned]
Update on "move generate-code into shared build structure"
d08f05b 
Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)!

[ghstack-poisoned]
Update on "move generate-code into shared build structure"
b75b9bc 
Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)!

[ghstack-poisoned]
Update on "move generate-code into shared build structure"
fda16a2 
Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)!

[ghstack-poisoned]
Update on "move generate-code into shared build structure"
ffd3f22 
Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)!

[ghstack-poisoned]
Update on "move generate-code into shared build structure"
e933ac8 
Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)!

[ghstack-poisoned]
Update on "move generate-code into shared build structure"
3a4fe57 
Differential Revision: [D35587412](https://our.internmc.facebook.com/intern/diff/D35587412/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587412/)!

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request May 3, 2022
@facebook-github-bot
move generate-code into shared build structure (#75699)
4896b72 
Summary:
Pull Request resolved: #75699

ghstack-source-id: 155255334

Test Plan: Rely on CI.

Reviewed By: dreiss

Differential Revision: D35587412

fbshipit-source-id: 5ab79c07029de279a1fae36519654a73bb61d430
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2022

Hey @dagitses.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@facebook-github-bot facebook-github-bot deleted the gh/dagitses/318/head branch May 6, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dreiss dreiss dreiss approved these changes

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dagitses @facebook-github-bot @dreiss