move GENERATED_CPP to the only place it is used #75698

dagitses · 2022-04-12T20:30:25Z

Stack from ghstack (oldest at bottom):

Note that there is a distinct GENERATED_CPP list in a different bzl
file.

Differential Revision: D35587411

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

Note that there is a distinct GENERATED_CPP list in a different bzl file. Differential Revision: [D35587411](https://our.internmc.facebook.com/intern/diff/D35587411/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587411/)! [ghstack-poisoned]

facebook-github-bot · 2022-04-12T20:30:31Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/75698
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours
↩️ [fb-only] Re-run with SSH instructions

💊 CI failures summary and remediations

As of commit f97a9db (more details on the Dr. CI page):

Expand to see more

2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages

pull / pytorch-xla-linux-bionic-py3.7-clang8 / test (xla, 1, 1, linux.2xlarge) (1/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-04-22T17:29:47.7220869Z /var/lib/jenkins/w... virtual member functions can be marked 'override'

2022-04-22T17:29:47.5191355Z 2 errors generated.
2022-04-22T17:29:47.7211297Z [6/179] clang++-8 -MMD -MF /var/lib/jenkins/workspace/xla/build/temp.linux-x86_64-3.7/torch_xla/csrc/aten_xla_type.o.d -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -D_GLIBCXX_USE_CXX11_ABI=1 -fPIC -I/var/lib/jenkins/workspace/xla -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-bin -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/protobuf_archive/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_protobuf/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/eigen_archive -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_absl -I/var/lib/jenkins/workspace -I/var/lib/jenkins/workspace/torch/csrc -I/var/lib/jenkins/workspace/torch/lib/tmp_install/include -I/opt/conda/lib/python3.7/site-packages/torch/include -I/opt/conda/lib/python3.7/site-packages/torch/include/torch/csrc/api/include -I/opt/conda/lib/python3.7/site-packages/torch/include/TH -I/opt/conda/lib/python3.7/site-packages/torch/include/THC -I/opt/conda/include/python3.7m -c -c /var/lib/jenkins/workspace/xla/torch_xla/csrc/aten_xla_type.cpp -o /var/lib/jenkins/workspace/xla/build/temp.linux-x86_64-3.7/torch_xla/csrc/aten_xla_type.o -std=c++14 -Wno-sign-compare -Wno-deprecated-declarations -Wno-return-type -Wno-macro-redefined -Wno-return-std-move -DNDEBUG -DTORCH_API_INCLUDE_EXTENSION_H '-DPYBIND11_COMPILER_TYPE="_clang"' '-DPYBIND11_STDLIB="_libstdcpp"' '-DPYBIND11_BUILD_ABI="_cxxabi1002"' -DTORCH_EXTENSION_NAME=_XLAC -D_GLIBCXX_USE_CXX11_ABI=1
2022-04-22T17:29:47.7213479Z �[31mFAILED: �[0m/var/lib/jenkins/workspace/xla/build/temp.linux-x86_64-3.7/torch_xla/csrc/aten_xla_type.o 
2022-04-22T17:29:47.7216728Z clang++-8 -MMD -MF /var/lib/jenkins/workspace/xla/build/temp.linux-x86_64-3.7/torch_xla/csrc/aten_xla_type.o.d -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -D_GLIBCXX_USE_CXX11_ABI=1 -fPIC -I/var/lib/jenkins/workspace/xla -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-bin -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/protobuf_archive/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_protobuf/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/eigen_archive -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_absl -I/var/lib/jenkins/workspace -I/var/lib/jenkins/workspace/torch/csrc -I/var/lib/jenkins/workspace/torch/lib/tmp_install/include -I/opt/conda/lib/python3.7/site-packages/torch/include -I/opt/conda/lib/python3.7/site-packages/torch/include/torch/csrc/api/include -I/opt/conda/lib/python3.7/site-packages/torch/include/TH -I/opt/conda/lib/python3.7/site-packages/torch/include/THC -I/opt/conda/include/python3.7m -c -c /var/lib/jenkins/workspace/xla/torch_xla/csrc/aten_xla_type.cpp -o /var/lib/jenkins/workspace/xla/build/temp.linux-x86_64-3.7/torch_xla/csrc/aten_xla_type.o -std=c++14 -Wno-sign-compare -Wno-deprecated-declarations -Wno-return-type -Wno-macro-redefined -Wno-return-std-move -DNDEBUG -DTORCH_API_INCLUDE_EXTENSION_H '-DPYBIND11_COMPILER_TYPE="_clang"' '-DPYBIND11_STDLIB="_libstdcpp"' '-DPYBIND11_BUILD_ABI="_cxxabi1002"' -DTORCH_EXTENSION_NAME=_XLAC -D_GLIBCXX_USE_CXX11_ABI=1
2022-04-22T17:29:47.7218831Z In file included from /var/lib/jenkins/workspace/xla/torch_xla/csrc/aten_xla_type.cpp:18:
2022-04-22T17:29:47.7219151Z In file included from /var/lib/jenkins/workspace/xla/torch_xla/csrc/aten_xla_bridge.h:11:
2022-04-22T17:29:47.7219479Z In file included from /var/lib/jenkins/workspace/xla/torch_xla/csrc/tensor.h:21:
2022-04-22T17:29:47.7219929Z /var/lib/jenkins/workspace/xla/torch_xla/csrc/ir.h:130:36: error: only virtual member functions can be marked 'override'
2022-04-22T17:29:47.7220275Z   torch::lazy::hash_t hash() const override { return dag_hash_; }
2022-04-22T17:29:47.7220491Z                                    ^~~~~~~~~
2022-04-22T17:29:47.7220869Z /var/lib/jenkins/workspace/xla/torch_xla/csrc/ir.h:132:41: error: only virtual member functions can be marked 'override'
2022-04-22T17:29:47.7221200Z   torch::lazy::hash_t shapeHash() const override { return dag_hash_; }
2022-04-22T17:29:47.7221429Z                                         ^~~~~~~~~
2022-04-22T17:29:47.7221613Z 2 errors generated.
2022-04-22T17:29:47.7221820Z ninja: build stopped: subcommand failed.
2022-04-22T17:29:47.7260226Z Traceback (most recent call last):
2022-04-22T17:29:47.7260694Z   File "/opt/conda/lib/python3.7/site-packages/torch/utils/cpp_extension.py", line 1801, in _run_ninja_build
2022-04-22T17:29:47.7273421Z     env=env)
2022-04-22T17:29:47.7273715Z   File "/opt/conda/lib/python3.7/subprocess.py", line 512, in run
2022-04-22T17:29:47.7275540Z     output=stdout, stderr=stderr)
2022-04-22T17:29:47.7276254Z subprocess.CalledProcessError: Command '['ninja', '-v', '-j', '6']' returned non-zero exit status 1.

pull / win-vs2019-cuda11.3-py3 / test (default, 1, 2, windows.8xlarge.nvidia.gpu) (2/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-04-22T19:23:16.0763798Z FAIL [0.016s]: tes...transpose3d_cuda_float32 (__main__.TestCommonCUDA)

2022-04-22T19:23:15.9805486Z   test_neg_view_view_as_cuda_float64 (__main__.TestMathBitsCUDA) ... ok (0.016s)
2022-04-22T19:23:15.9989119Z   test_neg_view_view_cuda_float64 (__main__.TestMathBitsCUDA) ... ok (0.016s)
2022-04-22T19:23:16.0038507Z   test_neg_view_vsplit_cuda_float64 (__main__.TestMathBitsCUDA) ... ok (0.000s)
2022-04-22T19:23:16.0084366Z   test_neg_view_vstack_cuda_float64 (__main__.TestMathBitsCUDA) ... ok (0.016s)
2022-04-22T19:23:16.0252618Z   test_neg_view_where_cuda_float64 (__main__.TestMathBitsCUDA) ... ok (0.016s)
2022-04-22T19:23:16.0593646Z   test_neg_view_xlogy_cuda_float64 (__main__.TestMathBitsCUDA) ... ok (0.038s)
2022-04-22T19:23:16.0698046Z   test_neg_view_zero__cuda_float64 (__main__.TestMathBitsCUDA) ... ok (0.000s)
2022-04-22T19:23:16.0760365Z   test_neg_view_zeros_like_cuda_float64 (__main__.TestMathBitsCUDA) ... ok (0.016s)
2022-04-22T19:23:16.0762634Z 
2022-04-22T19:23:16.0763218Z ======================================================================
2022-04-22T19:23:16.0763798Z FAIL [0.016s]: test_variant_consistency_eager_nn_functional_conv_transpose3d_cuda_float32 (__main__.TestCommonCUDA)
2022-04-22T19:23:16.0764380Z ----------------------------------------------------------------------
2022-04-22T19:23:16.0764805Z Traceback (most recent call last):
2022-04-22T19:23:16.0774496Z   File "C:\actions-runner\_work\pytorch\pytorch\build\win_tmp\build\torch\testing\_internal\common_device_type.py", line 376, in instantiated_test
2022-04-22T19:23:16.0775216Z     result = test(self, **param_kwargs)
2022-04-22T19:23:16.0775877Z   File "C:\actions-runner\_work\pytorch\pytorch\build\win_tmp\build\torch\testing\_internal\common_device_type.py", line 773, in test_wrapper
2022-04-22T19:23:16.0776383Z     return test(*args, **kwargs)
2022-04-22T19:23:16.0776834Z   File "test_ops.py", line 675, in test_variant_consistency_eager
2022-04-22T19:23:16.0777276Z     _test_consistency_helper(samples, variants)
2022-04-22T19:23:16.0777757Z   File "test_ops.py", line 667, in _test_consistency_helper
2022-04-22T19:23:16.0778189Z     self.assertEqual(expected_forward, variant_forward)

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Note that there is a distinct GENERATED_CPP list in a different bzl file. Differential Revision: [D35587411](https://our.internmc.facebook.com/intern/diff/D35587411/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587411/)! [ghstack-poisoned]

malfet

Hmm, if we can't get rid of it yet, we should keep it in build variables

Note that there is a distinct GENERATED_CPP list in a different bzl file. Differential Revision: [D35587411](https://our.internmc.facebook.com/intern/diff/D35587411/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35587411/)! [ghstack-poisoned]

facebook-github-bot added the cla signed label Apr 12, 2022

Michael Andreas Dagitses added 12 commits April 12, 2022 17:05

dagitses mentioned this pull request Apr 14, 2022

switch Bazel to the shared generate-code genrule #75790

Closed

dagitses mentioned this pull request Apr 14, 2022

introduce new --gen-dir flag to generate_code and use it in fbcode #75800

Closed

dagitses mentioned this pull request Apr 15, 2022

use pathlib.Path for --install_dir and downstream variables #75867

Closed

dagitses mentioned this pull request Apr 15, 2022

remove unused all_generator_source from generate_code #75868

Closed

Michael Andreas Dagitses added 4 commits April 17, 2022 16:31

dagitses mentioned this pull request Apr 18, 2022

move version_h to shared build structure in Buck #75964

Closed

Michael Andreas Dagitses added 4 commits April 18, 2022 06:52

This was referenced Apr 21, 2022

add support for filtering out Bazel targets from common structure #76173

Closed

disable the //:generate-code target in Bazel #76174

Closed

Michael Andreas Dagitses added 6 commits April 21, 2022 07:22

dagitses mentioned this pull request Apr 21, 2022

eliminate Bazel's libtorch_python_generated_sources #76178

Closed

Michael Andreas Dagitses added 2 commits April 21, 2022 09:11

dagitses mentioned this pull request Apr 21, 2022

eliminate Bazel's libtorch_cpp_generated_sources #76179

Closed

Michael Andreas Dagitses added 3 commits April 21, 2022 09:37

dagitses mentioned this pull request Apr 21, 2022

move generated-autograd-headers to the shared build structure #76183

Closed

malfet requested changes Apr 21, 2022

View reviewed changes

dreiss approved these changes Apr 22, 2022

View reviewed changes

dagitses closed this Apr 25, 2022

dagitses deleted the gh/dagitses/317/head branch April 25, 2022 15:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

move GENERATED_CPP to the only place it is used #75698

move GENERATED_CPP to the only place it is used #75698

Uh oh!

dagitses commented Apr 12, 2022 •

edited

Loading

Uh oh!

facebook-github-bot commented Apr 12, 2022 •

edited

Loading

🕵️ 2 new failures recognized by patterns

pull / pytorch-xla-linux-bionic-py3.7-clang8 / test (xla, 1, 1, linux.2xlarge) (1/2)

pull / win-vs2019-cuda11.3-py3 / test (default, 1, 2, windows.8xlarge.nvidia.gpu) (2/2)

Uh oh!

malfet left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

move GENERATED_CPP to the only place it is used #75698

move GENERATED_CPP to the only place it is used #75698

Uh oh!

Conversation

dagitses commented Apr 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Apr 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

🕵️ 2 new failures recognized by patterns

pull / pytorch-xla-linux-bionic-py3.7-clang8 / test (xla, 1, 1, linux.2xlarge) (1/2)

pull / win-vs2019-cuda11.3-py3 / test (default, 1, 2, windows.8xlarge.nvidia.gpu) (2/2)

Uh oh!

malfet left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dagitses commented Apr 12, 2022 •

edited

Loading

facebook-github-bot commented Apr 12, 2022 •

edited

Loading