Remove breakpad dependency by malfet · Pull Request #75394 · pytorch/pytorch

malfet · 2022-04-07T00:25:57Z

This functionality does not seem to be used
and there are some requests to update dependency.

Add third_party to torch_cpu include directories if compiling with
Caffe2 support, as caffe2/quantization/server/conv_dnnlowp_op.cc depends on third_party/fbgemm/src/RefImplementations.h

facebook-github-bot · 2022-04-07T00:26:02Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/75394
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours

💊 CI failures summary and remediations

As of commit 04960a6 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

janeyx99 · 2022-04-08T14:37:05Z

oh hm this seems to be backwards incompatible for workflows (cuz the checkout will try to checkout breakpad)

janeyx99 · 2022-04-13T13:17:22Z

lint errors seem legit

janeyx99

How have you confirmed this functionality isn't used?

malfet · 2022-04-15T20:01:54Z

How have you confirmed this functionality isn't used?

Functionality were never exposed via a stable API and not a single issue report with a crash contained minidump

janeyx99

fix lint before landing tho :p

malfet · 2022-04-15T22:56:56Z

fix lint before landing tho :p

[Edit] Looks like Michael fixed deleted files issue, everything works now!

facebook-github-bot · 2022-04-15T23:12:56Z

@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

malfet · 2022-04-17T17:42:33Z

@pytorchbot merge this

github-actions · 2022-04-17T17:44:20Z

Hey @malfet.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

malfet · 2022-04-17T17:57:30Z

@pytorchbot revert this as it somehow breaks ONNX builds, see https://github.com/pytorch/pytorch/runs/6055329111?check_suite_focus=true

This reverts commit 9aa3c7f. Reverted #75394 on behalf of https://github.com/malfet

This functionality does not seem to be used and there are some requests to update dependency Pull Request resolved: #75394 Approved by: https://github.com/janeyx99, https://github.com/seemethere (cherry picked from commit 9aa3c7f)

This reverts commit 9aa3c7f. Reverted #75394 on behalf of https://github.com/malfet (cherry picked from commit d79d9fa)

This functionality does not seem to be used and there are some requests to update dependency Add `third_party` to torch_cpu include directories if compiling with Caffe2 support, as `caffe2/quantization/server/conv_dnnlowp_op.cc` depends on `third_party/fbgemm/src/RefImplementations.h`

malfet · 2022-05-03T20:20:26Z

@pytorchbot merge this

github-actions · 2022-05-03T20:22:35Z

Hey @malfet.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Summary: This functionality does not seem to be used and there are some requests to update dependency. Add `third_party` to torch_cpu include directories if compiling with Caffe2 support, as `caffe2/quantization/server/conv_dnnlowp_op.cc` depends on `third_party/fbgemm/src/RefImplementations.h` Pull Request resolved: #75394 Approved by: https://github.com/janeyx99, https://github.com/seemethere Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/8473173c36a171c9ad896804ab36049f80a99073 Reviewed By: cpuhrsch Differential Revision: D35693323 Pulled By: malfet fbshipit-source-id: f50054381becb84754d8e396ab270af69993b250

acxz · 2022-06-12T12:13:44Z

@malfet can you confirm that this PR closes #70298? and if so can you close #70298?

malfet requested a review from a team as a code owner April 7, 2022 00:25

facebook-github-bot added the cla signed label Apr 7, 2022

malfet mentioned this pull request Apr 13, 2022

third_party/breakpad: update, fixes build on linux/gcc #70298

Closed

malfet force-pushed the malfet/remove-breakpad branch from b8298a6 to 7185c83 Compare April 13, 2022 00:13

janeyx99 reviewed Apr 13, 2022

View reviewed changes

malfet force-pushed the malfet/remove-breakpad branch from 7185c83 to 3562cc7 Compare April 15, 2022 02:30

malfet added the with-ssh label Apr 15, 2022

malfet force-pushed the malfet/remove-breakpad branch 2 times, most recently from ca7fffe to 197cc71 Compare April 15, 2022 03:12

janeyx99 reviewed Apr 15, 2022

View reviewed changes

janeyx99 approved these changes Apr 15, 2022

View reviewed changes

seemethere approved these changes Apr 15, 2022

View reviewed changes

malfet force-pushed the malfet/remove-breakpad branch from 197cc71 to d5514c0 Compare April 15, 2022 22:54

malfet force-pushed the malfet/remove-breakpad branch from d5514c0 to 474af22 Compare April 15, 2022 23:02

pytorchmergebot closed this in 9aa3c7f Apr 17, 2022

pytorchmergebot added the Reverted label Apr 17, 2022

pytorchmergebot added a commit that referenced this pull request Apr 17, 2022

Revert "Remove breakpad dependency"

d79d9fa

This reverts commit 9aa3c7f. Reverted #75394 on behalf of https://github.com/malfet

malfet reopened this Apr 17, 2022

malfet force-pushed the malfet/remove-breakpad branch from 474af22 to 6cf8f2b Compare May 3, 2022 01:19

malfet force-pushed the malfet/remove-breakpad branch from 6cf8f2b to f9ba3b8 Compare May 3, 2022 17:56

malfet force-pushed the malfet/remove-breakpad branch from f9ba3b8 to 04960a6 Compare May 3, 2022 18:32

pytorchmergebot closed this in 8473173 May 3, 2022

malfet added the topic: not user facing topic category label May 4, 2022

malfet deleted the malfet/remove-breakpad branch May 4, 2022 01:24

This was referenced Jun 12, 2022

PyTorch fails to compile on gcc 11.2 due to breakpad #73113

Open

fails to build with: no matching function for call to max(int, long int) #70297

Closed

Sinan81 mentioned this pull request Oct 19, 2023

Installation issue: py-torch +breakpad fails to build on [email protected] spack/spack#40629

Closed

4 tasks

Conversation

malfet commented Apr 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Apr 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

Uh oh!

janeyx99 commented Apr 8, 2022

Uh oh!

janeyx99 commented Apr 13, 2022

Uh oh!

janeyx99 left a comment

Choose a reason for hiding this comment

Uh oh!

malfet commented Apr 15, 2022

Uh oh!

janeyx99 left a comment

Choose a reason for hiding this comment

Uh oh!

malfet commented Apr 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Apr 15, 2022

Uh oh!

malfet commented Apr 17, 2022

Uh oh!

github-actions bot commented Apr 17, 2022

Uh oh!

malfet commented Apr 17, 2022

Uh oh!

malfet commented May 3, 2022

Uh oh!

github-actions bot commented May 3, 2022

Uh oh!

acxz commented Jun 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

malfet commented Apr 7, 2022 •

edited

Loading

facebook-github-bot commented Apr 7, 2022 •

edited

Loading

malfet commented Apr 15, 2022 •

edited

Loading