Skip to content

[PyTorch] Flip polarity of masked_softmax mask #75039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
swolchok wants to merge 2 commits into from
Closed

[PyTorch] Flip polarity of masked_softmax mask #75039

swolchok wants to merge 2 commits into from

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented Mar 31, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

It didn't match torch.nn.MultiheadAttention. Now it does.

Differential Revision: D34929186

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

@swolchok
[PyTorch] Flip polarity of masked_softmax mask
93a036f 
It didn't match torch.nn.MultiheadAttention. Now it does.

Differential Revision: [D34929186](https://our.internmc.facebook.com/intern/diff/D34929186/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34929186/)!

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 31, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 76b4fa9 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-bionic-rocm5.0-py3.7 / test (default, 2, 2, linux.rocm.gpu) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-04-01T18:33:14.3428165Z FAIL [0.023s]: tes...id_sampler_cuda (__main__.TestTorchDeviceTypeCUDA) 
2022-04-01T18:33:14.3206311Z   test_where_scalar_valid_combination_cuda_int32 (__main__.TestTorchDeviceTypeCUDA) ... ok (0.005s)
2022-04-01T18:33:14.3323444Z   test_where_scalar_valid_combination_cuda_int64 (__main__.TestTorchDeviceTypeCUDA) ... ok (0.012s)
2022-04-01T18:33:14.3369932Z   test_where_scalar_valid_combination_cuda_int8 (__main__.TestTorchDeviceTypeCUDA) ... ok (0.004s)
2022-04-01T18:33:14.3416802Z   test_where_scalar_valid_combination_cuda_uint8 (__main__.TestTorchDeviceTypeCUDA) ... ok (0.005s)
2022-04-01T18:33:14.3422858Z   test_cuda_vitals_gpu_only_cuda (__main__.TestVitalSignsCudaCUDA) ... [TORCH_VITAL] Dataloader.enabled		 True
2022-04-01T18:33:14.3424263Z [TORCH_VITAL] Dataloader.basic_unit_test		 TEST_VALUE_STRING
2022-04-01T18:33:14.3425343Z [TORCH_VITAL] CUDA.used		 true
2022-04-01T18:33:14.3426228Z ok (0.001s)
2022-04-01T18:33:14.3426721Z 
2022-04-01T18:33:14.3427064Z ======================================================================
2022-04-01T18:33:14.3428165Z FAIL [0.023s]: test_invalid_shapes_grid_sampler_cuda (__main__.TestTorchDeviceTypeCUDA)
2022-04-01T18:33:14.3429985Z ----------------------------------------------------------------------
2022-04-01T18:33:14.3444121Z RuntimeError: cudnn_grid_sampler_forward: ATen not compiled with cuDNN support
2022-04-01T18:33:14.3444869Z 
2022-04-01T18:33:14.3445387Z During handling of the above exception, another exception occurred:
2022-04-01T18:33:14.3446003Z 
2022-04-01T18:33:14.3446345Z Traceback (most recent call last):
2022-04-01T18:33:14.3448579Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 1780, in wrapper
2022-04-01T18:33:14.3449587Z     method(*args, **kwargs)
2022-04-01T18:33:14.3451182Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 376, in instantiated_test
2022-04-01T18:33:14.3452324Z     result = test(self, **param_kwargs)
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

swolchok added a commit that referenced this pull request Mar 31, 2022
@swolchok
[PyTorch] Flip polarity of masked_softmax mask
9c42cfb 
It didn't match torch.nn.MultiheadAttention. Now it does.

Differential Revision: [D34929186](https://our.internmc.facebook.com/intern/diff/D34929186/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34929186/)!

ghstack-source-id: 152738582
Pull Request resolved: #75039
@swolchok
Update on "[PyTorch] Flip polarity of masked_softmax mask"
76b4fa9 
It didn't match torch.nn.MultiheadAttention. Now it does.

Differential Revision: [D34929186](https://our.internmc.facebook.com/intern/diff/D34929186/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34929186/)!

[ghstack-poisoned]
swolchok added a commit that referenced this pull request Apr 1, 2022
@swolchok
[PyTorch] Flip polarity of masked_softmax mask
7958a10 
Pull Request resolved: #75039

It didn't match torch.nn.MultiheadAttention. Now it does.
ghstack-source-id: 152815449

Differential Revision: [D34929186](https://our.internmc.facebook.com/intern/diff/D34929186/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D34929186/)!
facebook-github-bot pushed a commit that referenced this pull request Apr 2, 2022
@swolchok @facebook-github-bot
[PyTorch] Flip polarity of masked_softmax mask (#78)
00eea72 
Summary:
X-link: pytorch/pytorch-canary#78

Pull Request resolved: #75039

It didn't match torch.nn.MultiheadAttention. Now it does.
ghstack-source-id: 152815449

Test Plan: updated tests

Reviewed By: zrphercule

Differential Revision: D34929186

fbshipit-source-id: 1eaee615bafd5a6f058f1faefa54f8f4aa01c92e
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2022

Hey @swolchok.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@facebook-github-bot facebook-github-bot deleted the gh/swolchok/477/head branch April 5, 2022 14:17
@swolchok swolchok added the topic: not user facing topic category label Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok @facebook-github-bot