Skip to content

move setup_helpers programs to shared build structure #74849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dagitses wants to merge 73 commits into from
Closed

move setup_helpers programs to shared build structure #74849

dagitses wants to merge 73 commits into from

Conversation

@dagitses
Copy link
Collaborator

@dagitses dagitses commented Mar 28, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

Differential Revision: D35191356

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 28, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 0bfff28 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced Mar 28, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
dagitses pushed a commit that referenced this pull request Mar 28, 2022
move setup_helpers programs to shared build structure
252e46d 
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!

ghstack-source-id: 152377144
Pull Request resolved: #74849
dagitses pushed a commit that referenced this pull request Mar 28, 2022
move setup_helpers programs to shared build structure
b9ad091 
Pull Request resolved: #74849


ghstack-source-id: 152377144

Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!
dagitses pushed a commit that referenced this pull request Mar 29, 2022
move setup_helpers programs to shared build structure
728c482 
Pull Request resolved: #74849


ghstack-source-id: 152377144

Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!
dagitses pushed a commit that referenced this pull request Mar 30, 2022
move setup_helpers programs to shared build structure
496e431 
Pull Request resolved: #74849


ghstack-source-id: 152377144

Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!
dagitses pushed a commit that referenced this pull request Mar 31, 2022
move setup_helpers programs to shared build structure
018af95 
Pull Request resolved: #74849


ghstack-source-id: 152377144

Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!
dagitses pushed a commit that referenced this pull request Mar 31, 2022
move setup_helpers programs to shared build structure
2416abf 
Pull Request resolved: #74849


ghstack-source-id: 152722869

Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!
Michael Andreas Dagitses added 3 commits April 16, 2022 11:30
Update on "move setup_helpers programs to shared build structure"
d57587c 
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!

[ghstack-poisoned]
Update on "move setup_helpers programs to shared build structure"
2e9e7f5 
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!

[ghstack-poisoned]
Update on "move setup_helpers programs to shared build structure"
aa1b227 
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request Apr 16, 2022
Closed
Michael Andreas Dagitses added 8 commits April 16, 2022 14:03
Update on "move setup_helpers programs to shared build structure"
8bae0f1 
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!

[ghstack-poisoned]
Update on "move setup_helpers programs to shared build structure"
391b4b8 
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!

[ghstack-poisoned]
Update on "move setup_helpers programs to shared build structure"
1eb5443 
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!

[ghstack-poisoned]
Update on "move setup_helpers programs to shared build structure"
62edf0a 
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!

[ghstack-poisoned]
Update on "move setup_helpers programs to shared build structure"
29f893a 
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!

[ghstack-poisoned]
Update on "move setup_helpers programs to shared build structure"
7c6c402 
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!

[ghstack-poisoned]
Update on "move setup_helpers programs to shared build structure"
29b7850 
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!

[ghstack-poisoned]
Update on "move setup_helpers programs to shared build structure"
7d2b3bb 
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request Apr 18, 2022
Closed
Michael Andreas Dagitses added 4 commits April 18, 2022 06:52
Update on "move setup_helpers programs to shared build structure"
b6dfdc2 
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!

[ghstack-poisoned]
Update on "move setup_helpers programs to shared build structure"
35d0168 
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!

[ghstack-poisoned]
Update on "move setup_helpers programs to shared build structure"
06867e3 
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!

[ghstack-poisoned]
Update on "move setup_helpers programs to shared build structure"
424f802 
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!

[ghstack-poisoned]
This was referenced Apr 21, 2022
Closed
Closed
Michael Andreas Dagitses added 3 commits April 21, 2022 07:22
Update on "move setup_helpers programs to shared build structure"
5bce9bf 
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!

[ghstack-poisoned]
Update on "move setup_helpers programs to shared build structure"
ed1bd6c 
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!

[ghstack-poisoned]
Update on "move setup_helpers programs to shared build structure"
0bfff28 
Differential Revision: [D35191356](https://our.internmc.facebook.com/intern/diff/D35191356/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35191356/)!

[ghstack-poisoned]
This was referenced Apr 21, 2022
Closed
Closed
Closed
facebook-github-bot pushed a commit that referenced this pull request Apr 22, 2022
@facebook-github-bot
move setup_helpers programs to shared build structure (#74849)
46ec2b1 
Summary:
Pull Request resolved: #74849

ghstack-source-id: 154189187

Test Plan: Rely on CI.

Reviewed By: malfet

Differential Revision: D35191356

fbshipit-source-id: 406b5e95a5704b4b62d846a259839bf61f3e4aba
@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2022

Hey @dagitses.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dagitses @facebook-github-bot @malfet