Skip to content

remove unused //:tools_jit target and dependency from generate-code #74837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dagitses wants to merge 65 commits into from
Closed

remove unused //:tools_jit target and dependency from generate-code #74837

dagitses wants to merge 65 commits into from

Conversation

@dagitses
Copy link
Collaborator

@dagitses dagitses commented Mar 28, 2022 •
edited
Loading

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 28, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 6ad07f5 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced Mar 28, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@dagitses dagitses mentioned this pull request Mar 28, 2022
Closed
Michael Andreas Dagitses added 13 commits March 28, 2022 12:16
Update on "remove unused //:tools_jit target and dependency from gene…
4555f3c 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
Update on "remove unused //:tools_jit target and dependency from gene…
7f051dd 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
Update on "remove unused //:tools_jit target and dependency from gene…
f65fbd8 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
Update on "remove unused //:tools_jit target and dependency from gene…
2d41b87 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
Update on "remove unused //:tools_jit target and dependency from gene…
cc84b29 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
Update on "remove unused //:tools_jit target and dependency from gene…
cab093e 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
Update on "remove unused //:tools_jit target and dependency from gene…
370ba7a 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
Update on "remove unused //:tools_jit target and dependency from gene…
1245836 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
Update on "remove unused //:tools_jit target and dependency from gene…
f5c172f 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
Update on "remove unused //:tools_jit target and dependency from gene…
50b3e69 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
Update on "remove unused //:tools_jit target and dependency from gene…
5f8e650 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
Update on "remove unused //:tools_jit target and dependency from gene…
a04c531 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
Update on "remove unused //:tools_jit target and dependency from gene…
7dfdca3 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
Michael Andreas Dagitses added 5 commits April 13, 2022 03:31
Update on "remove unused //:tools_jit target and dependency from gene…
46c98e3 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
Update on "remove unused //:tools_jit target and dependency from gene…
fc3962b 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
Update on "remove unused //:tools_jit target and dependency from gene…
dc94633 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
Update on "remove unused //:tools_jit target and dependency from gene…
c51f284 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
Update on "remove unused //:tools_jit target and dependency from gene…
164d176 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request Apr 14, 2022
Closed
@dagitses dagitses mentioned this pull request Apr 14, 2022
Closed
This was referenced Apr 15, 2022
Closed
Closed
Closed
Michael Andreas Dagitses added 6 commits April 15, 2022 15:51
Update on "remove unused //:tools_jit target and dependency from gene…
44bae1e 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
Update on "remove unused //:tools_jit target and dependency from gene…
2fa98b0 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
Update on "remove unused //:tools_jit target and dependency from gene…
4e42766 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
Update on "remove unused //:tools_jit target and dependency from gene…
efce6b6 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
Update on "remove unused //:tools_jit target and dependency from gene…
4f7a8b3 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
Update on "remove unused //:tools_jit target and dependency from gene…
69f43e8 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
@dagitses dagitses mentioned this pull request Apr 16, 2022
Closed
Michael Andreas Dagitses added 4 commits April 16, 2022 14:03
Update on "remove unused //:tools_jit target and dependency from gene…
0e6c93e 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
Update on "remove unused //:tools_jit target and dependency from gene…
f5182b7 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
Update on "remove unused //:tools_jit target and dependency from gene…
5792d0b 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
Update on "remove unused //:tools_jit target and dependency from gene…
6ad07f5 
…rate-code"

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 17, 2022

@pytorchbot merge this

(Initiating merge automatically since Phabricator Diff has merged)

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2022

Hey @dagitses.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Apr 18, 2022
@facebook-github-bot
remove unused //:tools_jit target and dependency from generate-code (#…
e1cd055 
…74837)

Summary:
Pull Request resolved: #74837

This is no longer used.
ghstack-source-id: 154045351

Test Plan: Rely on CI.

Reviewed By: orionr, malfet

Differential Revision: D35187901

fbshipit-source-id: e7906c8489d6bd01faa4a1cabe59e832d922b750
malfet pushed a commit that referenced this pull request Apr 20, 2022
@malfet
remove unused //:tools_jit target and dependency from generate-code
1f805a5 
Pull Request resolved: #74837

This is no longer used.

Differential Revision: [D35187901](https://our.internmc.facebook.com/intern/diff/D35187901/)

Approved by: https://github.com/malfet

(cherry picked from commit ef50186)
@facebook-github-bot facebook-github-bot deleted the gh/dagitses/303/head branch April 21, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dagitses @facebook-github-bot @malfet