remove dead code from generate_code program #74835
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 0baec5b (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Mar 28, 2022
added 2 commits
March 28, 2022 09:59
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
added 13 commits
March 28, 2022 12:16
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
This was referenced Apr 12, 2022
added 12 commits
April 12, 2022 17:05
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
malfet
approved these changes
Apr 14, 2022
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
This was referenced Apr 15, 2022
added 3 commits
April 15, 2022 15:51
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) [ghstack-poisoned]
Contributor
|
@pytorchbot merge this (Initiating merge automatically since Phabricator Diff has merged) |
Contributor
|
Hey @dagitses. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 16, 2022
Summary: Pull Request resolved: #74835 Nothing uses these values any more. ghstack-source-id: 153882163 Test Plan: Should be a no-op. Rely on CI. Reviewed By: orionr, malfet Differential Revision: D35187902 fbshipit-source-id: faaa069e45239fae720c4f6873bdee17ae71b7cc
malfet
pushed a commit
that referenced
this pull request
Apr 20, 2022
Pull Request resolved: #74835 Nothing uses these values any more. Differential Revision: [D35187902](https://our.internmc.facebook.com/intern/diff/D35187902/) Approved by: https://github.com/albanD, https://github.com/malfet (cherry picked from commit 9663886)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Nothing uses these values any more.
Differential Revision: D35187902