[BE Hackathon][DataPipe] Automatically generate datapipe.pyi via CMake#73991
[BE Hackathon][DataPipe] Automatically generate datapipe.pyi via CMake#73991NivekT wants to merge 8 commits intogh/nivekt/52/basefrom
Conversation
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 1fb559a (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
…yi via CMake" Automatically generate `datapipe.pyi` via CMake Since it will be automatically generated, I believe we should remove the output file from git VCS (like other generated .pyi file). [ghstack-poisoned]
…yi via CMake" Automatically generate `datapipe.pyi` via CMake Since it will be automatically generated, I believe we should remove the output file from git VCS (like other generated .pyi file). [ghstack-poisoned]
I removed a dependency and I think it should work fine now |
…yi via CMake" Automatically generate `datapipe.pyi` via CMake Since it will be automatically generated, I believe we should remove the output file from git VCS (like other generated .pyi file). [ghstack-poisoned]
|
@ejguan @albanD Should I be removing the generated .pyi file from git VCS? Here is the trade off (should only impact PyTorch developers):
I am currently keeping the .pyi file in Git but adding it to |
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…yi via CMake" Automatically generate `datapipe.pyi` via CMake and removing the generated .pyi file from Git. Users should have the .pyi file locally after building for the first time. I will also be adding an internal equivalent diff for buck. Differential Revision: [D34868001](https://our.internmc.facebook.com/intern/diff/D34868001) [ghstack-poisoned]
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…yi via CMake" Automatically generate `datapipe.pyi` via CMake and removing the generated .pyi file from Git. Users should have the .pyi file locally after building for the first time. I will also be adding an internal equivalent diff for buck. Differential Revision: [D34868001](https://our.internmc.facebook.com/intern/diff/D34868001) [ghstack-poisoned]
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
#73991) Summary: Pull Request resolved: #73991 Automatically generate `datapipe.pyi` via CMake and removing the generated .pyi file from Git. Users should have the .pyi file locally after building for the first time. I will also be adding an internal equivalent diff for buck. Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D34868001 Pulled By: NivekT fbshipit-source-id: 448c92da659d6b4c5f686407d3723933c266c74f
|
Hey @NivekT. |
…pipe.pyi in setup.py" This should only land after pytorch/pytorch#73991 CI will fail until that PR is landed into Core's nightly. Automatically run the generation of `datapipe.pyi` in `setup.py` and remove the interface (.pyi) file from version control [ghstack-poisoned]
…p.py" This should only land after pytorch/pytorch#73991 CI will fail until that PR is landed into Core's nightly. Automatically run the generation of `datapipe.pyi` in `setup.py` and remove the interface (.pyi) file from version control [ghstack-poisoned]
…pipe.pyi in setup.py" This should only land after pytorch/pytorch#73991 CI will fail until that PR is landed into Core's nightly. Automatically run the generation of `datapipe.pyi` in `setup.py` and remove the interface (.pyi) file from version control [ghstack-poisoned]
…p.py" This should only land after pytorch/pytorch#73991 CI will fail until that PR is landed into Core's nightly. Automatically run the generation of `datapipe.pyi` in `setup.py` and remove the interface (.pyi) file from version control [ghstack-poisoned]
…pipe.pyi in setup.py" This should only land after pytorch/pytorch#73991 CI will fail until that PR is landed into Core's nightly. Automatically run the generation of `datapipe.pyi` in `setup.py` and remove the interface (.pyi) file from version control [ghstack-poisoned]
…p.py" This should only land after pytorch/pytorch#73991 CI will fail until that PR is landed into Core's nightly. Automatically run the generation of `datapipe.pyi` in `setup.py` and remove the interface (.pyi) file from version control [ghstack-poisoned]
…pipe.pyi in setup.py" This should only land after pytorch/pytorch#73991 ~~CI will fail until that PR is landed into Core's nightly.~~ This is working now. Automatically run the generation of `datapipe.pyi` in `setup.py` and remove the interface (.pyi) file from version control Differential Revision: [D34939044](https://our.internmc.facebook.com/intern/diff/D34939044) [ghstack-poisoned]
…p.py" This should only land after pytorch/pytorch#73991 ~~CI will fail until that PR is landed into Core's nightly.~~ This is working now. Automatically run the generation of `datapipe.pyi` in `setup.py` and remove the interface (.pyi) file from version control Differential Revision: [D34939044](https://our.internmc.facebook.com/intern/diff/D34939044) [ghstack-poisoned]
…pipe.pyi in setup.py" This should only land after pytorch/pytorch#73991 ~~CI will fail until that PR is landed into Core's nightly.~~ This is working now. Automatically run the generation of `datapipe.pyi` in `setup.py` and remove the interface (.pyi) file from version control Differential Revision: [D34939044](https://our.internmc.facebook.com/intern/diff/D34939044) [ghstack-poisoned]
…p.py" This should only land after pytorch/pytorch#73991 ~~CI will fail until that PR is landed into Core's nightly.~~ This is working now. Automatically run the generation of `datapipe.pyi` in `setup.py` and remove the interface (.pyi) file from version control Differential Revision: [D34939044](https://our.internmc.facebook.com/intern/diff/D34939044) [ghstack-poisoned]
…pipe.pyi in setup.py" This should only land after pytorch/pytorch#73991 ~~CI will fail until that PR is landed into Core's nightly.~~ This is working now. Automatically run the generation of `datapipe.pyi` in `setup.py` and remove the interface (.pyi) file from version control Differential Revision: [D34939044](https://our.internmc.facebook.com/intern/diff/D34939044) [ghstack-poisoned]
…p.py" This should only land after pytorch/pytorch#73991 ~~CI will fail until that PR is landed into Core's nightly.~~ This is working now. Automatically run the generation of `datapipe.pyi` in `setup.py` and remove the interface (.pyi) file from version control Differential Revision: [D34939044](https://our.internmc.facebook.com/intern/diff/D34939044) [ghstack-poisoned]
Summary: Pull Request resolved: #290 This should only land after pytorch/pytorch#73991 ~~CI will fail until that PR is landed into Core's nightly.~~ This is working now. Automatically run the generation of `datapipe.pyi` in `setup.py` and remove the interface (.pyi) file from version control Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D34939044 Pulled By: NivekT fbshipit-source-id: fa4cdcc01274ea8728b38b13a1410556ef85d8cb
Stack from ghstack:
Automatically generate
datapipe.pyivia CMake and removing the generated .pyi file from Git. Users should have the .pyi file locally after building for the first time.I will also be adding an internal equivalent diff for buck.
Differential Revision: D34868001