[Caffe2] Detect system RocksDB installation with CMake config files. #7315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xkszltl
force-pushed
the
rocksdb
branch
7 times, most recently
from
28aecc2 to
efacb9e
Compare
xkszltl
changed the title
xkszltl
force-pushed
the
rocksdb
branch
2 times, most recently
from
4cac412 to
ab2f7f0
Compare
xkszltl
force-pushed
the
rocksdb
branch
7 times, most recently
from
ab33d8b to
cfd8ba1
Compare
xkszltl
force-pushed
the
rocksdb
branch
4 times, most recently
from
8e2134c to
acb912e
Compare
xkszltl
force-pushed
the
rocksdb
branch
3 times, most recently
from
ead915d to
f7a432d
Compare
xkszltl
force-pushed
the
rocksdb
branch
4 times, most recently
from
e484c1b to
344dbd2
Compare
xkszltl
force-pushed
the
rocksdb
branch
5 times, most recently
from
5709738 to
cc55fa4
Compare
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
Yangqing is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
…7315) Summary: On Windows, the FindRocksDB script doesn't detect rocksdb installation built by cmake. And it doesn't include/link the RocksDB dependencies either, like: * `Snappy` * `Shlwapi.lib` * `Rpcrt4.lib` This PR try to detect in config mode first before using private find module. Pull Request resolved: pytorch#7315 Differential Revision: D9287587 Pulled By: Yangqing fbshipit-source-id: 314a36a14bfe04aa45013349c5537163fb4c5c00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, the FindRocksDB script doesn't detect rocksdb installation built by cmake.
And it doesn't include/link the RocksDB dependencies either, like:
SnappyShlwapi.libRpcrt4.libThis PR try to detect in config mode first before using private find module.