Remove deprecated torch.qr #70989
Open
Remove deprecated torch.qr #70989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanYashchuk
requested review from
ezyang,
lezcano and
nikitaved
as code owners
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit bd4797f (more details on the Dr. CI page):
🕵️ 4 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
IvanYashchuk
requested review from
mruberry
and removed request for
ezyang and
nikitaved
IvanYashchuk
added
module: deprecation
module: linear algebra
3 tasks
dagitses
added
the
triaged
This was referenced Jan 12, 2022
lezcano
approved these changes
Jan 19, 2022
Collaborator
lezcano
left a comment
lezcano
left a comment
There was a problem hiding this comment.
It seems that we forgot to remove a few uses of the old QR in the codebase. Thanks for finding these!
mruberry
reviewed
Mar 14, 2022
| ormqr | ||
| outer | ||
| pinverse | ||
| qr |
Collaborator
There was a problem hiding this comment.
Not for this PR, but I wonder if we should leave old functions in the documentation with a very clear notice about when they were removed?
cc @stas00, who's been thinking about how we could improve the clarity of our documentation when making operator changes
Collaborator
Author
There was a problem hiding this comment.
I agree having a list of removed functions somewhere in the documentation would be useful.
Contributor
There was a problem hiding this comment.
yes, please! thank you for remembering my request, Mike!
Probably either making a new doc that lists all the APIs that were removed and the first pytorch version (not sha!) that no longer had it. or keeping the old doc entry with just the API name and when it was removed. Whatever is easier to maintain.
thank you!
Collaborator
There was a problem hiding this comment.
I like the idea of a separate doc for removed operators. What do you think, @IvanYashchuk, @lezcano, @albanD? We could just write to it directly with the name of the operator and when it was removed.
Collaborator
There was a problem hiding this comment.
Makes sense to me. I think this would be a really helpful feature for libraries that depend on PyTorch
Collaborator
There was a problem hiding this comment.
Agreed a special page for this in the docs would be great. It should contain either details on what to use instead and/or link to the issue/PR with more details).
Contributor
|
@mruberry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
kit1980
added a commit
to kit1980/Ax
that referenced
this pull request
Aug 29, 2022
Summary: torch.qr is deprecated for a long time and is being removed by pytorch/pytorch#70989 Created from CodeHub with https://fburl.com/edit-in-codehub Reviewed By: Balandat Differential Revision: D39079315 fbshipit-source-id: 399f107edb061f5e85a41039a96ffc6e85b95cc5
facebook-github-bot
pushed a commit
to facebook/Ax
that referenced
this pull request
Aug 29, 2022
Summary: Pull Request resolved: #1099 torch.qr is deprecated for a long time and is being removed by pytorch/pytorch#70989 Created from CodeHub with https://fburl.com/edit-in-codehub Reviewed By: Balandat Differential Revision: D39079315 fbshipit-source-id: 83d81c01e7684f0c3a726771980f91e38adc12f5
kit1980
added a commit
to kit1980/fairseq
that referenced
this pull request
Aug 31, 2022
torch.qr is deprecated for a long time and is being removed by pytorch/pytorch#70989. This PR makes the example compatible with new and old PyTorch versions.
Contributor
|
/easycla As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details. This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign. |
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Contributor
|
/easycla |
cbalioglu
pushed a commit
to facebookresearch/fairseq
that referenced
this pull request
Dec 10, 2022
torch.qr is deprecated for a long time and is being removed by pytorch/pytorch#70989. This PR makes the example compatible with new and old PyTorch versions.
Contributor
|
@IvanYashchuk should we revive this? I've already proactively removed some (all?) Meta-internal torch.qr uses. |
cbalioglu
pushed a commit
to facebookresearch/fairseq
that referenced
this pull request
Feb 23, 2023
* fix imports referencing moved metrics.py file * Make representation computation branchless in TransformerEncoderBase (#4818) Summary: We want to make the computation branchless here because fairseq code may be exported and traced for deployment purposes, and tracing mechanisms can break the correctness for a captured program if it's dependent on input data. In this diff we try to rewrite the code to remove one branch so that tracer can proceed here and preserve the correct semantics of the model. Test Plan: CI Reviewers: Subscribers: Tasks: Tags: * Fix Torchscript typing in transformer_encoder.py (#4847) * Add Generative Spoken Dialogue Language Modeling (#4879) * Update deprecated torch.qr in glow.py example (#4685) torch.qr is deprecated for a long time and is being removed by pytorch/pytorch#70989. This PR makes the example compatible with new and old PyTorch versions. * Emotion Conversion Paper Open Source (#4895) * data2vec v2.0 (#4903) data2v2c 2.0 Co-authored-by: Arun Babu <[email protected]> Co-authored-by: Wei-Ning Hsu <[email protected]> * remove missing config entries when loading task from checkpoint (#4905) * make apex optional (#4906) * Add file to generate manifests for stop dataset. (#4891) * Update STOP dataset README to include proper link. (#4892) * Update README.md (#4893) * using foreach to reduce kernel (#4904) * using foreach to reduce kernel * set reproducibility to looser threshold * revert optimzer * update * update * update * update * update * update * update Co-authored-by: juntengjia <[email protected]> * Update README.md to add data2vec blog post (#4913) * Update README.md * Update config to fix circleci failure (#4949) https://app.circleci.com/pipelines/github/fairinternal/fairseq-py/12635/workflows/3befbae2-79c4-458d-9fc4-aad4484183b4/jobs/26767 * Generative Spoken Dialogue Language Modeling Paper Open Source (#4957) * wav2vec2_laser (#4968) * ASR BLEU tool copied from ust branch into main (#4914) * Add transcript option for asr-bleu (#4981) --------- Co-authored-by: zhxchen17 <[email protected]> Co-authored-by: zhxchen17 <[email protected]> Co-authored-by: Nguyen Tu Anh <[email protected]> Co-authored-by: Sergii Dymchenko <[email protected]> Co-authored-by: Felix Kreuk <[email protected]> Co-authored-by: Alexei Baevski <[email protected]> Co-authored-by: padentomasello <[email protected]> Co-authored-by: Junteng Jia <[email protected]> Co-authored-by: juntengjia <[email protected]> Co-authored-by: arbabu123 <[email protected]> Co-authored-by: dianaml0 <[email protected]> Co-authored-by: Pierre Andrews <[email protected]> Co-authored-by: Ilia Kulikov <[email protected]> Co-authored-by: Xutai Ma <[email protected]>
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
lwb2099
pushed a commit
to lwb2099/fairseq
that referenced
this pull request
Apr 26, 2023
torch.qr is deprecated for a long time and is being removed by pytorch/pytorch#70989. This PR makes the example compatible with new and old PyTorch versions.
lwb2099
pushed a commit
to lwb2099/fairseq
that referenced
this pull request
Apr 26, 2023
* fix imports referencing moved metrics.py file * Make representation computation branchless in TransformerEncoderBase (facebookresearch#4818) Summary: We want to make the computation branchless here because fairseq code may be exported and traced for deployment purposes, and tracing mechanisms can break the correctness for a captured program if it's dependent on input data. In this diff we try to rewrite the code to remove one branch so that tracer can proceed here and preserve the correct semantics of the model. Test Plan: CI Reviewers: Subscribers: Tasks: Tags: * Fix Torchscript typing in transformer_encoder.py (facebookresearch#4847) * Add Generative Spoken Dialogue Language Modeling (facebookresearch#4879) * Update deprecated torch.qr in glow.py example (facebookresearch#4685) torch.qr is deprecated for a long time and is being removed by pytorch/pytorch#70989. This PR makes the example compatible with new and old PyTorch versions. * Emotion Conversion Paper Open Source (facebookresearch#4895) * data2vec v2.0 (facebookresearch#4903) data2v2c 2.0 Co-authored-by: Arun Babu <[email protected]> Co-authored-by: Wei-Ning Hsu <[email protected]> * remove missing config entries when loading task from checkpoint (facebookresearch#4905) * make apex optional (facebookresearch#4906) * Add file to generate manifests for stop dataset. (facebookresearch#4891) * Update STOP dataset README to include proper link. (facebookresearch#4892) * Update README.md (facebookresearch#4893) * using foreach to reduce kernel (facebookresearch#4904) * using foreach to reduce kernel * set reproducibility to looser threshold * revert optimzer * update * update * update * update * update * update * update Co-authored-by: juntengjia <[email protected]> * Update README.md to add data2vec blog post (facebookresearch#4913) * Update README.md * Update config to fix circleci failure (facebookresearch#4949) https://app.circleci.com/pipelines/github/fairinternal/fairseq-py/12635/workflows/3befbae2-79c4-458d-9fc4-aad4484183b4/jobs/26767 * Generative Spoken Dialogue Language Modeling Paper Open Source (facebookresearch#4957) * wav2vec2_laser (facebookresearch#4968) * ASR BLEU tool copied from ust branch into main (facebookresearch#4914) * Add transcript option for asr-bleu (facebookresearch#4981) --------- Co-authored-by: zhxchen17 <[email protected]> Co-authored-by: zhxchen17 <[email protected]> Co-authored-by: Nguyen Tu Anh <[email protected]> Co-authored-by: Sergii Dymchenko <[email protected]> Co-authored-by: Felix Kreuk <[email protected]> Co-authored-by: Alexei Baevski <[email protected]> Co-authored-by: padentomasello <[email protected]> Co-authored-by: Junteng Jia <[email protected]> Co-authored-by: juntengjia <[email protected]> Co-authored-by: arbabu123 <[email protected]> Co-authored-by: dianaml0 <[email protected]> Co-authored-by: Pierre Andrews <[email protected]> Co-authored-by: Ilia Kulikov <[email protected]> Co-authored-by: Xutai Ma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time has come to remove deprecated linear algebra related functions. This PR removes
torch.qr.Fixes to torch/xla need to be merged before this PR:
cc @jianyuh @nikitaved @pearu @mruberry @walterddr @IvanYashchuk @xwang233 @lezcano