Remove deprecated torch.matrix_rank #70981
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanYashchuk
added
module: linear algebra
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 5d38ad9 (more details on the Dr. CI page):
🕵️ 4 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
3 tasks
dagitses
added
the
triaged
lezcano
approved these changes
Jan 19, 2022
Contributor
|
@mruberry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/70981
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e5a1bd7: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
@kit1980 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kit1980
approved these changes
Sep 21, 2022
Contributor
|
@IvanYashchuk I think this can be merged now. Feel free to merge the usual way when you ready. |
Collaborator
|
@pytorchbot merge |
Collaborator
|
@pytorchbot successfully started a merge job. Check the current status here. |
Collaborator
Merge failedReason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. If you believe this is an error, you can use the old behavior with Please reach out to the PyTorch DevX Team with feedback or questions! Details for Dev Infra teamRaised by workflow job |
Contributor
|
@pytorchbot rebase |
Collaborator
|
@pytorchbot successfully started a rebase job. Check the current status here |
Collaborator
|
Rebase failed due to Command |
Contributor
|
Looks like this needs manual rebase. |
Contributor
|
@kit1980 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@pytorchbot merge |
Collaborator
|
@pytorchbot successfully started a merge job. Check the current status here. |
Contributor
|
Hey @IvanYashchuk. |
mehtanirav
pushed a commit
that referenced
this pull request
Oct 4, 2022
The time has come to remove deprecated linear algebra related functions. This PR removes `torch.matrix_rank`. cc @jianyuh @nikitaved @pearu @mruberry @walterddr @IvanYashchuk @xwang233 @lezcano Pull Request resolved: #70981 Approved by: https://github.com/lezcano, https://github.com/kit1980
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time has come to remove deprecated linear algebra related functions. This PR removes
torch.matrix_rank.cc @jianyuh @nikitaved @pearu @mruberry @walterddr @IvanYashchuk @xwang233 @lezcano