Remove deprecated torch.chain_matmul #70978
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanYashchuk
added
module: linear algebra
IvanYashchuk
requested review from
ezyang,
lezcano and
nikitaved
as code owners
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 2d6f4dc (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: jit
3 tasks
lezcano
approved these changes
Jan 11, 2022
Collaborator
Author
|
@pytorchbot ciflow rerun |
Contributor
|
@mruberry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Contributor
|
Internally I don't see any blocking issues except one tiny thing, I have a separate PR #85032 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 14, 2022
This issue was found after importing #70978 into fbsource.
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 15, 2022
This issue was found after importing #70978 into fbsource. Pull Request resolved: #85032 Approved by: https://github.com/huydhn
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 15, 2022
This issue was found after importing #70978 into fbsource. Pull Request resolved: #85032 Approved by: https://github.com/huydhn
Collaborator
Author
|
@linbinyu I see you added Android binary files. This PR removes one function and What's the process of updating these files? |
Contributor
@linbinyu @IvanYashchuk I'll take care of this. |
Contributor
|
/easycla As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details. This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign. |
mehtanirav
pushed a commit
that referenced
this pull request
Oct 4, 2022
This issue was found after importing #70978 into fbsource. Pull Request resolved: #85032 Approved by: https://github.com/huydhn
Contributor
|
/easycla |
pytorch-bot
bot
added
release notes: linalg_frontend
Contributor
|
@IvanYashchuk should we revive this? |
Collaborator
Author
|
Definitely! Thanks for the ping, I'll update this and my other PRs. |
Collaborator
Author
|
@kit1980, this problem with Android files persists: #70978 (comment). Assets added in #74947 need to be updated. |
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time has come to remove deprecated linear algebra related functions. This PR removes
torch.chain_matmul.Previous attempt: #69857.
cc @EikanWang @jgong5 @wenzhe-nrv @sanchitintel @jianyuh @nikitaved @pearu @mruberry @walterddr @xwang233 @lezcano @mcarilli @ptrblck @leslie-fang-intel @IvanYashchuk