Remove deprecated linear algebra related functions #69857
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
IvanYashchuk
commented
Dec 14, 2021
Collaborator
Author
|
@pytorchbot ciflow rerun |
…ze_multiple' already defined.'
… -> (Tensor, Tensor). Do you have to update a set of hardcoded JIT ops?'
IvanYashchuk
force-pushed
the
remove-deprecated-code
branch
from
cb5cf6d to
2c17be8
Compare
IvanYashchuk
requested review from
albanD,
ezyang,
lezcano,
nikitaved and
soulitzer
as code owners
IvanYashchuk
added
the
module: linear algebra
lezcano
reviewed
Jan 3, 2022
Collaborator
lezcano
left a comment
lezcano
left a comment
There was a problem hiding this comment.
eig_backward should also be removed from FunctionsManual.cpp and the header file.
There's a minor clean-up that can be made in eigh_backward as well, where the eigenvectors argument was only used in symeig.
ngimel
added
the
triaged
Collaborator
Author
|
I will split the PR into multiple smaller ones for an easier review process and easier reverting if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the time has come to finally remove a few of the deprecated functions.
List of removed functions (split this PR into separate ones):
Fixes to torch/xla need to be merged before this PR:
cc @jianyuh @nikitaved @pearu @mruberry @walterddr @IvanYashchuk @xwang233 @lezcano