[release/1.10] TST Adds test for non-contiguous tensors (#64954)#69617
Merged
malfet merged 2 commits intorelease/1.10from Dec 9, 2021
Merged
[release/1.10] TST Adds test for non-contiguous tensors (#64954)#69617malfet merged 2 commits intorelease/1.10from
malfet merged 2 commits intorelease/1.10from
Conversation
Summary: Follow up to #61935 This PR: 1. Adds test for non-contiguous tensors 2. Fixes bug in `NLLLoss` that was catch by the test. The reason this was not catch in `common_nn` is because `CriterionTest` overrides `test_cuda` but does not call `test_nonconfig`. cc albanD mruberry jbschlosser walterddr Pull Request resolved: #64954 Reviewed By: zou3519 Differential Revision: D31174149 Pulled By: jbschlosser fbshipit-source-id: a16073e59b40ccc01c82ede016b63a8db2e810f5 (cherry picked from commit 0d3bf97) Signed-off-by: Eli Uriegas <[email protected]>
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit d1e4cba (more details on the Dr. CI page):
🕵️ 4 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
Member
Author
|
Appears as though test failures are legitimate for this particular PR. This might make this PR miss the cut for 1.10.1 unless we can resolve the test failures |
Namely, `make_weight` partial into `module_inputs_torch_nn_NLLLoss`
Contributor
|
Cherry-picked missing changes in d1e4cba |
malfet
approved these changes
Dec 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick of
Original commit message
Summary:
Follow up to #61935
This PR:
NLLLossthat was catch by the test.The reason this was not catch in
common_nnis becauseCriterionTestoverridestest_cudabut does not calltest_nonconfig.cc albanD mruberry jbschlosser walterddr
Pull Request resolved: #64954
Reviewed By: zou3519
Differential Revision: D31174149
Pulled By: jbschlosser
fbshipit-source-id: a16073e59b40ccc01c82ede016b63a8db2e810f5
(cherry picked from commit 0d3bf97)
Signed-off-by: Eli Uriegas [email protected]
Fixes #{issue number}