Extend explanation of torch.cholesky_inverse to consider batched inputs.
#69069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit aa3ceb8 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
nonconvexopt
changed the title
torch.cholesky_inverse
nonconvexopt
changed the title
torch.cholesky_inversetorch.cholesky_inverse to consider batched inputs.
samdow
added
the
triaged
neerajprad
reviewed
Nov 30, 2021
mruberry
reviewed
Dec 1, 2021
mruberry
reviewed
Dec 1, 2021
torch/_torch_docs.py
Outdated
| [-0.0889, 0.2122, 0.1412]]) | ||
| >>> a = torch.randn(3, 2, 2) | ||
| >>> a = a @ a.mT + 1e-03 # make symmetric positive-definite | ||
| >>> l = torch.cholesky(a) |
Collaborator
There was a problem hiding this comment.
Let's update this to use the non-deprecate linalg operators (so linalg.cholesky here and above and linalg.inv instead of inverse)
Contributor
Author
There was a problem hiding this comment.
Thanks for checking. I reflected it.
@mruberry Is it possible that functions like torch.cholesky_inverse will be deprecated in near future?
Collaborator
There was a problem hiding this comment.
We intend to port all the linear algebra functions to torch.linalg, so I'd say yes. Now, "the near future" might very well span from 6 months to a full year.
Contributor
Author
There was a problem hiding this comment.
That's great! I hope to contribute in the process if I can afford to do so at that time. :)
For now, I will just revise the docs.
Contributor
There was a problem hiding this comment.
nit: Seems like this isn't updated to torch.linalg.cholesky yet.
Collaborator
|
Hey @nonconvexopt! Thanks for taking the time to help update the documentation for |
neerajprad
reviewed
Dec 1, 2021
…:nonconvexopt/pytorch into finish_doc_update_about_cholesky_inverse
neerajprad
reviewed
Dec 3, 2021
Contributor
neerajprad
left a comment
neerajprad
left a comment
There was a problem hiding this comment.
Just some small comments. LGTM pending @mruberry's comments.
torch/_torch_docs.py
Outdated
| [-0.0889, 0.2122, 0.1412]]) | ||
| >>> a = torch.randn(3, 2, 2) | ||
| >>> a = a @ a.mT + 1e-03 # make symmetric positive-definite | ||
| >>> l = torch.cholesky(a) |
Contributor
There was a problem hiding this comment.
nit: Seems like this isn't updated to torch.linalg.cholesky yet.
…:nonconvexopt/pytorch into finish_doc_update_about_cholesky_inverse
neerajprad
approved these changes
Dec 6, 2021
Contributor
|
@mruberry - does this look good to you? |
mruberry
reviewed
Dec 8, 2021
mruberry
approved these changes
Dec 8, 2021
Collaborator
mruberry
left a comment
mruberry
left a comment
There was a problem hiding this comment.
Looks good; one small nit about preserving the torch.cholesky example calling torch.cholesky (instead of torch.linalg.cholesky)
neerajprad
reviewed
Dec 8, 2021
Contributor
|
@neerajprad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
PaliC
added a commit
that referenced
this pull request
Dec 10, 2021
…puts. (#69069) Summary: While implementing #68720, We found out empirically that `torch.cholesky_inverse` support batched inputs, but it is not explained in doc: [link](#68720 (review)) `torch.cholesky_inverse` is implemented in #50269 and the doc was updated at #31275 but not merged. neerajprad Reviewed By: mrshenli Differential Revision: D32979362 Pulled By: neerajprad fbshipit-source-id: 0967c969434ce6e0ab15889c240149c23c0bce44 [ghstack-poisoned]
PaliC
added a commit
that referenced
this pull request
Dec 10, 2021
…puts. (#69069) Summary: While implementing #68720, We found out empirically that `torch.cholesky_inverse` support batched inputs, but it is not explained in doc: [link](#68720 (review)) `torch.cholesky_inverse` is implemented in #50269 and the doc was updated at #31275 but not merged. neerajprad Reviewed By: mrshenli Differential Revision: D32979362 Pulled By: neerajprad fbshipit-source-id: 0967c969434ce6e0ab15889c240149c23c0bce44
desertfire
pushed a commit
that referenced
this pull request
Dec 13, 2021
…puts. (#69069) Summary: While implementing #68720, We found out empirically that `torch.cholesky_inverse` support batched inputs, but it is not explained in doc: [link](#68720 (review)) `torch.cholesky_inverse` is implemented in #50269 and the doc was updated at #31275 but not merged. neerajprad Pull Request resolved: #69069 Reviewed By: mrshenli Differential Revision: D32979362 Pulled By: neerajprad fbshipit-source-id: 0967c969434ce6e0ab15889c240149c23c0bce44
desertfire
pushed a commit
that referenced
this pull request
Dec 14, 2021
…puts. (#69069) Summary: While implementing #68720, We found out empirically that `torch.cholesky_inverse` support batched inputs, but it is not explained in doc: [link](#68720 (review)) `torch.cholesky_inverse` is implemented in #50269 and the doc was updated at #31275 but not merged. neerajprad Pull Request resolved: #69069 Reviewed By: mrshenli Differential Revision: D32979362 Pulled By: neerajprad fbshipit-source-id: 0967c969434ce6e0ab15889c240149c23c0bce44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing #68720,
We found out empirically that
torch.cholesky_inversesupport batched inputs, but it is not explained in doc: linktorch.cholesky_inverseis implemented in #50269 and the doc was updated at #31275 but not merged.@neerajprad