#671 Adds bias=False tests to Conv modules #676
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@pytorchbot add to whitelist |
Contributor
|
There are some no bias conv tests already, can you please remove them? |
Contributor
|
where are they, i couldn't find them in test_nn.py |
Contributor
|
It's also likely to break because you're not changing the test name. Append no_bias to it before adding the test second time |
Contributor
|
@soumith search for no_bias |
Contributor
Author
|
I made the mistake of not having good branch discipline, so between that and having to split the work between this repo and |
onnxbot
added a commit
that referenced
this pull request
Apr 10, 2018
mrshenli
pushed a commit
to mrshenli/pytorch
that referenced
this pull request
Apr 11, 2020
Add named tensor tutorial
rohithkrn
pushed a commit
to rohithkrn/pytorch
that referenced
this pull request
Jun 26, 2020
…esting_ifu_20200617 rocm3.6_internal testing IFU_20200617
KyleCZH
pushed a commit
to KyleCZH/pytorch
that referenced
this pull request
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit is just the tests; want to verify that they pass in the 2d case and fail in the 3d.
Backend changes waiting.