Skip to content

Improve assert failure message in test_get_torch_func_signature_exhaustive#67039

Closed
pearu wants to merge 4 commits intogh/pearu/8/basefrom
gh/pearu/8/head
Closed

Improve assert failure message in test_get_torch_func_signature_exhaustive#67039
pearu wants to merge 4 commits intogh/pearu/8/basefrom
gh/pearu/8/head

Conversation

@pearu
Copy link
Copy Markdown
Collaborator

@pearu pearu commented Oct 21, 2021

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Oct 21, 2021

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 06e2877 (more details on the Dr. CI page):


  • 3/3 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build linux-xenial-py3.6-gcc5.4 / build-docs (cpp) (1/2)

Step: "Unknown" (full log | diagnosis details | 🔁 rerun)

2021-10-25T11:32:44.8156994Z error: could not l...modules/third_party/zstd/config: Permission denied
2021-10-25T11:32:44.8005128Z http.https://github.com/.extraheader
2021-10-25T11:32:44.8015738Z error: could not lock config file /home/ec2-user/actions-runner/_work/pytorch/pytorch/.git/modules/third_party/tensorpipe/modules/third_party/libuv/config: Permission denied
2021-10-25T11:32:44.8029709Z Entering 'third_party/tensorpipe/third_party/pybind11'
2021-10-25T11:32:44.8050007Z http.https://github.com/.extraheader
2021-10-25T11:32:44.8062245Z error: could not lock config file /home/ec2-user/actions-runner/_work/pytorch/pytorch/.git/modules/third_party/tensorpipe/modules/third_party/pybind11/config: Permission denied
2021-10-25T11:32:44.8074438Z Entering 'third_party/tensorpipe/third_party/pybind11/tools/clang'
2021-10-25T11:32:44.8097597Z http.https://github.com/.extraheader
2021-10-25T11:32:44.8112120Z error: could not lock config file /home/ec2-user/actions-runner/_work/pytorch/pytorch/.git/modules/third_party/tensorpipe/modules/third_party/pybind11/modules/tools/clang/config: Permission denied
2021-10-25T11:32:44.8127992Z Entering 'third_party/zstd'
2021-10-25T11:32:44.8146070Z http.https://github.com/.extraheader
2021-10-25T11:32:44.8156994Z error: could not lock config file /home/ec2-user/actions-runner/_work/pytorch/pytorch/.git/modules/third_party/zstd/config: Permission denied
2021-10-25T11:32:44.8218182Z Cleaning up orphan processes
2021-10-25T11:32:44.8505717Z Terminate orphan process: pid (9079) (docker)

See GitHub Actions build linux-xenial-py3.6-gcc5.4 / build-docs (python) (2/2)

Step: "Build python docs" (full log | diagnosis details | 🔁 rerun)

2021-10-25T11:32:28.6642441Z error: could not l...modules/third_party/zstd/config: Permission denied
2021-10-25T11:32:28.6505689Z http.https://github.com/.extraheader
2021-10-25T11:32:28.6516543Z error: could not lock config file /home/ec2-user/actions-runner/_work/pytorch/pytorch/.git/modules/third_party/tensorpipe/modules/third_party/libuv/config: Permission denied
2021-10-25T11:32:28.6529529Z Entering 'third_party/tensorpipe/third_party/pybind11'
2021-10-25T11:32:28.6546658Z http.https://github.com/.extraheader
2021-10-25T11:32:28.6558677Z error: could not lock config file /home/ec2-user/actions-runner/_work/pytorch/pytorch/.git/modules/third_party/tensorpipe/modules/third_party/pybind11/config: Permission denied
2021-10-25T11:32:28.6570207Z Entering 'third_party/tensorpipe/third_party/pybind11/tools/clang'
2021-10-25T11:32:28.6588084Z http.https://github.com/.extraheader
2021-10-25T11:32:28.6598696Z error: could not lock config file /home/ec2-user/actions-runner/_work/pytorch/pytorch/.git/modules/third_party/tensorpipe/modules/third_party/pybind11/modules/tools/clang/config: Permission denied
2021-10-25T11:32:28.6612920Z Entering 'third_party/zstd'
2021-10-25T11:32:28.6630894Z http.https://github.com/.extraheader
2021-10-25T11:32:28.6642441Z error: could not lock config file /home/ec2-user/actions-runner/_work/pytorch/pytorch/.git/modules/third_party/zstd/config: Permission denied
2021-10-25T11:32:28.6705800Z Cleaning up orphan processes


1 failure not recognized by patterns:

Job Step Action
GitHub Actions linux-xenial-py3.6-gcc5.4 / test (docs_test, 1, 1, linux.2xlarge) Test 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@pytorch-probot
Copy link
Copy Markdown

pytorch-probot bot commented Oct 21, 2021

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/06e28778bb606f5e9b8d84a8252588b36e262b3a/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default

Workflows Labels (bold enabled) Status
Triggered Workflows
linux-bionic-py3.6-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/noarch, ciflow/xla ✅ triggered
linux-vulkan-bionic-py3.6-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/vulkan ✅ triggered
linux-xenial-cuda11.3-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-py3-clang5-mobile-build ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile ✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-dynamic ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile ✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile ✅ triggered
linux-xenial-py3.6-clang7-asan ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/sanitizers ✅ triggered
linux-xenial-py3.6-clang7-onnx ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/onnx ✅ triggered
linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-py3.6-gcc7-bazel-test ciflow/all, ciflow/bazel, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
win-vs2019-cpu-py3 ciflow/all, ciflow/cpu, ciflow/default, ciflow/win ✅ triggered
win-vs2019-cuda11.3-py3 ciflow/all, ciflow/cuda, ciflow/default, ciflow/win ✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux 🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux 🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux 🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow 🚫 skipped
linux-xenial-cuda10.2-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow 🚫 skipped
linux-xenial-py3-clang5-mobile-code-analysis ciflow/all, ciflow/linux, ciflow/mobile 🚫 skipped
parallelnative-linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux 🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled, ciflow/slow, ciflow/slow-gradcheck 🚫 skipped
periodic-linux-xenial-cuda11.1-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-win-vs2019-cuda11.1-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped

You can add a comment to the PR and tag @pytorchbot with the following commands:
# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

pearu added a commit that referenced this pull request Oct 21, 2021
@pearu pearu added the module: tests Issues related to tests (not the torch.testing module) label Oct 21, 2021
@mruberry mruberry requested a review from jamesr66a October 22, 2021 05:47
@mruberry
Copy link
Copy Markdown
Collaborator

It is odd that this test appears to be failing on unrelated PRs today and the error message on for those failures is very cryptic -- @jamesr66a or @Chillee do you know what's up?

…ature_exhaustive"

cc mruberry

[ghstack-poisoned]
pearu added a commit that referenced this pull request Oct 22, 2021
@pearu
Copy link
Copy Markdown
Collaborator Author

pearu commented Oct 22, 2021

It looks like the underlying problem in CI failures was in #66784 (now reverted) that repeats in #67088 (still in a cryptic way), and not in this particular PR.

…ature_exhaustive"

cc mruberry

[ghstack-poisoned]
@pearu
Copy link
Copy Markdown
Collaborator Author

pearu commented Oct 22, 2021

@mruberry The explanation for the failing tests is given here: #67088 (comment) . Basically, make_tensor was able to produce an invalid sample for cov. This PR implements a fix.

…ature_exhaustive"

cc mruberry

[ghstack-poisoned]
@pearu pearu requested a review from ngimel October 25, 2021 15:01
@cpuhrsch
Copy link
Copy Markdown
Contributor

@cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Oct 25, 2021
…stive (#67039)

Summary:
Pull Request resolved: #67039

cc mruberry

Test Plan: Imported from OSS

Reviewed By: ngimel

Differential Revision: D31899719

Pulled By: cpuhrsch

fbshipit-source-id: 819d07da5b18b31d462010b9f9382e0b8cd10f9f
langong347 pushed a commit that referenced this pull request Oct 25, 2021
…stive (#67039)

Summary:
Pull Request resolved: #67039

cc mruberry

Test Plan: Imported from OSS

Reviewed By: ngimel

Differential Revision: D31899719

Pulled By: cpuhrsch

fbshipit-source-id: 819d07da5b18b31d462010b9f9382e0b8cd10f9f
@facebook-github-bot facebook-github-bot deleted the gh/pearu/8/head branch November 25, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed module: tests Issues related to tests (not the torch.testing module) open source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants