Closed
Conversation
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
This was referenced Oct 18, 2021
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 24c43c4 (more details on the Dr. CI page):
🕵️ 6 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
[ghstack-poisoned]
cc nikitaved pearu cpuhrsch @IvanYashchuk [ghstack-poisoned]
cc nikitaved pearu cpuhrsch [ghstack-poisoned]
cc nikitaved pearu cpuhrsch @IvanYashchuk [ghstack-poisoned]
cc nikitaved pearu cpuhrsch [ghstack-poisoned]
cpuhrsch
reviewed
Oct 21, 2021
Contributor
|
With this stack almost resolved I think we can reasonably get started on the masked normalizations. In particular the long awaited masked_softmax. |
Collaborator
Author
|
OK, I'll refactor this PR into two. |
cc nikitaved pearu cpuhrsch [ghstack-poisoned]
Contributor
|
@cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
cpuhrsch
approved these changes
Oct 21, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 21, 2021
Summary: Pull Request resolved: #66784 cc nikitaved pearu cpuhrsch Test Plan: Imported from OSS Reviewed By: saketh-are Differential Revision: D31838513 Pulled By: cpuhrsch fbshipit-source-id: 54b99ccf9821832c31976406379939b3c95f41de
Collaborator
Contributor
|
This pull request has been reverted by b8c6cdb04bdc64c28509132df3abf3d23699e5e1. To re-land this change, follow these steps. |
Contributor
|
This pull request has been reverted by 20f08d2. To re-land this change, follow these steps. |
Collaborator
|
Superseded by #67088 |
Contributor
|
This pull request has been reverted by 20f08d2. To re-land this change, follow these steps. |
Contributor
|
I don't know why the bot decided to comment just now, but the code has landed so we can ignore it. |
Collaborator
Author
|
yes, I was also wondering about this but then noticed that revert-hash was the same as on Oct 23 and the code is still present in master.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
cc @nikitaved @pearu @cpuhrsch @IvanYashchuk
Differential Revision: D31838513