Skip to content

Handle shared memory cases in MathBithFallback#66576

Merged
malfet merged 1 commit intopytorch:release/1.10from
anjali411:release/1.10
Oct 14, 2021
Merged

Handle shared memory cases in MathBithFallback#66576
malfet merged 1 commit intopytorch:release/1.10from
anjali411:release/1.10

Conversation

@anjali411
Copy link
Copy Markdown
Contributor

@anjali411 anjali411 commented Oct 13, 2021

No description provided.

@pytorch-probot
Copy link
Copy Markdown

pytorch-probot bot commented Oct 13, 2021 •
edited
Loading

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/anjali411/pytorch/blob/533e33e6bec3dbae9b4e34312004f41793bd3c90/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default

Workflows Labels (bold enabled) Status
Triggered Workflows
linux-bionic-py3.6-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/noarch, ciflow/xla ✅ triggered
linux-bionic-py3.8-gcc9-coverage ciflow/all, ciflow/coverage, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-cuda11.3-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-py3.6-gcc7-bazel-test ciflow/all, ciflow/bazel, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
win-vs2019-cpu-py3 ciflow/all, ciflow/cpu, ciflow/default, ciflow/win ✅ triggered
win-vs2019-cuda11.3-py3 ciflow/all, ciflow/cuda, ciflow/default, ciflow/win ✅ triggered
Skipped Workflows
libtorch-linux-xenial-cuda10.2-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux 🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux 🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow 🚫 skipped
linux-xenial-cuda10.2-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow 🚫 skipped
parallelnative-linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux 🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-xenial-cuda11.1-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-win-vs2019-cuda11.1-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped
puretorch-linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux 🚫 skipped
win-vs2019-cuda10.2-py3 ciflow/all, ciflow/cuda, ciflow/win 🚫 skipped

You can add a comment to the PR and tag @pytorchbot with the following commands: 
# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Oct 13, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 533e33e (more details on the Dr. CI page):

  • 3/3 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build linux-xenial-py3.6-gcc5.4 / test (backwards_compat, 1, 1, linux.2xlarge) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2021-10-14T18:25:03.9689018Z RuntimeError: 
2021-10-14T18:25:03.3690008Z Author: PyTorch Team
2021-10-14T18:25:03.3690518Z Author-email: [email protected]
2021-10-14T18:25:03.3691002Z License: BSD-3
2021-10-14T18:25:03.3691526Z Location: /opt/conda/lib/python3.6/site-packages
2021-10-14T18:25:03.3692173Z Requires: dataclasses, typing-extensions
2021-10-14T18:25:03.3692696Z Required-by: 
2021-10-14T18:25:03.3890777Z + python check_backward_compatibility.py --existing-schemas nightly_schemas.txt
2021-10-14T18:25:03.9687452Z Traceback (most recent call last):
2021-10-14T18:25:03.9688082Z   File "check_backward_compatibility.py", line 155, in <module>
2021-10-14T18:25:03.9688616Z     s = parse_schema(line.strip())
2021-10-14T18:25:03.9689018Z RuntimeError: 
2021-10-14T18:25:03.9689584Z Unknown custom class type cuda.Stream. Please ensure it is registered.:
2021-10-14T18:25:03.9691103Z cuda::default_stream.device(Device? device) -> (__torch__.torch.classes.cuda.Stream)
2021-10-14T18:25:03.9691924Z                                                                              ~~~~~~ <--- HERE
2021-10-14T18:25:03.9692148Z 
2021-10-14T18:25:04.0495619Z + cleanup
2021-10-14T18:25:04.0496218Z + retcode=1
2021-10-14T18:25:04.0496644Z + set +x
2021-10-14T18:25:04.0497323Z =================== sccache compilation log ===================
2021-10-14T18:25:04.0685347Z =========== If your build fails, please take a look at the log above for possible reasons ===========
2021-10-14T18:25:04.0734247Z Compile requests                      0

2 failures not recognized by patterns:

Job Step Action
GitHub Actions Lint / flake8-py3 Fail if there were any warnings 🔁 rerun
GitHub Actions Lint / quick-checks Ensure no trailing spaces 🔁 rerun
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@anjali411 anjali411 mentioned this pull request Oct 13, 2021
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 14, 2021 •
edited
Loading

Codecov Report

Merging #66576 (1ff86f1) into release/1.10 (4a514dd) will increase coverage by 20.46%.
The diff coverage is n/a.

❗ Current head 1ff86f1 differs from pull request most recent head 533e33e. Consider uploading reports for the commit 533e33e to get more accurate results

@@                Coverage Diff                @@
##           release/1.10   #66576       +/-   ##
=================================================
+ Coverage         45.85%   66.32%   +20.46%     
=================================================
  Files               738      738               
  Lines             94178    94296      +118     
=================================================
+ Hits              43189    62541    +19352     
+ Misses            50989    31755    -19234

@anjali411 anjali411 requested a review from malfet October 14, 2021 18:04
@anjali411
Disable .numpy() and .tolist() for tensor subclasses subclasses and f…
533e33e 
…ix .tolist() for conjugated and negated tensors (pytorch#66082)

Summary:
Pull Request resolved: pytorch#66082

Fixes pytorch#66024 pytorch#65779

cc ezyang anjali411 dylanbespalko mruberry Lezcano nikitaved albanD

Test Plan: Imported from OSS

Reviewed By: Gamrix, albanD

Differential Revision: D31615588

Pulled By: anjali411

fbshipit-source-id: c3e65ef0fe301630eb76732ccd7819683c09aa19
@malfet malfet merged commit 3c134b8 into pytorch:release/1.10 Oct 14, 2021
@WBobby WBobby mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anjali411 @facebook-github-bot @malfet