fix pybind issue for get_autocast_cpu_dtype and get_autocast_gpu_dtype#66396
Closed
XiaobingSuper wants to merge 1 commit intopytorch:masterfrom
Closed
fix pybind issue for get_autocast_cpu_dtype and get_autocast_gpu_dtype#66396XiaobingSuper wants to merge 1 commit intopytorch:masterfrom
XiaobingSuper wants to merge 1 commit intopytorch:masterfrom
Conversation
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
XiaobingSuper
force-pushed
the
autocast_dtype
branch
from
127d7e1 to
2b8fe0e
Compare
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 2b8fe0e (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
albanD
approved these changes
Oct 11, 2021
Collaborator
albanD
left a comment
albanD
left a comment
There was a problem hiding this comment.
LGTM thanks for the fix!
Contributor
|
@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
seemethere
pushed a commit
that referenced
this pull request
Dec 8, 2021
#66396) Summary: There has an issue when calling **torch.get_autocast_cpu_dtype** and **torch.get_autocast_gpu_dtype**: ``` >>> torch.get_autocast_gpu_dtype()==torch.half False >>> torch.get_autocast_cpu_dtype()==torch.bfloat16 False ``` but the expected results should be : ``` >>> torch.get_autocast_gpu_dtype()==torch.half True >>> torch.get_autocast_cpu_dtype()==torch.bfloat16 True ``` This PR is about fixing this issue. Pull Request resolved: #66396 Reviewed By: ejguan Differential Revision: D31541727 Pulled By: albanD fbshipit-source-id: 1a0fe070a82590ef2926a517bf48046c2633d168 (cherry picked from commit 822c085) Signed-off-by: Eli Uriegas <[email protected]>
This was referenced Dec 8, 2021
seemethere
pushed a commit
that referenced
this pull request
Dec 9, 2021
#66396) Summary: There has an issue when calling **torch.get_autocast_cpu_dtype** and **torch.get_autocast_gpu_dtype**: ``` >>> torch.get_autocast_gpu_dtype()==torch.half False >>> torch.get_autocast_cpu_dtype()==torch.bfloat16 False ``` but the expected results should be : ``` >>> torch.get_autocast_gpu_dtype()==torch.half True >>> torch.get_autocast_cpu_dtype()==torch.bfloat16 True ``` This PR is about fixing this issue. Pull Request resolved: #66396 Reviewed By: ejguan Differential Revision: D31541727 Pulled By: albanD fbshipit-source-id: 1a0fe070a82590ef2926a517bf48046c2633d168 (cherry picked from commit 822c085) Signed-off-by: Eli Uriegas <[email protected]>
seemethere
added a commit
that referenced
this pull request
Dec 10, 2021
…tocast_gpu_dtype (#66396) (#69620) Co-authored-by: XiaobingSuper <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There has an issue when calling torch.get_autocast_cpu_dtype and torch.get_autocast_gpu_dtype:
but the expected results should be :
This PR can fix #65786.