Skip to content

Refactor autograd package to separate Python dependencies. #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
colesbury merged 1 commit into from
Feb 14, 2017
Merged

Refactor autograd package to separate Python dependencies. #662

colesbury merged 1 commit into from
Feb 14, 2017

Conversation

@colesbury
Copy link
Member

@colesbury colesbury commented Jan 31, 2017

The core autograd Variable, Function, and Engine no longer depend on the
Python API. This let's us implement functions in C++. In the future, we
can also multithread engine and release the GIL for most of the
non-Python backwards.

For now, the only Function implemented in C++ is batch normalization.

The C++ API differs a bit from the Python API:

  • Function only represents either a "forward" or "backward" operation. This is to ease support for "double" backwards and simplify the API.
  • In C++, Function implementations operate on variables and return variables. Implementations are responsible for setting the creator appropriately.
  • Variable extends Function (for now) so that it can be stored in the previous_functions vector.

Most of the Python specific code is in python_xxx.cpp files. There is python_function.cpp for functions implemented in Python and python_native_function.cpp for functions implemented in C++ and exposed in Python.

@colesbury colesbury force-pushed the autograd branch 7 times, most recently from f2e7c33 to 6fcc925 Compare February 1, 2017 02:24
apaszke
apaszke suggested changes Feb 1, 2017
View reviewed changes
Copy link
Contributor

@apaszke apaszke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A style thing is that maybe we should unify the file names between autograd (all lowercase) and the main extension (camel case).

torch/csrc/DynamicTypes.cpp Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

setup.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

torch/csrc/autograd/engine.cpp Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

torch/csrc/autograd/engine.cpp Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

torch/csrc/autograd/engine.cpp Outdated

This comment was marked as off-topic.

Sign in to view

torch/csrc/cudnn/BatchNorm.cpp Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

torch/nn/functional.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

torch/multiprocessing/reductions.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

torch/csrc/autograd/variable.cpp Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

torch/autograd/variable.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@colesbury colesbury force-pushed the autograd branch 5 times, most recently from f06424a to 4a0494f Compare February 3, 2017 18:03
albanD
albanD reviewed Feb 5, 2017
View reviewed changes
torch/csrc/DynamicTypes.cpp Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@colesbury colesbury force-pushed the autograd branch 4 times, most recently from fb7aacb to 98bda34 Compare February 9, 2017 20:18
@apaszke apaszke closed this Feb 11, 2017
@apaszke apaszke reopened this Feb 11, 2017
apaszke
apaszke reviewed Feb 11, 2017
View reviewed changes
torch/autograd/variable.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

torch/csrc/ModuleSparse.cpp Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

torch/csrc/autograd/engine.cpp Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

torch/csrc/autograd/function.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

torch/csrc/autograd/functions/init.cpp Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

torch/csrc/autograd/function.h Outdated

This comment was marked as off-topic.

Sign in to view

torch/csrc/autograd/python_function.cpp Outdated

This comment was marked as off-topic.

Sign in to view

torch/csrc/autograd/python_function.h Outdated

This comment was marked as off-topic.

Sign in to view

torch/csrc/autograd/python_variable.cpp Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

torch/csrc/autograd/python_variable.cpp Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@apaszke apaszke mentioned this pull request Feb 12, 2017
Closed
@colesbury colesbury force-pushed the autograd branch 2 times, most recently from b2aad15 to 00f898d Compare February 13, 2017 21:59
@colesbury
Refactor autograd package to separate Python dependencies.
f69b105 
The core autograd Variable, Function, and Engine no longer depend on the
Python API. This let's us implement functions in C++. In the future, we
can also multithread engine and release the GIL for most of the
non-Python backwards.
@colesbury colesbury merged commit bd53030 into pytorch:master Feb 14, 2017
rohithkrn pushed a commit to rohithkrn/pytorch that referenced this pull request Jun 5, 2020
@jeffdaily
Merge pull request pytorch#662 from jithunnair-amd/ifu_20200527
57aef69 
IFU_20200527
KyleCZH pushed a commit to KyleCZH/pytorch that referenced this pull request Sep 20, 2021
@janeyx99
update package names for both wheel and conda for cross compiled arm64 (
d283c58 
pytorch#662)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD left review comments

+1 more reviewer

@apaszke apaszke apaszke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@colesbury @apaszke @albanD