Skip to content

Fix Windows ninja builds when MAX_JOBS is specified (#65444) #66155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
malfet merged 1 commit into from
Oct 5, 2021
Merged

Fix Windows ninja builds when MAX_JOBS is specified (#65444) #66155

malfet merged 1 commit into from
Oct 5, 2021

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Oct 5, 2021 •
edited
Loading

Summary:
Reported by cloudhan in #64733 (comment)

Fixes regression introduced by 047e682

cc malfet seemethere

Pull Request resolved: #65444

Reviewed By: dagitses, seemethere

Differential Revision: D31103260

Pulled By: malfet

fbshipit-source-id: 9d5454a64cb8a0b96264119cf16582cc5afed284

@malfet
Fix Windows ninja builds when MAX_JOBS is specified (pytorch#65444)
e348123 
Summary:
Reported by cloudhan in pytorch#64733 (comment)

Fixes regression introduced by pytorch@047e682

cc malfet seemethere

Pull Request resolved: pytorch#65444

Reviewed By: dagitses, seemethere

Differential Revision: D31103260

Pulled By: malfet

fbshipit-source-id: 9d5454a64cb8a0b96264119cf16582cc5afed284
@pytorch-probot
Copy link

pytorch-probot bot commented Oct 5, 2021

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/malfet/pytorch/blob/e348123c0b80a17c1b7f920dbeaad3cf155baf18/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default

Workflows Labels (bold enabled) Status
Triggered Workflows
linux-bionic-py3.6-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/noarch, ciflow/xla ✅ triggered
linux-bionic-py3.8-gcc9-coverage ciflow/all, ciflow/coverage, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-cuda11.3-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-py3.6-gcc7-bazel-test ciflow/all, ciflow/bazel, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
win-vs2019-cpu-py3 ciflow/all, ciflow/cpu, ciflow/default, ciflow/win ✅ triggered
win-vs2019-cuda11.3-py3 ciflow/all, ciflow/cuda, ciflow/default, ciflow/win ✅ triggered
Skipped Workflows
libtorch-linux-xenial-cuda10.2-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux 🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux 🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow 🚫 skipped
linux-xenial-cuda10.2-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow 🚫 skipped
parallelnative-linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux 🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-xenial-cuda11.1-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-win-vs2019-cuda11.1-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped
puretorch-linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux 🚫 skipped
win-vs2019-cuda10.2-py3 ciflow/all, ciflow/cuda, ciflow/win 🚫 skipped

You can add a comment to the PR and tag @pytorchbot with the following commands: 
# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 5, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit e348123 (more details on the Dr. CI page):

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build linux-bionic-py3.8-gcc9-coverage / test (default, 1, 2, linux.2xlarge) (1/2)

Step: "Unknown" (full log | diagnosis details | 🔁 rerun)

2021-10-05T19:16:29.0871417Z CONTINUE_THROUGH_ERROR: false 
2021-10-05T19:16:29.0864600Z   CUSTOM_TEST_ARTIFACT_BUILD_DIR: build/custom_test_artifacts
2021-10-05T19:16:29.0865273Z   ALPINE_IMAGE: 308535385114.dkr.ecr.us-east-1.amazonaws.com/tool/alpine
2021-10-05T19:16:29.0865798Z   PR_LABELS: []
2021-10-05T19:16:29.0866999Z   GITHUB_TOKEN: ***
2021-10-05T19:16:29.0867964Z   DOCKER_IMAGE: 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-bionic-py3.8-gcc9:74e757e8b0cf750d2f91db6aa4c29640abce32ea
2021-10-05T19:16:29.0869429Z   JOB_BASE_NAME: linux-bionic-py3.8-gcc9-coverage-test
2021-10-05T19:16:29.0870014Z   TEST_CONFIG: default
2021-10-05T19:16:29.0870327Z   SHARD_NUMBER: 1
2021-10-05T19:16:29.0870644Z   NUM_TEST_SHARDS: 2
2021-10-05T19:16:29.0871019Z   PYTORCH_IGNORE_DISABLED_ISSUES: 
2021-10-05T19:16:29.0871417Z   CONTINUE_THROUGH_ERROR: false
2021-10-05T19:16:29.0871759Z   SHM_SIZE: 1g
2021-10-05T19:16:29.0872036Z   PR_NUMBER: 66155
2021-10-05T19:16:29.0872320Z   IS_GHA: 1
2021-10-05T19:16:29.0872697Z   CIRCLE_BRANCH: pull/66155
2021-10-05T19:16:29.0873040Z   CIRCLE_PR_NUMBER: 66155
2021-10-05T19:16:29.0873548Z   CIRCLE_SHA1: e348123c0b80a17c1b7f920dbeaad3cf155baf18
2021-10-05T19:16:29.0874075Z   AWS_DEFAULT_REGION: us-east-1
2021-10-05T19:16:29.0874436Z ##[endgroup]
2021-10-05T19:16:41.4666015Z Processing ./dist/torch-1.10.0a0+git7bdd053-cp38-cp38-linux_x86_64.whl
2021-10-05T19:16:41.4930475Z Requirement already satisfied: typing-extensions in /opt/conda/lib/python3.8/site-packages (from torch==1.10.0a0+git7bdd053) (3.10.0.2)

See GitHub Actions build linux-xenial-py3.6-gcc5.4 / test (backwards_compat, 1, 1, linux.2xlarge) (2/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2021-10-05T19:14:40.0885508Z The PR is introduc...m to confirm whether this change is wanted or not. 
2021-10-05T19:14:40.0872103Z processing existing schema:  alltoall_base(__torch__.torch.classes.dist_c10d.ProcessGroup _0, Tensor _1, Tensor _2, int[] _3, int[] _4) -> (__torch__.torch.classes.dist_c10d.Work _0)
2021-10-05T19:14:40.0873497Z processing existing schema:  alltoall(__torch__.torch.classes.dist_c10d.ProcessGroup _0, Tensor[] _1, Tensor[] _2) -> (__torch__.torch.classes.dist_c10d.Work _0)
2021-10-05T19:14:40.0874801Z processing existing schema:  send(__torch__.torch.classes.dist_c10d.ProcessGroup _0, Tensor[] _1, int _2, int _3) -> (__torch__.torch.classes.dist_c10d.Work _0)
2021-10-05T19:14:40.0876071Z processing existing schema:  recv(__torch__.torch.classes.dist_c10d.ProcessGroup _0, Tensor[] _1, int _2, int _3) -> (__torch__.torch.classes.dist_c10d.Work _0)
2021-10-05T19:14:40.0877385Z processing existing schema:  recv_anysource(__torch__.torch.classes.dist_c10d.ProcessGroup _0, Tensor[] _1, int _2) -> (__torch__.torch.classes.dist_c10d.Work _0)
2021-10-05T19:14:40.0878649Z processing existing schema:  barrier(__torch__.torch.classes.dist_c10d.ProcessGroup _0) -> (__torch__.torch.classes.dist_c10d.Work _0)
2021-10-05T19:14:40.0879694Z processing existing schema:  __init__(__torch__.torch.classes.dist_c10d.frontend _0) -> (NoneType _0)
2021-10-05T19:14:40.0881113Z processing existing schema:  new_process_group_helper(__torch__.torch.classes.dist_c10d.frontend _0, int _1, int _2, int[] _3, str _4, __torch__.torch.classes.dist_c10d.Store _5, str? _6, int _7) -> (__torch__.torch.classes.dist_c10d.ProcessGroup _0)
2021-10-05T19:14:40.0882657Z processing existing schema:  get_process_group_by_name(__torch__.torch.classes.dist_c10d.frontend _0, str _1) -> (__torch__.torch.classes.dist_c10d.ProcessGroup _0)
2021-10-05T19:14:40.0884357Z processing existing schema:  get_name_of_process_group(__torch__.torch.classes.dist_c10d.frontend _0, __torch__.torch.classes.dist_c10d.ProcessGroup _1) -> (str _0)
2021-10-05T19:14:40.0885508Z The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
2021-10-05T19:14:40.0886112Z 
2021-10-05T19:14:40.0886382Z Broken ops: [
2021-10-05T19:14:40.0887063Z 	aten::fft_ihfftn(Tensor self, int[1]? s=None, int[1]? dim=None, str? norm=None) -> (Tensor)
2021-10-05T19:14:40.0888028Z 	aten::fft_ihfftn.out(Tensor self, int[1]? s=None, int[1]? dim=None, str? norm=None, *, Tensor(a!) out) -> (Tensor(a!))
2021-10-05T19:14:40.0888872Z 	aten::special_softmax(Tensor self, int dim, int? dtype=None) -> (Tensor)
2021-10-05T19:14:40.0889643Z 	aten::fft_hfftn(Tensor self, int[1]? s=None, int[1]? dim=None, str? norm=None) -> (Tensor)
2021-10-05T19:14:40.0890497Z 	aten::fft_hfftn.out(Tensor self, int[1]? s=None, int[1]? dim=None, str? norm=None, *, Tensor(a!) out) -> (Tensor(a!))
2021-10-05T19:14:40.0891352Z 	aten::fft_ihfft2(Tensor self, int[1]? s=None, int[1] dim=[-2, -1], str? norm=None) -> (Tensor)
2021-10-05T19:14:40.0892197Z 	aten::fft_ihfft2.out(Tensor self, int[1]? s=None, int[1] dim=[-2, -1], str? norm=None, *, Tensor(a!) out) -> (Tensor(a!))
2021-10-05T19:14:40.0893052Z 	aten::fft_hfft2(Tensor self, int[1]? s=None, int[1] dim=[-2, -1], str? norm=None) -> (Tensor)

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See GitHub Actions build linux-xenial-py3.6-gcc5.4 / build-docs (cpp) (1/1)

Step: "Unknown" (full log | diagnosis details | 🔁 rerun) ❄️

2021-10-05T19:16:15.0243434Z E: Failed to fetch...: /etc/ssl/certs/ca-certificates.crt CRLfile: none 
2021-10-05T19:16:14.9832681Z 
2021-10-05T19:16:14.9832977Z Reading package lists... 99%
2021-10-05T19:16:14.9833205Z 
2021-10-05T19:16:15.0018313Z Reading package lists... 99%
2021-10-05T19:16:15.0018588Z 
2021-10-05T19:16:15.0018884Z Reading package lists... Done
2021-10-05T19:16:15.0019128Z 
2021-10-05T19:16:15.0239983Z W: The repository 'https://deb.nodesource.com/node_12.x xenial Release' does not have a Release file.
2021-10-05T19:16:15.0241031Z N: Data from such a repository can't be authenticated and is therefore potentially dangerous to use.
2021-10-05T19:16:15.0242160Z N: See apt-secure(8) manpage for repository creation and user configuration details.
2021-10-05T19:16:15.0243434Z E: Failed to fetch https://deb.nodesource.com/node_12.x/dists/xenial/main/source/Sources  server certificate verification failed. CAfile: /etc/ssl/certs/ca-certificates.crt CRLfile: none
2021-10-05T19:16:15.0244491Z E: Some index files failed to download. They have been ignored, or old ones used instead.
2021-10-05T19:16:15.0320811Z 
2021-10-05T19:16:15.0757038Z Reading package lists... 0%
2021-10-05T19:16:15.0757490Z 
2021-10-05T19:16:15.0862266Z Reading package lists... 0%
2021-10-05T19:16:15.0862763Z 
2021-10-05T19:16:15.1310819Z Reading package lists... 1%
2021-10-05T19:16:15.1311327Z 
2021-10-05T19:16:15.1311852Z Reading package lists... 8%
2021-10-05T19:16:15.1312276Z
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@malfet malfet mentioned this pull request Oct 5, 2021
Closed
@malfet malfet merged commit 4731f33 into pytorch:release/1.10 Oct 5, 2021
@malfet malfet deleted the malfet/cp-65444 branch October 5, 2021 19:03
@WBobby WBobby mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@malfet @facebook-github-bot