Skip to content

[PyTorch] Add IValue::toTupleRef() #65504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
swolchok wants to merge 21 commits into from
Closed

[PyTorch] Add IValue::toTupleRef() #65504

swolchok wants to merge 21 commits into from

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented Sep 23, 2021 •
edited
Loading

Stack from ghstack:

We should be able to borrow a Tuple from an IValue without incurring refcount bumps.

Differential Revision: D31130570

@swolchok
[PyTorch] Add IValue::toTupleRef()
5e2e15b 
We should be able to borrow a Tuple from an IValue without incurring refcount bumps.

Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/)

[ghstack-poisoned]
@pytorch-probot
Copy link

pytorch-probot bot commented Sep 23, 2021 •
edited
Loading

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/35ce5f93cf2fb0fd84642a2014e12793b526d35f/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default

Workflows Labels (bold enabled) Status
Triggered Workflows
linux-bionic-py3.6-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/noarch, ciflow/xla ✅ triggered
linux-vulkan-bionic-py3.6-clang9 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/vulkan ✅ triggered
linux-xenial-cuda11.3-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-py3-clang5-mobile-build ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile ✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-dynamic ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile ✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static ciflow/all, ciflow/default, ciflow/linux, ciflow/mobile ✅ triggered
linux-xenial-py3.6-clang7-asan ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/sanitizers ✅ triggered
linux-xenial-py3.6-clang7-onnx ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux, ciflow/onnx ✅ triggered
linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-py3.6-gcc7 ciflow/all, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
linux-xenial-py3.6-gcc7-bazel-test ciflow/all, ciflow/bazel, ciflow/cpu, ciflow/default, ciflow/linux ✅ triggered
win-vs2019-cpu-py3 ciflow/all, ciflow/cpu, ciflow/default, ciflow/win ✅ triggered
win-vs2019-cuda11.3-py3 ciflow/all, ciflow/cuda, ciflow/default, ciflow/win ✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux 🚫 skipped
docker-builds ciflow/all 🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux 🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux 🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/slow 🚫 skipped
linux-xenial-py3-clang5-mobile-code-analysis ciflow/all, ciflow/linux, ciflow/mobile 🚫 skipped
parallelnative-linux-xenial-py3.6-gcc5.4 ciflow/all, ciflow/cpu, ciflow/linux 🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/libtorch, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled, ciflow/slow, ciflow/slow-gradcheck 🚫 skipped
periodic-linux-xenial-cuda11.1-py3.6-gcc7 ciflow/all, ciflow/cuda, ciflow/linux, ciflow/scheduled 🚫 skipped
periodic-win-vs2019-cuda11.1-py3 ciflow/all, ciflow/cuda, ciflow/scheduled, ciflow/win 🚫 skipped

You can add a comment to the PR and tag @pytorchbot with the following commands: 
# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Sep 23, 2021
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 23, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 35ce5f9 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

swolchok added a commit that referenced this pull request Sep 23, 2021
@swolchok
[PyTorch] Add IValue::toTupleRef()
39cb39b 
We should be able to borrow a Tuple from an IValue without incurring refcount bumps.

Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/)

ghstack-source-id: 138792846
Pull Request resolved: #65504
@swolchok swolchok mentioned this pull request Sep 23, 2021
Closed
@swolchok
Update on "[PyTorch] Add IValue::toTupleRef()"
2a2dd97 
We should be able to borrow a Tuple from an IValue without incurring refcount bumps.

Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/)

[ghstack-poisoned]
This was referenced Sep 23, 2021
Closed
Closed
Closed
Closed
@swolchok
Update on "[PyTorch] Add IValue::toTupleRef()"
e1a6fd0 
We should be able to borrow a Tuple from an IValue without incurring refcount bumps.

Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/)

[ghstack-poisoned]
@swolchok
Update on "[PyTorch] Add IValue::toTupleRef()"
54bbedb 
We should be able to borrow a Tuple from an IValue without incurring refcount bumps.

Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/)

[ghstack-poisoned]
@swolchok
Update on "[PyTorch] Add IValue::toTupleRef()"
e8a4ec6 
We should be able to borrow a Tuple from an IValue without incurring refcount bumps.

Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/)

[ghstack-poisoned]
@swolchok
Update on "[PyTorch] Add IValue::toTupleRef()"
d8b2ac8 
We should be able to borrow a Tuple from an IValue without incurring refcount bumps.

Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/)

[ghstack-poisoned]
@swolchok
Update on "[PyTorch] Add IValue::toTupleRef()"
1ed830b 
We should be able to borrow a Tuple from an IValue without incurring refcount bumps.

Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/)

[ghstack-poisoned]
@swolchok
Update on "[PyTorch] Add IValue::toTupleRef()"
122567f 
We should be able to borrow a Tuple from an IValue without incurring refcount bumps.

Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/)

[ghstack-poisoned]
@swolchok
Update on "[PyTorch] Add IValue::toTupleRef()"
52456b8 
We should be able to borrow a Tuple from an IValue without incurring refcount bumps.

Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/)

[ghstack-poisoned]
This was referenced Oct 5, 2021
Closed
Closed
@swolchok
Update on "[PyTorch] Add IValue::toTupleRef()"
c53f3be 
We should be able to borrow a Tuple from an IValue without incurring refcount bumps.

Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/)

[ghstack-poisoned]
@swolchok
Update on "[PyTorch] Add IValue::toTupleRef()"
a392cb9 
We should be able to borrow a Tuple from an IValue without incurring refcount bumps.

Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/)

[ghstack-poisoned]
@swolchok
Update on "[PyTorch] Add IValue::toTupleRef()"
9d24d39 
We should be able to borrow a Tuple from an IValue without incurring refcount bumps.

Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/)

[ghstack-poisoned]
@swolchok
Update on "[PyTorch] Add IValue::toTupleRef()"
8da3d53 
We should be able to borrow a Tuple from an IValue without incurring refcount bumps.

Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/)

[ghstack-poisoned]
@swolchok
give up on making TupleElements noncopyable on "[PyTorch] Add IValue:…
9acff7c 
…:toTupleRef()"

We should be able to borrow a Tuple from an IValue without incurring refcount bumps.

Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/)

[ghstack-poisoned]
@swolchok
Update on "[PyTorch] Add IValue::toTupleRef()"
e2c2c1e 
We should be able to borrow a Tuple from an IValue without incurring refcount bumps.

Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/)

[ghstack-poisoned]
@swolchok
Update on "[PyTorch] Add IValue::toTupleRef()"
db3e10a 
We should be able to borrow a Tuple from an IValue without incurring refcount bumps.

Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/)

[ghstack-poisoned]
@swolchok
Update on "[PyTorch] Add IValue::toTupleRef()"
3ce6445 
We should be able to borrow a Tuple from an IValue without incurring refcount bumps.

Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/)

[ghstack-poisoned]
swolchok added a commit that referenced this pull request Oct 18, 2021
@swolchok
[PyTorch] Add IValue::toTupleRef()
369756a 
Pull Request resolved: #65504

We should be able to borrow a Tuple from an IValue without incurring refcount bumps.
ghstack-source-id: 140913605

Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/)
@swolchok
Update on "[PyTorch] Add IValue::toTupleRef()"
e37c852 
We should be able to borrow a Tuple from an IValue without incurring refcount bumps.

Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/)

[ghstack-poisoned]
@swolchok
Update on "[PyTorch] Add IValue::toTupleRef()"
a6dbd99 
We should be able to borrow a Tuple from an IValue without incurring refcount bumps.

Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/)

[ghstack-poisoned]
@swolchok
Update on "[PyTorch] Add IValue::toTupleRef()"
d475c91 
We should be able to borrow a Tuple from an IValue without incurring refcount bumps.

Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/)

[ghstack-poisoned]
@swolchok
Update on "[PyTorch] Add IValue::toTupleRef()"
35ce5f9 
We should be able to borrow a Tuple from an IValue without incurring refcount bumps.

Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/)

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Nov 2, 2021
@swolchok @facebook-github-bot
[PyTorch] Add IValue::toTupleRef() (#65504)
d9bac7c 
Summary:
Pull Request resolved: #65504

We should be able to borrow a Tuple from an IValue without incurring refcount bumps.
ghstack-source-id: 142065833

Test Plan:
Added test coverage.

Profiled static runtime on the local_ro net for ctr_mobile_feed. Inclusive time spent in VarTupleUnpack decreased about 0.3%, which roughly matches with the 0.36% of runtime that was previously spent in IValue::toTuple().

Reviewed By: hlu1

Differential Revision: D31130570

fbshipit-source-id: afa14f46445539e449068fd908d547b8da7f402c
@janeyx99 janeyx99 mentioned this pull request Nov 2, 2021
Closed
@facebook-github-bot facebook-github-bot deleted the gh/swolchok/328/head branch December 3, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok @facebook-github-bot