Skip to content

[fx2trt] fix transpose unittest #65481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
842974287 wants to merge 1 commit into from
Closed

[fx2trt] fix transpose unittest #65481

842974287 wants to merge 1 commit into from

Conversation

@842974287
Copy link
Contributor

@842974287 842974287 commented Sep 22, 2021

Summary: Previous we have acc_ops.transpose but after a recent diff torch.transpose is mapped to acc_ops.permute. Here we clean up the fx2trt unittest for transpose and add support for negative indices in permute.

Differential Revision: D31115280

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 22, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 76972c4 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build linux-bionic-py3.6-clang9 / test (noarch, 1, 1, linux.2xlarge) (1/1)

Step: "Unknown" (full log | diagnosis details | 🔁 rerun)

2021-09-22T23:10:09.1559955Z test_add_done_ca...arg() takes 0 positional arguments but 1 was given 
2021-09-22T23:10:09.1540290Z   /opt/conda/lib/python3.6/unittest/suite.py(122): run
2021-09-22T23:10:09.1540793Z   /opt/conda/lib/python3.6/unittest/suite.py(84): __call__
2021-09-22T23:10:09.1541696Z   /opt/conda/lib/python3.6/site-packages/xmlrunner/runner.py(66): run
2021-09-22T23:10:09.1542266Z   /opt/conda/lib/python3.6/unittest/main.py(256): runTests
2021-09-22T23:10:09.1542773Z   /opt/conda/lib/python3.6/unittest/main.py(95): __init__
2021-09-22T23:10:09.1543509Z   /opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py(605): run_tests
2021-09-22T23:10:09.1544161Z   test_futures.py(329): <module>
2021-09-22T23:10:09.1544405Z 
2021-09-22T23:10:09.1544656Z ok (0.002s)
2021-09-22T23:10:09.1554089Z   test_add_done_callback_maintains_callback_order (__main__.TestFuture) ... ok (0.002s)
2021-09-22T23:10:09.1559955Z   test_add_done_callback_no_arg_error_is_ignored (__main__.TestFuture) ... [E pybind_utils.h:201] Got the following error when running the callback: TypeError: no_arg() takes 0 positional arguments but 1 was given
2021-09-22T23:10:09.1560944Z ok (0.001s)
2021-09-22T23:10:09.1568899Z   test_add_done_callback_simple (__main__.TestFuture) ... ok (0.001s)
2021-09-22T23:10:09.1594548Z   test_chained_then (__main__.TestFuture) ... ok (0.003s)
2021-09-22T23:10:09.2614354Z   test_collect_all (__main__.TestFuture) ... ok (0.102s)
2021-09-22T23:10:09.2621186Z   test_done (__main__.TestFuture) ... ok (0.001s)
2021-09-22T23:10:09.2633390Z   test_done_exception (__main__.TestFuture) ... ok (0.001s)
2021-09-22T23:10:09.2648179Z   test_interleaving_then_and_add_done_callback_maintains_callback_order (__main__.TestFuture) ... ok (0.001s)
2021-09-22T23:10:09.2657294Z   test_interleaving_then_and_add_done_callback_propagates_error (__main__.TestFuture) ... [E pybind_utils.h:201] Got the following error when running the callback: ValueError: Expected error
2021-09-22T23:10:09.2658000Z 
2021-09-22T23:10:09.2658350Z At:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 22, 2021

This pull request was exported from Phabricator. Differential Revision: D31115280

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 22, 2021

This pull request was exported from Phabricator. Differential Revision: D31115280

@842974287 @facebook-github-bot
[fx2trt] fix transpose unittest (pytorch#65481)
76972c4 
Summary:
Pull Request resolved: pytorch#65481

Previous we have `acc_ops.transpose` but after a recent diff `torch.transpose` is mapped to `acc_ops.permute`. Here we clean up the fx2trt unittest for transpose and add support for negative indices in permute.

Reviewed By: wushirong

Differential Revision: D31115280

fbshipit-source-id: 6d7c7eae50bb4c5773821e514661dd86f353e87d
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 22, 2021

This pull request was exported from Phabricator. Differential Revision: D31115280

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 23, 2021

This pull request has been merged in fccaa4a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed fb-exported Merged module: fx

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@842974287 @facebook-github-bot