Fix Windows ninja builds when MAX_JOBS is specified #65444
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 708d689 (more details on the Dr. CI page):
🕵️ 3 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
 Lint / clang-format |
Run clang-format | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group.
Contributor
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
malfet
referenced
this pull request
Sep 22, 2021
Summary: Pull Request resolved: #64733 The previous implementation was wrong when CPU scheduling affinity is set. In fact, it is still wrong if Ninja is not being used. When there is CPU scheduling affinity set, the number of processors available on the system likely exceeds the number of processors that are usable to the build. We ought to use `len(os.sched_getaffinity(0))` to determine the effective parallelism. This change is more minimal and instead just delegates to Ninja (which handles this correctly) when it is used. Test Plan: I verified this worked as correctly using Ninja on a 96-core machine with 24 cores available for scheduling by checking: * the cmake command did not specify "-j" * the number of top-level jobs in top/pstree never exceeded 26 (24 + 2) And I verified we get the legacy behavior by specifying USE_NINJA=0 on the build. Reviewed By: jbschlosser, driazati Differential Revision: D30968796 Pulled By: dagitses fbshipit-source-id: 29547dd378fea793957bcc2f7d52d5def1ecace2
malfet
added
module: build
Codecov Report
@@ Coverage Diff @@
## master #65444 +/- ##
==========================================
- Coverage 66.38% 66.37% -0.01%
==========================================
Files 739 739
Lines 94295 94295
==========================================
- Hits 62594 62593 -1
- Misses 31701 31702 +1 |
dagitses
approved these changes
Sep 22, 2021
tools/test/test_cmake.py
Outdated
| (( None, False, False), ['-j', '13']), # noqa: E201,E241 | ||
| (( '6', True, True), ['-j', '6']), # noqa: E201,E241 | ||
| (( None, True, True), None), # noqa: E201,E241 | ||
| (( '5', False, True), ['/p:CL_MPCount=5']), # noqa: E201,E241 |
Collaborator
There was a problem hiding this comment.
nit: if you change this to "11" it will line up more nicely with the value below
Contributor
|
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
seemethere
approved these changes
Sep 22, 2021
Contributor
malfet
added a commit
to malfet/pytorch
that referenced
this pull request
Oct 5, 2021
Summary: Reported by cloudhan in pytorch#64733 (comment) Fixes regression introduced by pytorch@047e682 cc malfet seemethere Pull Request resolved: pytorch#65444 Reviewed By: dagitses, seemethere Differential Revision: D31103260 Pulled By: malfet fbshipit-source-id: 9d5454a64cb8a0b96264119cf16582cc5afed284
This was referenced Oct 5, 2021
malfet
added a commit
that referenced
this pull request
Oct 5, 2021
Summary: Reported by cloudhan in #64733 (comment) Fixes regression introduced by 047e682 cc malfet seemethere Pull Request resolved: #65444 Reviewed By: dagitses, seemethere Differential Revision: D31103260 Pulled By: malfet fbshipit-source-id: 9d5454a64cb8a0b96264119cf16582cc5afed284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by @cloudhan in #64733 (comment)
Fixes regression introduced by 047e682
cc @malfet @seemethere