.github: Enable with-ssh for Windows #63440
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eli Uriegas <[email protected]> [ghstack-poisoned]
seemethere
requested review from
driazati,
janeyx99 and
zhouzhuojie
as code owners
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 0625350 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
seemethere
added a commit
that referenced
this pull request
Aug 17, 2021
Signed-off-by: Eli Uriegas <[email protected]> ghstack-source-id: 8ada5f4 Pull Request resolved: #63440
seemethere
commented
Aug 17, 2021
| if-no-files-found: error | ||
| name: ${{ env.BUILD_ENVIRONMENT }} | ||
| path: C:\${{ github.run_id }}\build-results | ||
| !{{ wait_and_kill_ssh() }} |
Member
Author
There was a problem hiding this comment.
This is an experiment with jinja2 macros, not entirely sure I like it since it makes it a bit harder to read but I guess they work 🤷🏽♂️
6 tasks
zhouzhuojie
approved these changes
Aug 17, 2021
Signed-off-by: Eli Uriegas <[email protected]> [ghstack-poisoned]
seemethere
added a commit
that referenced
this pull request
Aug 18, 2021
Signed-off-by: Eli Uriegas <[email protected]> ghstack-source-id: 3df689a Pull Request resolved: #63440 Signed-off-by: Eli Uriegas <[email protected]>
Signed-off-by: Eli Uriegas <[email protected]> [ghstack-poisoned]
seemethere
added a commit
that referenced
this pull request
Aug 24, 2021
Signed-off-by: Eli Uriegas <[email protected]> ghstack-source-id: 959212f Pull Request resolved: #63440 Signed-off-by: Eli Uriegas <[email protected]>
Signed-off-by: Eli Uriegas <[email protected]> [ghstack-poisoned]
seemethere
added a commit
that referenced
this pull request
Aug 24, 2021
Signed-off-by: Eli Uriegas <[email protected]> ghstack-source-id: 8a02b98 Pull Request resolved: #63440 Signed-off-by: Eli Uriegas <[email protected]>
Member
Author
|
@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
janeyx99
approved these changes
Aug 24, 2021
zhouzhuojie
approved these changes
Aug 24, 2021
malfet
approved these changes
Aug 24, 2021
Contributor
|
@seemethere merged this pull request in 865d127. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Signed-off-by: Eli Uriegas [email protected]
Differential Revision: D30521460