Add Github action to upload full source releases #63022
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those release tarballs include the submodules. The action is run on every tag, master-branch push but will not upload anything. This makes sure nothing is broken when an actual release happens. On created releases the action runs and uploads the tarball
Flamefire
requested review from
driazati,
janeyx99,
seemethere and
zhouzhuojie
as code owners
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 0f9e866 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
seemethere
approved these changes
Aug 10, 2021
Member
seemethere
left a comment
seemethere
left a comment
There was a problem hiding this comment.
LGTM, might also need a pull_request trigger for easier testing as well
seemethere
added
module: ci
Flamefire
force-pushed
the
release-on-gha
branch
from
64fe057 to
d9caf1e
Compare
Contributor
|
@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
@seemethere merged this pull request in 51a67d3. |
alanwaketan
pushed a commit
that referenced
this pull request
Aug 17, 2021
Summary: Those release tarballs include the submodules. The action is run on every tag, master-branch push but will not upload anything. This makes sure nothing is broken when an actual release happens. On created releases the action runs and uploads the tarball Fixes #62708 As I don't have access rights here and testing is obviously hard (as a new release needs to be published), I set up a test at https://github.com/Flamefire/pytorch/releases/tag/testtag See also the run(s) at https://github.com/Flamefire/pytorch/actions/workflows/create_release.yml Pull Request resolved: #63022 Reviewed By: saketh-are Differential Revision: D30256253 Pulled By: seemethere fbshipit-source-id: ab5fe131452de14ae3768b91c221e68c536cb3aa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those release tarballs include the submodules.
The action is run on every tag, master-branch push but will not upload anything.
This makes sure nothing is broken when an actual release happens.
On created releases the action runs and uploads the tarball
Fixes #62708
As I don't have access rights here and testing is obviously hard (as a new release needs to be published), I set up a test at https://github.com/Flamefire/pytorch/releases/tag/testtag
See also the run(s) at https://github.com/Flamefire/pytorch/actions/workflows/create_release.yml