Add other Linux GPU auxiliary test jobs #61055
Conversation
💊 CI failures summary and remediationsAs of commit a15e5e8 (more details on the Dr. CI page and at hud.pytorch.org/pr/61055): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 Preview docs built from this PR This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
question for reviewers: any idea why the |
| test_runner_type: str, | ||
| on_pull_request: bool = False, | ||
| enable_doc_jobs: bool = False, | ||
| enable_jit_legacy_test: YamlShellBool = "''", |
There was a problem hiding this comment.
What is the advantage of using YamlShellBool with '' and 1s instead of just having Trues/Falses with bools? Is it for better compat between shell and script?
There was a problem hiding this comment.
Is it for better compat between shell and script?
Yeah exactly; this variable gets set as an environment variable, so it's easier for both shell and Python scripts to consume it if false is represented as the empty string.
| IN_PULL_REQUEST=${CIRCLE_PULL_REQUEST:-} | ||
|
|
||
| if [[ "$BUILD_ENVIRONMENT" == *-slow-* ]]; then | ||
| if [[ "$BUILD_ENVIRONMENT" == *-slow-* || $TEST_CONFIG == 'slow' ]]; then |
There was a problem hiding this comment.
shellscript noob q:
what's the difference between double quoted variable "$BLA", bracketed "${BLA}" and naked $BLA here?
i am sensing it might be relate to macos/linux convention but i dunno why there's so much inconsistent in these if statementss
There was a problem hiding this comment.
there's no difference between using quotes vs not within [[ double brackets ]], which is why shellcheck doesn't complain here; also the curly braces are basically never necessary, so idk why people are using them in general here
|
@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
4 participants
jit_legacynogpu_NO_AVXnogpu_NO_AVX2slowTest plan:
CI. Example run: https://github.com/pytorch/pytorch/actions/runs/1013240987