-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Migrate pytorch-linux-bionic-py3.8-gcc9-coverage to GHA #61050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate pytorch-linux-bionic-py3.8-gcc9-coverage to GHA #61050
Conversation
💊 CI failures summary and remediationsAs of commit 0021e78 (more details on the Dr. CI page and at hud.pytorch.org/pr/61050): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 Preview docs built from this PR This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
| DOCKER_REGISTRY = "308535385114.dkr.ecr.us-east-1.amazonaws.com" | ||
|
|
||
| GITHUB_DIR = Path(__file__).parent.parent | ||
| GITHUB_DIR = Path(__file__).resolve().parent.parent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolve is required on Ubuntu (and maybe some other Linux distros).
| ("gcc", [ | ||
| ("9", [ | ||
| ("3.8", [ | ||
| ("coverage", [ | ||
| (True, [ | ||
| ("shard_test", [XImportant(True)]), | ||
| ]), | ||
| ]), | ||
| ]), | ||
| ]), | ||
| ]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines were manually removed & then regenerate.sh was run to create config.yml.
samestep
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you! @pytorch/pytorch-dev-infra just to check, are we cool with enabling this in GHA and disabling it in CircleCI in the same PR?
|
@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Is there a before/after codecov result comparison done for this PR? |
Fixes #59166
pytorch-linux-bionic-py3.8-gcc9-coveragebuild & tests can be run onlinux.2xlargeinstances on GHA,which have AVX512 support.
Thanks
cc @malfet @seemethere @samestep @zhouzhuojie