Skip to content

Conversation

@imaginary-person
Copy link
Contributor

@imaginary-person imaginary-person commented Jun 30, 2021

Fixes #59166

pytorch-linux-bionic-py3.8-gcc9-coverage build & tests can be run on linux.2xlarge instances on GHA,
which have AVX512 support.

Thanks

cc @malfet @seemethere @samestep @zhouzhuojie

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 30, 2021

💊 CI failures summary and remediations

As of commit 0021e78 (more details on the Dr. CI page and at hud.pytorch.org/pr/61050):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


Preview docs built from this PR

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

DOCKER_REGISTRY = "308535385114.dkr.ecr.us-east-1.amazonaws.com"

GITHUB_DIR = Path(__file__).parent.parent
GITHUB_DIR = Path(__file__).resolve().parent.parent
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve is required on Ubuntu (and maybe some other Linux distros).

Comment on lines -83 to -93
("gcc", [
("9", [
("3.8", [
("coverage", [
(True, [
("shard_test", [XImportant(True)]),
]),
]),
]),
]),
]),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines were manually removed & then regenerate.sh was run to create config.yml.

@imaginary-person imaginary-person marked this pull request as ready for review June 30, 2021 17:09
@imaginary-person imaginary-person changed the title Move pytorch-linux-bionic-py3.8-gcc9-coverage to GHA Migrate pytorch-linux-bionic-py3.8-gcc9-coverage to GHA Jun 30, 2021
Copy link
Contributor

@samestep samestep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you! @pytorch/pytorch-dev-infra just to check, are we cool with enabling this in GHA and disabling it in CircleCI in the same PR?

@facebook-github-bot
Copy link
Contributor

@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@samestep merged this pull request in dace860.

@walterddr
Copy link
Contributor

Is there a before/after codecov result comparison done for this PR?
I've been looking into the codecov drop between 5bc28c8...03b5a22 and it seems like this one might've been related. is there a codecov report generated for this PR that I can download and take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running some CI tests with xlarge resource_class VMs for testing AVX512 support

5 participants