Add bazel actions workflow #61039
Closed
Add bazel actions workflow #61039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit 17c08e8 (more details on the Dr. CI page and at hud.pytorch.org/pr/61039): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 Preview docs built from this PR This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
71 tasks
Codecov Report
@@ Coverage Diff @@
## gh/rsemenov/1/base #61039 +/- ##
======================================================
+ Coverage 76.25% 76.26% +0.01%
======================================================
Files 2062 2062
Lines 205602 205602
======================================================
+ Hits 156784 156805 +21
+ Misses 48818 48797 -21 |
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
- Added a new template for bazel GH Actions workflow - Simplified the workflow based on @malfet's suggestion by combining build and test jobs into one as we only run a small subset of tests for bazel - Tested the run to make sure it succeeds - Build step takes 4 minutes, test step takes 7 minutes The downside of this approach is that I duplicated some of the jobs in a new template file. Alternative solution would be to use something like this https://jinja.palletsprojects.com/en/3.0.x/templates/#template-inheritance, however, that is better to be done in a separate PR as linux and windows workflows would need to be changed. Another solution is to use a bunch of if else statements in a linux workflow template to accommodate bazel build as part of it, but this seems not as clean as template inheritance with jinja. [ghstack-poisoned]
malfet
approved these changes
Jul 6, 2021
walterddr
reviewed
Jul 6, 2021
Co-authored-by: Rong Rong <[email protected]>
malfet
reviewed
Jul 6, 2021
- Added a new template for bazel GH Actions workflow - Simplified the workflow based on @malfet's suggestion by combining build and test jobs into one as we only run a small subset of tests for bazel - Tested the run to make sure it succeeds - Build step takes 4 minutes, test step takes 7 minutes The downside of this approach is that I duplicated some of the jobs in a new template file. Alternative solution would be to use something like this https://jinja.palletsprojects.com/en/3.0.x/templates/#template-inheritance, however, that is better to be done in a separate PR as linux and windows workflows would need to be changed. Another solution is to use a bunch of if else statements in a linux workflow template to accommodate bazel build as part of it, but this seems not as clean as template inheritance with jinja. Here is a link to the latest bazel run with this change https://github.com/pytorch/pytorch/actions/runs/1004656584 [ghstack-poisoned]
- Added a new template for bazel GH Actions workflow - Simplified the workflow based on @malfet's suggestion by combining build and test jobs into one as we only run a small subset of tests for bazel - Tested the run to make sure it succeeds - Build step takes 4 minutes, test step takes 7 minutes The downside of this approach is that I duplicated some of the jobs in a new template file. Alternative solution would be to use something like this https://jinja.palletsprojects.com/en/3.0.x/templates/#template-inheritance, however, that is better to be done in a separate PR as linux and windows workflows would need to be changed. Another solution is to use a bunch of if else statements in a linux workflow template to accommodate bazel build as part of it, but this seems not as clean as template inheritance with jinja. Here is a link to the latest bazel run with this change https://github.com/pytorch/pytorch/actions/runs/1004656584 [ghstack-poisoned]
- Added a new template for bazel GH Actions workflow - Simplified the workflow based on @malfet's suggestion by combining build and test jobs into one as we only run a small subset of tests for bazel - Tested the run to make sure it succeeds - Build step takes 4 minutes, test step takes 7 minutes The downside of this approach is that I duplicated some of the jobs in a new template file. Alternative solution would be to use something like this https://jinja.palletsprojects.com/en/3.0.x/templates/#template-inheritance, however, that is better to be done in a separate PR as linux and windows workflows would need to be changed. Another solution is to use a bunch of if else statements in a linux workflow template to accommodate bazel build as part of it, but this seems not as clean as template inheritance with jinja. Here is a link to the latest bazel run with this change https://github.com/pytorch/pytorch/actions/runs/1004656584 [ghstack-poisoned]
- Added a new template for bazel GH Actions workflow - Simplified the workflow based on @malfet's suggestion by combining build and test jobs into one as we only run a small subset of tests for bazel - Tested the run to make sure it succeeds - Build step takes 4 minutes, test step takes 7 minutes The downside of this approach is that I duplicated some of the jobs in a new template file. Alternative solution would be to use something like this https://jinja.palletsprojects.com/en/3.0.x/templates/#template-inheritance, however, that is better to be done in a separate PR as linux and windows workflows would need to be changed. Another solution is to use a bunch of if else statements in a linux workflow template to accommodate bazel build as part of it, but this seems not as clean as template inheritance with jinja. Here is a link to the latest bazel run with this change https://github.com/pytorch/pytorch/actions/runs/1004656584 [ghstack-poisoned]
Contributor
Author
|
@rsemenov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
jasperzhong
pushed a commit
to jasperzhong/swift
that referenced
this pull request
Nov 25, 2021
ghstack-source-id: f5b9f0d Pull Request resolved: pytorch/pytorch#61039
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
The downside of this approach is that I duplicated some of the jobs in a new template file. Alternative solution would be to use something like this https://jinja.palletsprojects.com/en/3.0.x/templates/#template-inheritance, however, that is better to be done in a separate PR as linux and windows workflows would need to be changed. Another solution is to use a bunch of if else statements in a linux workflow template to accommodate bazel build as part of it, but this seems not as clean as template inheritance with jinja.
Here is a link to the latest bazel run with this change https://github.com/pytorch/pytorch/actions/runs/1004656584
Differential Revision: D29562260