Port other comparison ops: `ne`, `lt`, `gt`, `le`, `ge` to structured kernels. #60942

ysiraichi · 2021-06-29T10:50:05Z

Stack from ghstack:

Port other comparison ops: ne, lt, gt, le, ge to structured kernels. #60942 Port other comparison ops: ne, lt, gt, le, ge to structured kernels.
Port eq kernel to structured kernels. #60177 Port eq kernel to structured kernels.

Tracking Issue: #55070

This PR applies the same transformation of eq to the other comparison ops: ne, lt,
gt, le, and ge. Macros for crating meta and impl functions are used (since the
checks they have are the same).

Differential Revision: D29509868

… kernels. Tracking Issue: #55070 This PR applies the same transformation of `eq` to the other comparison ops: `ne`, `lt`, `gt`, `le`, and `ge`. Macros for crating meta and impl functions are used (since the checks they have are the same). [ghstack-poisoned]

facebook-github-bot · 2021-06-29T10:50:11Z

💊 CI failures summary and remediations

As of commit e2eb913 (more details on the Dr. CI page and at hud.pytorch.org/pr/60942):

3/3 failures possibly* introduced in this PR
- 1/3 non-scanned failure(s)

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_xla_linux_bionic_py3_6_clang9_build (1/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.

CONFLICT (add/add): Merge conflict in aten/src/ATen/native/cpu/BinaryOpsKernel.cpp
Auto-merging aten/src/ATen/native/cpu/BinaryOpsKernel.cpp
CONFLICT (add/add): Merge conflict in aten/src/ATen/native/BinaryOps.h
Auto-merging aten/src/ATen/native/BinaryOps.h
CONFLICT (add/add): Merge conflict in aten/src/ATen/native/BinaryOps.cpp
Auto-merging aten/src/ATen/native/BinaryOps.cpp
CONFLICT (add/add): Merge conflict in aten/src/ATen/TensorIterator.h
Auto-merging aten/src/ATen/TensorIterator.h
CONFLICT (add/add): Merge conflict in aten/src/ATen/TensorIterator.cpp
Auto-merging aten/src/ATen/TensorIterator.cpp
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

pytorch_linux_xenial_py3_6_gcc5_4_build (2/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.

CONFLICT (add/add): Merge conflict in aten/src/ATen/native/cpu/BinaryOpsKernel.cpp
Auto-merging aten/src/ATen/native/cpu/BinaryOpsKernel.cpp
CONFLICT (add/add): Merge conflict in aten/src/ATen/native/BinaryOps.h
Auto-merging aten/src/ATen/native/BinaryOps.h
CONFLICT (add/add): Merge conflict in aten/src/ATen/native/BinaryOps.cpp
Auto-merging aten/src/ATen/native/BinaryOps.cpp
CONFLICT (add/add): Merge conflict in aten/src/ATen/TensorIterator.h
Auto-merging aten/src/ATen/TensorIterator.h
CONFLICT (add/add): Merge conflict in aten/src/ATen/TensorIterator.cpp
Auto-merging aten/src/ATen/TensorIterator.cpp
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

Preview docs built from this PR

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

… kernels. Tracking Issue: #55070 This PR applies the same transformation of `eq` to the other comparison ops: `ne`, `lt`, `gt`, `le`, and `ge`. Macros for crating meta and impl functions are used (since the checks they have are the same). ghstack-source-id: 8282a16 Pull Request resolved: #60942

ysiraichi · 2021-06-30T11:06:51Z

The 3 CI failures don't seem related to this PR.

ezyang · 2021-07-01T03:37:34Z

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

… structured kernels." Tracking Issue: #55070 This PR applies the same transformation of `eq` to the other comparison ops: `ne`, `lt`, `gt`, `le`, and `ge`. Macros for crating meta and impl functions are used (since the checks they have are the same). Differential Revision: [D29509868](https://our.internmc.facebook.com/intern/diff/D29509868) [ghstack-poisoned]

… kernels. Tracking Issue: #55070 This PR applies the same transformation of `eq` to the other comparison ops: `ne`, `lt`, `gt`, `le`, and `ge`. Macros for crating meta and impl functions are used (since the checks they have are the same). ghstack-source-id: dc33e36 Pull Request resolved: #60942

ezyang · 2021-07-01T17:54:17Z

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

… structured kernels." Tracking Issue: #55070 This PR applies the same transformation of `eq` to the other comparison ops: `ne`, `lt`, `gt`, `le`, and `ge`. Macros for crating meta and impl functions are used (since the checks they have are the same). Differential Revision: [D29509868](https://our.internmc.facebook.com/intern/diff/D29509868) [ghstack-poisoned]

… kernels. Tracking Issue: #55070 This PR applies the same transformation of `eq` to the other comparison ops: `ne`, `lt`, `gt`, `le`, and `ge`. Macros for crating meta and impl functions are used (since the checks they have are the same). ghstack-source-id: 5ca595c Pull Request resolved: #60942

ezyang · 2021-07-06T15:01:06Z

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

… structured kernels." Tracking Issue: #55070 This PR applies the same transformation of `eq` to the other comparison ops: `ne`, `lt`, `gt`, `le`, and `ge`. Macros for crating meta and impl functions are used (since the checks they have are the same). Differential Revision: [D29509868](https://our.internmc.facebook.com/intern/diff/D29509868) [ghstack-poisoned]

… kernels. Tracking Issue: #55070 This PR applies the same transformation of `eq` to the other comparison ops: `ne`, `lt`, `gt`, `le`, and `ge`. Macros for crating meta and impl functions are used (since the checks they have are the same). ghstack-source-id: f1f20c6 Pull Request resolved: #60942

ezyang · 2021-07-12T15:38:29Z

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2021-07-20T02:14:31Z

@ezyang merged this pull request in 208d06c.

ysiraichi mentioned this pull request Jun 29, 2021

Port eq kernel to structured kernels. #60177

Closed

facebook-github-bot added the cla signed label Jun 29, 2021

pytorchbot added the open source label Jun 29, 2021

ysiraichi marked this pull request as ready for review June 29, 2021 11:28

ysiraichi requested a review from ezyang as a code owner June 29, 2021 11:28

ysiraichi requested a review from bdhirsh June 29, 2021 11:29

ezyang approved these changes Jul 1, 2021

View reviewed changes

ezyang requested a review from SplitInfinity July 6, 2021 16:39

facebook-github-bot closed this in 208d06c Jul 20, 2021

facebook-github-bot added the Merged label Jul 20, 2021

ysiraichi deleted the gh/ysiraichi/14/head branch July 20, 2021 09:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Port other comparison ops: `ne`, `lt`, `gt`, `le`, `ge` to structured kernels. #60942

Port other comparison ops: `ne`, `lt`, `gt`, `le`, `ge` to structured kernels. #60942

Uh oh!

ysiraichi commented Jun 29, 2021 •

edited by ezyang

Loading

Uh oh!

facebook-github-bot commented Jun 29, 2021 •

edited

Loading

Uh oh!

ysiraichi commented Jun 30, 2021

Uh oh!

ezyang commented Jul 1, 2021

Uh oh!

ezyang commented Jul 1, 2021

Uh oh!

ezyang commented Jul 6, 2021

Uh oh!

ezyang commented Jul 12, 2021

Uh oh!

facebook-github-bot commented Jul 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Port other comparison ops: ne, lt, gt, le, ge to structured kernels. #60942

Port other comparison ops: ne, lt, gt, le, ge to structured kernels. #60942

Uh oh!

Conversation

ysiraichi commented Jun 29, 2021 • edited by ezyang Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Jun 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

🕵️ 2 new failures recognized by patterns

pytorch_xla_linux_bionic_py3_6_clang9_build (1/2)

pytorch_linux_xenial_py3_6_gcc5_4_build (2/2)

Uh oh!

ysiraichi commented Jun 30, 2021

Uh oh!

ezyang commented Jul 1, 2021

Uh oh!

ezyang commented Jul 1, 2021

Uh oh!

ezyang commented Jul 6, 2021

Uh oh!

ezyang commented Jul 12, 2021

Uh oh!

facebook-github-bot commented Jul 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Port other comparison ops: `ne`, `lt`, `gt`, `le`, `ge` to structured kernels. #60942

Port other comparison ops: `ne`, `lt`, `gt`, `le`, `ge` to structured kernels. #60942

ysiraichi commented Jun 29, 2021 •

edited by ezyang

Loading

facebook-github-bot commented Jun 29, 2021 •

edited

Loading