-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[skip ci] Add more Linux workflows #60889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 485e9aa (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
| PyTorchLinuxWorkflow( | ||
| build_environment="pytorch-linux-xenial-py3.6-clang5-asan", | ||
| docker_image_base=f"{DOCKER_REGISTRY}/pytorch/pytorch-linux-xenial-py3-clang5-asan", | ||
| test_runner_type=LINUX_CPU_TEST_RUNNER, | ||
| ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this have two shards?
| PyTorchLinuxWorkflow( | ||
| build_environment="pytorch-linux-bionic-py3.8-gcc9-coverage", | ||
| docker_image_base=f"{DOCKER_REGISTRY}/pytorch/pytorch-linux-bionic-py3.8-gcc9", | ||
| test_runner_type=LINUX_CPU_TEST_RUNNER, | ||
| ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one has already been merged in #61050, right?
| PyTorchLinuxWorkflow( | ||
| build_environment="pytorch-linux-bionic-rocm3.9-py3.6", | ||
| docker_image_base=f"{DOCKER_REGISTRY}/pytorch/pytorch-linux-bionic-rocm3.9-py3.6", | ||
| test_runner_type=LINUX_CPU_TEST_RUNNER, | ||
| ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one isn't supposed to have a test job associated with it, is it?
| PyTorchLinuxWorkflow( | ||
| build_environment="pytorch-linux-xenial-py3.6-clang7-onnx", | ||
| docker_image_base=f"{DOCKER_REGISTRY}/pytorch/pytorch-linux-xenial-py3-clang7-onnx", | ||
| test_runner_type=LINUX_CPU_TEST_RUNNER, | ||
| ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one should also have two shards if I'm not mistaken
| PyTorchLinuxWorkflow( | ||
| build_environment="pytorch-pure_torch-linux-xenial-py3.6-gcc5.4", | ||
| docker_image_base=f"{DOCKER_REGISTRY}/pytorch/pytorch-linux-xenial-py3.6-gcc5.4", | ||
| test_runner_type=LINUX_CPU_TEST_RUNNER, | ||
| ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one also isn't supposed to have a test job attached to it
| PyTorchLinuxWorkflow( | ||
| build_environment="pytorch-libtorch-linux-xenial-cuda11.1-cudnn8-py3.6-gcc7", | ||
| docker_image_base=f"{DOCKER_REGISTRY}/pytorch/pytorch-linux-xenial-cuda11.1-cudnn8-py3-gcc7", | ||
| test_runner_type=LINUX_CUDA_TEST_RUNNER, | ||
| ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same for this one regarding not having a test job
According to #57686, I think you're missing a few:
|
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Stack from ghstack:
This enables the remaining non-android Linux workflows, see #60890 for testing
Differential Revision: D29471138