Skip to content

Conversation

@driazati
Copy link
Contributor

@driazati driazati commented Jun 28, 2021

Stack from ghstack:

This enables the remaining non-android Linux workflows, see #60890 for testing

Differential Revision: D29471138

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 28, 2021

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 485e9aa (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@driazati
Copy link
Contributor Author

@driazati has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@driazati driazati requested a review from a team June 30, 2021 19:40
Comment on lines +130 to +134
PyTorchLinuxWorkflow(
build_environment="pytorch-linux-xenial-py3.6-clang5-asan",
docker_image_base=f"{DOCKER_REGISTRY}/pytorch/pytorch-linux-xenial-py3-clang5-asan",
test_runner_type=LINUX_CPU_TEST_RUNNER,
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this have two shards?

Comment on lines +170 to +174
PyTorchLinuxWorkflow(
build_environment="pytorch-linux-bionic-py3.8-gcc9-coverage",
docker_image_base=f"{DOCKER_REGISTRY}/pytorch/pytorch-linux-bionic-py3.8-gcc9",
test_runner_type=LINUX_CPU_TEST_RUNNER,
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one has already been merged in #61050, right?

Comment on lines +175 to +179
PyTorchLinuxWorkflow(
build_environment="pytorch-linux-bionic-rocm3.9-py3.6",
docker_image_base=f"{DOCKER_REGISTRY}/pytorch/pytorch-linux-bionic-rocm3.9-py3.6",
test_runner_type=LINUX_CPU_TEST_RUNNER,
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one isn't supposed to have a test job associated with it, is it?

Comment on lines +135 to +139
PyTorchLinuxWorkflow(
build_environment="pytorch-linux-xenial-py3.6-clang7-onnx",
docker_image_base=f"{DOCKER_REGISTRY}/pytorch/pytorch-linux-xenial-py3-clang7-onnx",
test_runner_type=LINUX_CPU_TEST_RUNNER,
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one should also have two shards if I'm not mistaken

Comment on lines +120 to +124
PyTorchLinuxWorkflow(
build_environment="pytorch-pure_torch-linux-xenial-py3.6-gcc5.4",
docker_image_base=f"{DOCKER_REGISTRY}/pytorch/pytorch-linux-xenial-py3.6-gcc5.4",
test_runner_type=LINUX_CPU_TEST_RUNNER,
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one also isn't supposed to have a test job attached to it

Comment on lines +150 to +154
PyTorchLinuxWorkflow(
build_environment="pytorch-libtorch-linux-xenial-cuda11.1-cudnn8-py3.6-gcc7",
docker_image_base=f"{DOCKER_REGISTRY}/pytorch/pytorch-linux-xenial-cuda11.1-cudnn8-py3-gcc7",
test_runner_type=LINUX_CUDA_TEST_RUNNER,
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for this one regarding not having a test job

@samestep
Copy link
Contributor

This enables the remaining non-android Linux workflows

According to #57686, I think you're missing a few:

  • pytorch-linux-xenial-py3.6-gcc5.4
    • backward-compatibility-check
    • cpp-doc
    • python-doc-push
    • doc-test
    • jit-legacy-test
  • pytorch-libtorch-linux-xenial-cuda10.2-cudnn7-py3.6-gcc7

@github-actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
Stale pull requests will automatically be closed 30 days after being marked Stale

@github-actions github-actions bot added the Stale label Sep 11, 2021
@driazati driazati closed this Oct 20, 2021
@facebook-github-bot facebook-github-bot deleted the gh/driazati/54/head branch November 20, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants