Skip to content

Conversation

@seemethere
Copy link
Member

@seemethere seemethere commented Jun 17, 2021

Stack from ghstack:

This was originally a feature for CircleCI so let's add these builds back for GHA

Signed-off-by: Eli Uriegas [email protected]

Differential Revision: D29214519

Signed-off-by: Eli Uriegas <[email protected]>

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 17, 2021

💊 CI failures summary and remediations

As of commit 85fc690 (more details on the Dr. CI page and at hud.pytorch.org/pr/60215):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

seemethere added a commit that referenced this pull request Jun 17, 2021
Signed-off-by: Eli Uriegas <[email protected]>

ghstack-source-id: 2abfd93
Pull Request resolved: #60215

Signed-off-by: Eli Uriegas <[email protected]>
@seemethere
Copy link
Member Author

@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@seemethere seemethere requested a review from a team June 17, 2021 22:44
@seemethere seemethere added module: ci Related to continuous integration module: windows Windows support for PyTorch labels Jun 17, 2021
"test_runner_type": test_runner_type,
"cuda_version": cuda_version,
"on_pull_request": on_pull_request,
"only_build_on_pull_request": only_build_on_pull_request and on_pull_request,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should never be a scenario where only_build_on_pull_request=True and on_pull_request=False

@facebook-github-bot
Copy link
Contributor

@seemethere merged this pull request in 047925d.

@facebook-github-bot facebook-github-bot deleted the gh/seemethere/109/head branch June 21, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged module: ci Related to continuous integration module: windows Windows support for PyTorch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants