Port `eq` kernel to structured kernels. #60177

ysiraichi · 2021-06-17T11:50:48Z

Stack from ghstack:

Port other comparison ops: ne, lt, gt, le, ge to structured kernels. #60942 Port other comparison ops: ne, lt, gt, le, ge to structured kernels.
Port eq kernel to structured kernels. #60177 Port eq kernel to structured kernels.

Tracking issue: #55070

Differential Revision: D29509871

Tracking issue: #55070 [ghstack-poisoned]

facebook-github-bot · 2021-06-17T11:50:55Z

💊 CI failures summary and remediations

As of commit 3c1fa9e (more details on the Dr. CI page and at hud.pytorch.org/pr/60177):

3/4 failures possibly* introduced in this PR
- 1/3 non-scanned failure(s)
1/4 tentatively recognized as flaky ❄️
- Click here to rerun these jobs

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_linux_xenial_py3_6_gcc5_4_build (1/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.

CONFLICT (add/add): Merge conflict in aten/src/ATen/native/cpu/BinaryOpsKernel.cpp
Auto-merging aten/src/ATen/native/cpu/BinaryOpsKernel.cpp
CONFLICT (add/add): Merge conflict in aten/src/ATen/native/BinaryOps.h
Auto-merging aten/src/ATen/native/BinaryOps.h
CONFLICT (add/add): Merge conflict in aten/src/ATen/native/BinaryOps.cpp
Auto-merging aten/src/ATen/native/BinaryOps.cpp
CONFLICT (add/add): Merge conflict in aten/src/ATen/TensorIterator.h
Auto-merging aten/src/ATen/TensorIterator.h
CONFLICT (add/add): Merge conflict in aten/src/ATen/TensorIterator.cpp
Auto-merging aten/src/ATen/TensorIterator.cpp
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

pytorch_xla_linux_bionic_py3_6_clang9_build (2/2)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.

CONFLICT (add/add): Merge conflict in aten/src/ATen/native/cpu/BinaryOpsKernel.cpp
Auto-merging aten/src/ATen/native/cpu/BinaryOpsKernel.cpp
CONFLICT (add/add): Merge conflict in aten/src/ATen/native/BinaryOps.h
Auto-merging aten/src/ATen/native/BinaryOps.h
CONFLICT (add/add): Merge conflict in aten/src/ATen/native/BinaryOps.cpp
Auto-merging aten/src/ATen/native/BinaryOps.cpp
CONFLICT (add/add): Merge conflict in aten/src/ATen/TensorIterator.h
Auto-merging aten/src/ATen/TensorIterator.h
CONFLICT (add/add): Merge conflict in aten/src/ATen/TensorIterator.cpp
Auto-merging aten/src/ATen/TensorIterator.cpp
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

pytorch_bazel_build (1/1)

Step: "Set Up CI Environment After attach_workspace" (full log | diagnosis details | 🔁 rerun) ❄️

E: Failed to fetch http://mirrors.lug.mtu.edu/u....3.16), connection timed out [IP: 104.22.5.179 80]

+ sudo rm -f /etc/apt/heroku.list
+ sudo rm -f /etc/apt/openjdk-r-ubuntu-ppa-xenial.list
+ sudo rm -f /etc/apt/partner.list
+ sudo sed -i -e 's/http:\/\/.*archive/mirror:\/\/mirrors/' -e 's/\/ubuntu\//\/mirrors.txt/' /etc/apt/sources.list
+ echo 'APT::Acquire::Retries "3";'
+ sudo tee /etc/apt/apt.conf.d/80-retries
APT::Acquire::Retries "3";
+ retry sudo apt-get update -qq
+ sudo apt-get update -qq
W: --force-yes is deprecated, use one of the options starting with --allow instead.
E: Failed to fetch http://mirrors.lug.mtu.edu/ubuntu/dists/focal-updates/main/cnf/by-hash/SHA256/6df30ae031e349bad234da9e5fe4580f79dadb109c5a8fc583682a2808d92793  Could not connect to mirrors.usinternet.com:80 (216.17.3.16), connection timed out [IP: 104.22.5.179 80]
E: Some index files failed to download. They have been ignored, or old ones used instead.
+ sudo apt-get update -qq
W: --force-yes is deprecated, use one of the options starting with --allow instead.
+ retry sudo apt-get -y install moreutils expect-dev
+ sudo apt-get -y install moreutils expect-dev

Reading package lists... 0%

Reading package lists... 100%

Reading package lists... Done


Building dependency tree... 0%

Building dependency tree... 0%

Building dependency tree... 50%

Building dependency tree... 50%

Building dependency tree       


Reading state information... 0%

Reading state information... 0%

Reading state information... Done

Note, selecting 'expect' instead of 'expect-dev'
The following additional packages will be installed:

Preview docs built from this PR

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Tracking issue: #55070 ghstack-source-id: 554476c Pull Request resolved: #60177

Tracking issue: #55070 [ghstack-poisoned]

Tracking issue: #55070 ghstack-source-id: d58e3e7 Pull Request resolved: #60177

Tracking issue: #55070 [ghstack-poisoned]

Tracking issue: #55070 ghstack-source-id: 1e7ddb3 Pull Request resolved: #60177

Tracking issue: #55070 [ghstack-poisoned]

ysiraichi · 2021-06-30T11:07:00Z

The 3 CI failures don't seem related to this PR.

ezyang · 2021-07-01T03:37:27Z

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

aten/src/ATen/native/BinaryOps.cpp

ezyang · 2021-07-01T03:59:26Z

aten/src/ATen/native/BinaryOps.cpp

+      native::check_convert(other.item(), self.scalar_type());
+    } else if (self.dim() == 0 && other.dim() != 0) {
+      native::check_convert(self.item(), other.scalar_type());
+    }


Note to reviewers: this is ported code that cannot be deleted (and is not otherwise modified); hopefully to be deleted next PR

@ngimel this logic looks potentially inefficient: if I have a CUDA scalar and I pass it to a comparison operation, I'm gonna sync for not very good reason.

why will be be able to remove it in a future PR?

no, as currently specced this is impossible to remove unless you turn it into an async cuda assert

FYI, now people are rightfully complaining about it (and sorry I missed the original ping a year ago, lol) D36012582

Tracking issue: #55070 Differential Revision: [D29509871](https://our.internmc.facebook.com/intern/diff/D29509871) [ghstack-poisoned]

aten/src/ATen/TensorIterator.cpp

ezyang · 2021-07-01T17:54:14Z

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Tracking issue: #55070 Differential Revision: [D29509871](https://our.internmc.facebook.com/intern/diff/D29509871) [ghstack-poisoned]

ezyang · 2021-07-06T15:01:04Z

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

ysiraichi · 2021-07-12T11:09:21Z

The CI failures don't seem to be related to this PR.

Tracking issue: #55070 Differential Revision: [D29509871](https://our.internmc.facebook.com/intern/diff/D29509871) [ghstack-poisoned]

ezyang · 2021-07-12T15:38:20Z

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2021-07-20T02:14:28Z

@ezyang merged this pull request in 9732713.

Port eq kernel to structured kernels.

9d16646

Tracking issue: #55070 [ghstack-poisoned]

facebook-github-bot added the cla signed label Jun 17, 2021

ysiraichi added a commit that referenced this pull request Jun 17, 2021

Port eq kernel to structured kernels.

98d57ce

Tracking issue: #55070 ghstack-source-id: 554476c Pull Request resolved: #60177

pytorchbot added the open source label Jun 17, 2021

Update on "Port eq kernel to structured kernels."

7b928dd

Tracking issue: #55070 [ghstack-poisoned]

ysiraichi added a commit that referenced this pull request Jun 22, 2021

Port eq kernel to structured kernels.

960573d

Tracking issue: #55070 ghstack-source-id: d58e3e7 Pull Request resolved: #60177

Update on "Port eq kernel to structured kernels."

c279456

Tracking issue: #55070 [ghstack-poisoned]

ysiraichi added a commit that referenced this pull request Jun 25, 2021

Port eq kernel to structured kernels.

c84b88f

Tracking issue: #55070 ghstack-source-id: 1e7ddb3 Pull Request resolved: #60177

Update on "Port eq kernel to structured kernels."

3127c42

Tracking issue: #55070 [ghstack-poisoned]

ysiraichi mentioned this pull request Jun 29, 2021

Port other comparison ops: ne, lt, gt, le, ge to structured kernels. #60942

Closed

ysiraichi marked this pull request as ready for review June 29, 2021 11:28

ysiraichi requested a review from ezyang as a code owner June 29, 2021 11:28

ysiraichi requested a review from bdhirsh July 1, 2021 02:56

ezyang reviewed Jul 1, 2021

View reviewed changes

aten/src/ATen/native/BinaryOps.cpp Outdated Show resolved Hide resolved

ezyang reviewed Jul 1, 2021

View reviewed changes

aten/src/ATen/native/BinaryOps.cpp Show resolved Hide resolved

ezyang reviewed Jul 1, 2021

View reviewed changes

ezyang approved these changes Jul 1, 2021

View reviewed changes

Update on "Port eq kernel to structured kernels."

7ec9f85

Tracking issue: #55070 Differential Revision: [D29509871](https://our.internmc.facebook.com/intern/diff/D29509871) [ghstack-poisoned]

bdhirsh reviewed Jul 1, 2021

View reviewed changes

aten/src/ATen/TensorIterator.cpp Show resolved Hide resolved

ysiraichi added 2 commits July 2, 2021 18:57

Update on "Port eq kernel to structured kernels."

be9fda2

Tracking issue: #55070 Differential Revision: [D29509871](https://our.internmc.facebook.com/intern/diff/D29509871) [ghstack-poisoned]

Update on "Port eq kernel to structured kernels."

0df56e3

Tracking issue: #55070 Differential Revision: [D29509871](https://our.internmc.facebook.com/intern/diff/D29509871) [ghstack-poisoned]

SplitInfinity mentioned this pull request Jul 6, 2021

Port kernels to be structured [tracker] #55070

Closed

Update on "Port eq kernel to structured kernels."

3c1fa9e

Tracking issue: #55070 Differential Revision: [D29509871](https://our.internmc.facebook.com/intern/diff/D29509871) [ghstack-poisoned]

facebook-github-bot closed this in 9732713 Jul 20, 2021

facebook-github-bot added the Merged label Jul 20, 2021

ysiraichi deleted the gh/ysiraichi/7/head branch July 20, 2021 09:32

Freey0 mentioned this pull request Aug 31, 2021

test_binary_ufuncs.test_inplace_comparison_ops_require_inputs_have_same_dtype May have been damaged #64018

Closed

ngimel mentioned this pull request Oct 2, 2021

Comparison operators throw internal assert for cpu scalar - cuda tensor op #66053

Closed

Port eq kernel to structured kernels. #60177

Port eq kernel to structured kernels. #60177

Uh oh!

Conversation

ysiraichi commented Jun 17, 2021 • edited by ezyang Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Jun 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

🕵️ 2 new failures recognized by patterns

pytorch_linux_xenial_py3_6_gcc5_4_build (1/2)

pytorch_xla_linux_bionic_py3_6_clang9_build (2/2)

❄️ 1 failure tentatively classified as flaky

pytorch_bazel_build (1/1)

Uh oh!

ysiraichi commented Jun 30, 2021

Uh oh!

ezyang commented Jul 1, 2021

Uh oh!

Uh oh!

Uh oh!

ezyang Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

ezyang Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

bdhirsh Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

ezyang Jul 1, 2021

Choose a reason for hiding this comment

Uh oh!

ngimel May 17, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ezyang commented Jul 1, 2021

Uh oh!

ezyang commented Jul 6, 2021

Uh oh!

ysiraichi commented Jul 12, 2021

Uh oh!

ezyang commented Jul 12, 2021

Uh oh!

facebook-github-bot commented Jul 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Port `eq` kernel to structured kernels. #60177

Port `eq` kernel to structured kernels. #60177

ysiraichi commented Jun 17, 2021 •

edited by ezyang

Loading

facebook-github-bot commented Jun 17, 2021 •

edited

Loading