-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Update lint.yml to use custom clang-tidy build #59967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit 2c52c14 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
I approved but it looks like it's failing :P https://github.com/pytorch/pytorch/runs/2822676682?check_suite_focus=true so you should probably fix that before merging |
|
Hmm yea, debugged it a little. Looks like the git version on the image is not high enough. I'll push a fix to test-infra and update the image hash. |
|
still failing :/ https://github.com/pytorch/pytorch/runs/2823573416?check_suite_focus=true |
|
btw, that step is failing, looks like the clang-tidy has a newer version, thus it checks new rules? |
yeah; progress, though! |
d3adbe8 to
2c52c14
Compare
|
@1ntEgr8 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Related: #59815