Skip to content

Conversation

@1ntEgr8
Copy link
Contributor

@1ntEgr8 1ntEgr8 commented Jun 14, 2021

Related: #59815

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 14, 2021

💊 CI failures summary and remediations

As of commit 2c52c14 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@samestep
Copy link
Contributor

I approved but it looks like it's failing :P https://github.com/pytorch/pytorch/runs/2822676682?check_suite_focus=true so you should probably fix that before merging

@1ntEgr8
Copy link
Contributor Author

1ntEgr8 commented Jun 14, 2021

Hmm yea, debugged it a little. Looks like the git version on the image is not high enough. I'll push a fix to test-infra and update the image hash.

@samestep
Copy link
Contributor

still failing :/ https://github.com/pytorch/pytorch/runs/2823573416?check_suite_focus=true

+ time python3 setup.py --cmake-only build
Traceback (most recent call last):
  File "setup.py", line 203, in <module>
    from setuptools import setup, Extension, find_packages
ModuleNotFoundError: No module named 'setuptools'

@zhouzhuojie
Copy link
Contributor

btw, that step is failing, looks like the clang-tidy has a newer version, thus it checks new rules?

@samestep
Copy link
Contributor

btw, that step is failing, looks like the clang-tidy has a newer version, thus it checks new rules?

yeah; progress, though!

@1ntEgr8 1ntEgr8 force-pushed the custom-clang-tidy branch from d3adbe8 to 2c52c14 Compare June 16, 2021 02:02
@facebook-github-bot
Copy link
Contributor

@1ntEgr8 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@1ntEgr8 merged this pull request in a6ecfb3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants