reflection_pad1d_backward: Port to structured
#59103
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
💊 CI failures summary and remediationsAs of commit 37b9149 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
Test failure is real but probably should be easy to fix, maybe I can point you where it needs fixing. |
Contributor
|
Ah yes, the message wobbled (because we deduped to |
ezyang
reviewed
Jun 2, 2021
ezyang
reviewed
Jun 2, 2021
ezyang
reviewed
Jun 2, 2021
Contributor
|
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…1d_backward-to-structured
Contributor
|
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
deniskokarev
pushed a commit
to deniskokarev/pytorch
that referenced
this pull request
Jun 9, 2021
Summary: Tracking Issue: pytorch#55070 Port `reflection_pad1d_backward` to structured kernel. Pull Request resolved: pytorch#59103 Test Plan: Pre-existing tests Reviewed By: jbschlosser Differential Revision: D28836043 Pulled By: ezyang fbshipit-source-id: 4c3b0880edf305896f540113dcab70c8af24253b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking Issue: #55070
Summary:
Port
reflection_pad1d_backwardto structured kernel.Test Plan:
Pre-existing tests