Skip to content

avg_pool3d_backward: Port to structured #59084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Freey0 wants to merge 8 commits into from
Closed

avg_pool3d_backward: Port to structured #59084

Freey0 wants to merge 8 commits into from

Conversation

@Freey0
Copy link
Contributor

@Freey0 Freey0 commented May 27, 2021 •
edited
Loading

Stack from ghstack:

Differential Revision: D28802619

@Freey0 Freey0 requested a review from ezyang as a code owner May 27, 2021 15:06
This was referenced May 27, 2021
Closed
Closed
@Freey0 Freey0 mentioned this pull request May 27, 2021
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 27, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 6114794 (more details on the Dr. CI page and at hud.pytorch.org/pr/59084):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Freey0 added a commit that referenced this pull request May 27, 2021
@Freey0
avg_pool3d_backward: Port to structured
e2c7cef 
ghstack-source-id: 57bc412
Pull Request resolved: #59084
Freey0 added a commit that referenced this pull request May 29, 2021
@Freey0
avg_pool3d_backward: Port to structured
3fdf25b 
ghstack-source-id: 21a3317
Pull Request resolved: #59084
Freey0 added a commit that referenced this pull request May 30, 2021
@Freey0
avg_pool3d_backward: Port to structured
582cb1b 
ghstack-source-id: 9023455
Pull Request resolved: #59084
@ezyang
Copy link
Contributor

ezyang commented Jun 1, 2021

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ezyang
Copy link
Contributor

ezyang commented Jun 1, 2021

failure is real

Freey0 added a commit that referenced this pull request Jun 20, 2021
@Freey0
avg_pool3d_backward: Port to structured
5a801c0 
ghstack-source-id: 2921666
Pull Request resolved: #59084
Freey0 added a commit that referenced this pull request Jun 21, 2021
@Freey0
avg_pool3d_backward: Port to structured
c5a879f 
ghstack-source-id: 5e2a084
Pull Request resolved: #59084
@ezyang
Copy link
Contributor

ezyang commented Jun 25, 2021

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Freey0 added a commit that referenced this pull request Jun 26, 2021
@Freey0
avg_pool3d_backward: Port to structured
14ad860 
ghstack-source-id: 6b84613
Pull Request resolved: #59084
@ezyang
Copy link
Contributor

ezyang commented Jun 28, 2021

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ezyang
Copy link
Contributor

ezyang commented Jun 28, 2021

more internal failures

 caffe2/aten/src/ATen/native/AveragePool3d.cpp:466:17: error: unused variable 'otime_for_shape_check' [-Werror,-Wunused-variable]
  const int64_t otime_for_shape_check = pooling_output_shape<int64_t>(itime, kT, padT, dT, 1, ceil_mode);
caffe2/aten/src/ATen/native/AveragePool3d.cpp:467:17: error: unused variable 'oheight_for_shape_check' [-Werror,-Wunused-variable]
  const int64_t oheight_for_shape_check = pooling_output_shape<int64_t>(iheight, kH, padH, dH, 1, ceil_mode);
                ^
caffe2/aten/src/ATen/native/AveragePool3d.cpp:468:17: error: unused variable 'owidth_for_shape_check' [-Werror,-Wunused-variable]
  const int64_t owidth_for_shape_check = pooling_output_shape<int64_t>(iwidth, kW, padW, dW, 1, ceil_mode);

Freey0 added a commit that referenced this pull request Jun 29, 2021
@Freey0
avg_pool3d_backward: Port to structured
65b1fa9 
ghstack-source-id: d044ef3
Pull Request resolved: #59084
@ezyang
Copy link
Contributor

ezyang commented Jul 1, 2021

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ezyang ezyang requested a review from SplitInfinity July 6, 2021 16:40
@SplitInfinity SplitInfinity mentioned this pull request Jul 6, 2021
Closed
Freey0 added a commit that referenced this pull request Jul 7, 2021
@Freey0
avg_pool3d_backward: Port to structured
546e53e 
ghstack-source-id: 7081c87
Pull Request resolved: #59084
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 7, 2021

@ezyang merged this pull request in a69e947.

@facebook-github-bot facebook-github-bot deleted the gh/Feey0/29/head branch July 11, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@SplitInfinity SplitInfinity Awaiting requested review from SplitInfinity

Assignees

No one assigned

Labels

cla signed Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Freey0 @facebook-github-bot @ezyang @pytorchbot